diff options
author | Simon Marchi <simon.marchi@polymtl.ca> | 2020-08-21 11:55:08 -0400 |
---|---|---|
committer | Simon Marchi <simon.marchi@efficios.com> | 2020-08-21 11:55:08 -0400 |
commit | 5798d69f030a0ff1fe270021963996279a1c7791 (patch) | |
tree | a327ceb464b98bb603e7a618459b466014d45436 /sim/bfin/configure.ac | |
parent | ccf61261eb8cce869ae4452de547a5f3afb074e4 (diff) | |
download | gdb-5798d69f030a0ff1fe270021963996279a1c7791.zip gdb-5798d69f030a0ff1fe270021963996279a1c7791.tar.gz gdb-5798d69f030a0ff1fe270021963996279a1c7791.tar.bz2 |
sim/bfin: include config/pkg.m4 in configure.ac
When trying to re-generate configure in sim/bfin, I get:
$ autoreconf -vf
autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force
autoreconf: configure.ac: tracing
autoreconf: configure.ac: not running libtoolize: --install not given
autoreconf: running: /opt/autostuff/bin/autoconf --force
configure.ac:57: error: possibly undefined macro: AC_CHECK_LIB
If this token and others are legitimate, please use m4_pattern_allow.
See the Autoconf documentation.
autoreconf: /opt/autostuff/bin/autoconf failed with exit status: 1
This happens since commit f693213d126a ("Run `autoreconf -vf` throughout").
The problem (not clear from the error message) is that the
PKG_CHECK_MODULES macro used in configure.ac is undefined. In the past, I
suppose that it relied on the person running autoconf having pkg.m4 (from
pkg-config) in their include path. That's not my case.
Since we recently added a local version of PKG_CHECK_MODULES to our tree,
we can just make sim/bfin/configure.ac use it. This patch makes
configure.ac include config/pkg.m4, and re-generates configure. With this,
the configure script appears to be generated correctly, I am able to
configure and build the bfin simulator.
Note: using sinclude to include the required m4 files makes no sense to
me. These files contain macros we need, if they are not defined then
the resulting file is unusable. And sinclude fails silently if the file
is not found. So, better use include/m4_include.
sim/bfin/ChangeLog:
* configure.ac: Include config/pkg.m4.
Change-Id: I7d8012e5ed510cd7746b94e918f0feb1c701cd83
Diffstat (limited to 'sim/bfin/configure.ac')
-rw-r--r-- | sim/bfin/configure.ac | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sim/bfin/configure.ac b/sim/bfin/configure.ac index 44b9952..47bacb1 100644 --- a/sim/bfin/configure.ac +++ b/sim/bfin/configure.ac @@ -1,6 +1,7 @@ dnl Process this file with autoconf to produce a configure script. AC_INIT(Makefile.in) sinclude(../common/acinclude.m4) +m4_include([../../config/pkg.m4]) SIM_AC_COMMON |