aboutsummaryrefslogtreecommitdiff
path: root/setup.com
diff options
context:
space:
mode:
authorPedro Alves <palves@redhat.com>2017-07-17 15:30:59 +0100
committerPedro Alves <palves@redhat.com>2017-07-17 15:30:59 +0100
commit6a2c1b8790e58ce0688507b5b1f8369aa621a665 (patch)
tree4dc87fb939c2d320c05fa0ef224528c5ee936856 /setup.com
parenteb3ff9a55175dcdac8328b558d54951a14d719b1 (diff)
downloadgdb-6a2c1b8790e58ce0688507b5b1f8369aa621a665.zip
gdb-6a2c1b8790e58ce0688507b5b1f8369aa621a665.tar.gz
gdb-6a2c1b8790e58ce0688507b5b1f8369aa621a665.tar.bz2
"complete" command and completion word break characters
The linespec/locations/completer testcase added later in the series tests every completion with both TAB completion and the "complete" command. This exposed problems in the "complete" command, around determining the completion word point. First, the complete command has a too-simple approximation of what readline's TAB-completion code does to find the completion word point. Unfortunately, readline doesn't expose the functionality it uses internally, so to fix this this patch copies over the relevant code, and adjusts it a bit to better fit the use cases we need it for. (Specifically, our version avoids relying on the rl_word_break_characters, etc. globals, and instead takes those as arguments.) A following patch will want to use this function for TAB-completion too, but the "complete" command was a good excuse to split this to a separate patch. Then, notice how the complete_command does not call into the completer for the command being completed to determine the right set of word break characters. It always uses the default set. That is fixed by having the "complete" command call into complete_line_internal for a full handle_brkchars phase, just TAB-completion. gdb/ChangeLog: 2017-07-17 Pedro Alves <palves@redhat.com> * cli/cli-cmds.c (complete_command): Use a completion tracker along with completion_find_completion_word for handle_brkchars phase. * completer.c (RL_QF_SINGLE_QUOTE, RL_QF_DOUBLE_QUOTE) (RL_QF_BACKSLASH, RL_QF_OTHER_QUOTE): New. (struct gdb_rl_completion_word_info): New. (gdb_rl_find_completion_word): New. (completion_find_completion_word): New. * completer.h (completion_find_completion_word): Declare.
Diffstat (limited to 'setup.com')
0 files changed, 0 insertions, 0 deletions