diff options
| author | Alan Modra <amodra@gmail.com> | 2018-11-06 16:04:40 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2018-11-06 21:17:28 +1030 |
| commit | 715537181e9ba6ab371265fc4455d89533202fc5 (patch) | |
| tree | b6d97bebdc03ff67c69dfd7aa1fa433ec85038f8 /opcodes/ChangeLog | |
| parent | 2eac3da184459607a476ebb5dcebd6e0acf9fefa (diff) | |
| download | gdb-715537181e9ba6ab371265fc4455d89533202fc5.zip gdb-715537181e9ba6ab371265fc4455d89533202fc5.tar.gz gdb-715537181e9ba6ab371265fc4455d89533202fc5.tar.bz2 | |
PowerPC instruction mask checks
The instruction mask bits should never overlap any of the operands,
nor should operand bits overlap, but some operands weren't checked.
This patch arranges to check the omitted operands, using a mask
returned by the operand->insert function. Some tweaking of various
insert functions is needed to support this: The error case must set
field bits.
Since I was looking at the insert functions, I tidied some dead code
and simplified some of the powerpc_operands entries.
gas/
* config/tc-ppc.c (insn_validate): Don't ignore mask in
PPC_OPSHIFT_INV case. Call the insert function to calculate
a mask.
opcodes/
* ppc-opc.c (insert_arx, insert_ary, insert_rx, insert_ry, insert_ls),
(insert_evuimm1_ex0, insert_evuimm2_ex0, insert_evuimm4_ex0),
(insert_evuimm8_ex0, insert_evuimm_lt8, insert_evuimm_lt16),
(insert_rD_rS_even, insert_off_lsp, insert_off_spe2, insert_Ddd):
Don't return zero on error, insert mask bits instead.
(insert_sd4h, extract_sd4h, insert_sd4w, extract_sd4w): Delete.
(insert_sh6, extract_sh6): Delete dead code.
(insert_sprbat, insert_sprg): Use unsigned comparisions.
(powerpc_operands <OIMM>): Set shift count rather than using
PPC_OPSHIFT_INV.
<SE_SDH, SE_SDW>: Likewise. Don't use insert/extract functions.
Diffstat (limited to 'opcodes/ChangeLog')
| -rw-r--r-- | opcodes/ChangeLog | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog index ce55624..5af52e6 100644 --- a/opcodes/ChangeLog +++ b/opcodes/ChangeLog @@ -1,3 +1,17 @@ +2018-11-06 Alan Modra <amodra@gmail.com> + + * ppc-opc.c (insert_arx, insert_ary, insert_rx, insert_ry, insert_ls), + (insert_evuimm1_ex0, insert_evuimm2_ex0, insert_evuimm4_ex0), + (insert_evuimm8_ex0, insert_evuimm_lt8, insert_evuimm_lt16), + (insert_rD_rS_even, insert_off_lsp, insert_off_spe2, insert_Ddd): + Don't return zero on error, insert mask bits instead. + (insert_sd4h, extract_sd4h, insert_sd4w, extract_sd4w): Delete. + (insert_sh6, extract_sh6): Delete dead code. + (insert_sprbat, insert_sprg): Use unsigned comparisions. + (powerpc_operands <OIMM>): Set shift count rather than using + PPC_OPSHIFT_INV. + <SE_SDH, SE_SDW>: Likewise. Don't use insert/extract functions. + 2018-11-06 Jan Beulich <jbeulich@suse.com> * i386-dis-evex.h (evex_table): Use K suffix instead of %LW for |