diff options
| author | Yao Qi <yao.qi@linaro.org> | 2016-12-29 15:47:40 +0000 |
|---|---|---|
| committer | Yao Qi <yao.qi@linaro.org> | 2016-12-29 15:47:40 +0000 |
| commit | 0a7e10188e3c08403fb00b728644d7a95092c732 (patch) | |
| tree | f812ae364685b510ad42f5bfbbd6720cf083537f /opcodes/ChangeLog | |
| parent | e81830c5c61a8665c098189d069cc68b0df113d3 (diff) | |
| download | gdb-0a7e10188e3c08403fb00b728644d7a95092c732.zip gdb-0a7e10188e3c08403fb00b728644d7a95092c732.tar.gz gdb-0a7e10188e3c08403fb00b728644d7a95092c732.tar.bz2 | |
Return 'int' rather than 'unsigned short' in avrdis_opcode
avrdis_opcode return type is unsigned short, but -1 at the end of
this function is returned. Additionally, print_insn_avr doesn't
handle when -1 (in case of memory error) is returned from
avrdis_opcode.
This patch changes avrdis_opcode returning int indicating the error,
and adds a new argument for instruction we got on success. The
opcode is 16-bit, so I change local variables type to uint16_t,
and include "bfd_stdint.h" as a result. On memory error,
print_insn_avr returns -1, which is a common convention among most
of print_insn_$ARCH functions.
opcodes:
2016-12-29 Yao Qi <yao.qi@linaro.org>
* avr-dis.c: Include "bfd_stdint.h"
(avrdis_opcode): Change return type to int, add argument
insn. Set *INSN on success.
(print_insn_avr): Check return value of avrdis_opcode, and
return -1 on error.
Diffstat (limited to 'opcodes/ChangeLog')
| -rw-r--r-- | opcodes/ChangeLog | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog index 3169dc0..f004163 100644 --- a/opcodes/ChangeLog +++ b/opcodes/ChangeLog @@ -1,3 +1,11 @@ +2016-12-29 Yao Qi <yao.qi@linaro.org> + + * avr-dis.c: Include "bfd_stdint.h" + (avrdis_opcode): Change return type to int, add argument + insn. Set *INSN on success. + (print_insn_avr): Check return value of avrdis_opcode, and + return -1 on error. + 2016-12-28 Alan Modra <amodra@gmail.com> * configure.ac: Revert 2016-12-23. |