diff options
| author | Yao Qi <yao.qi@linaro.org> | 2017-01-12 09:40:41 +0000 |
|---|---|---|
| committer | Yao Qi <yao.qi@linaro.org> | 2017-01-12 09:40:41 +0000 |
| commit | d95014a2ef6e9aee927c13960fa37e509d46eb32 (patch) | |
| tree | f9233ec24b070c2d11888d2cd3f7c1dccc28b5cc /opcodes/ChangeLog | |
| parent | eed0b5b26320bfcdb858a6b889dffe4f037f814d (diff) | |
| download | gdb-d95014a2ef6e9aee927c13960fa37e509d46eb32.zip gdb-d95014a2ef6e9aee927c13960fa37e509d46eb32.tar.gz gdb-d95014a2ef6e9aee927c13960fa37e509d46eb32.tar.bz2 | |
Return -1 on memory error in print_insn_msp430
Disassemblers in opcodes return -1 on memory error, but msp430 doesn't
follow this convention. If I change GDB not to throw exception in
disassemble_info.memory_error_func and rely on the return value of
disassembler, I'll get the following output.
(gdb) disassemble 0x0,+8
Dump of assembler code from 0x0 to 0x8:
0x00000000: .word 0xffff; ????
0x00000002: .word 0xffff; ????
0x00000004: .word 0xffff; ????
0x00000006: .word 0xffff; ????
End of assembler dump.
This patch teaches print_insn_msp430 and its callees to return -1
on memory error.
opcodes:
2017-01-12 Yao Qi <yao.qi@linaro.org>
* msp430-dis.c (msp430_singleoperand): Return -1 if
msp430dis_opcode_signed returns false.
(msp430_doubleoperand): Likewise.
(msp430_branchinstr): Return -1 if
msp430dis_opcode_unsigned returns false.
(msp430x_calla_instr): Likewise.
(print_insn_msp430): Likewise.
Diffstat (limited to 'opcodes/ChangeLog')
| -rw-r--r-- | opcodes/ChangeLog | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog index 8494c51..5d670f6 100644 --- a/opcodes/ChangeLog +++ b/opcodes/ChangeLog @@ -1,3 +1,13 @@ +2017-01-12 Yao Qi <yao.qi@linaro.org> + + * msp430-dis.c (msp430_singleoperand): Return -1 if + msp430dis_opcode_signed returns false. + (msp430_doubleoperand): Likewise. + (msp430_branchinstr): Return -1 if + msp430dis_opcode_unsigned returns false. + (msp430x_calla_instr): Likewise. + (print_insn_msp430): Likewise. + 2017-01-05 Nick Clifton <nickc@redhat.com> PR 20946 |