diff options
| author | Alan Modra <amodra@gmail.com> | 2022-06-12 16:29:05 +0930 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2022-06-14 10:03:55 +0930 |
| commit | d712f2768ac5e71027657d85b921fc0e85d94bcd (patch) | |
| tree | 5725d2e6d081faee5bc818e5c65af4dfa908a16d /ld | |
| parent | 5f269b46201975658dc5f4218acc6d836fa12ab6 (diff) | |
| download | gdb-d712f2768ac5e71027657d85b921fc0e85d94bcd.zip gdb-d712f2768ac5e71027657d85b921fc0e85d94bcd.tar.gz gdb-d712f2768ac5e71027657d85b921fc0e85d94bcd.tar.bz2 | |
BFD_RELOC_MIPS_16
MIPS should not be using BFD_RELOC_16 for its R_MIPS_16 relocation,
since R_MIPS_16 specifies a 16-bit field in a 32-bit word.
BFD_RELOC_16, emitted by generic code to handle fixups on 16-bit data
directives, expects fixups to operate on the whole of a 16-bit word.
This patch corrects the problem by using BFD_RELOC_MIPS_16, a new bfd
reloc that is used to generate R_MIPS_16. BFD_RELOC_16 is handled in
md_apply_fix for cases where the fixup can be applied at assembly
time. Like BFD_RELOC_8, BFD_RELOC_16 now has no corresponding object
file relocation, and thus .half, .hword, .short and .dc.w must be
resolved at assembly time. BFD_RELOC_MIPS_REL16 is removed by this
patch since it isn't used.
PR 3243
PR 26542
* reloc.c (BFD_RELOC_MIPS_16): Rename from BFD_RELOC_MIPS_REL16.
* elf32-mips.c (mips_reloc_map): Map BFD_RELOC_MIPS_16 to R_MIPS_16.
* elf64-mips.c (mips_reloc_map): Likewise, delete BFD_RELOC_MIPS_REL16.
* elfn32-mips.c (mips_reloc_map): Likewise.
* libbfd.h: Regenerate.
* bfd-in2.h: Regenerate.
gas/
* config/tc-mips.c (append_insn): Handle BFD_RELOC_MIPS_16.
(macro_build): Likewise.
(mips_percent_op <%half>): Generate BFD_RELOC_MIPS_16.
(md_apply_fix): Handle BFD_RELOC_16 and BFD_RELOC_MIPS_16 when fx_done.
ld/
* testsuite/ld-mips-elf/reloc-local-overflow.d,
* testsuite/ld-mips-elf/reloc-local-overflow.s: Rewrite.
Diffstat (limited to 'ld')
| -rw-r--r-- | ld/testsuite/ld-mips-elf/reloc-local-overflow.d | 4 | ||||
| -rw-r--r-- | ld/testsuite/ld-mips-elf/reloc-local-overflow.s | 11 |
2 files changed, 6 insertions, 9 deletions
diff --git a/ld/testsuite/ld-mips-elf/reloc-local-overflow.d b/ld/testsuite/ld-mips-elf/reloc-local-overflow.d index 98c5ddb..1405b2d 100644 --- a/ld/testsuite/ld-mips-elf/reloc-local-overflow.d +++ b/ld/testsuite/ld-mips-elf/reloc-local-overflow.d @@ -1,6 +1,6 @@ #name: MIPS reloc against local symbol overflow #source: reloc-local-overflow.s -#ld: -Tdata 0x10000 -e 0 -#error: \A[^\n]*:\(\.data\+0x1000\): relocation truncated to fit: R_MIPS_16 against `\.data'\Z +#ld: -Tdata 0x10000000 -e 0 +#error: \A[^\n]*:\(\.text\+0x0\): relocation truncated to fit: R_MIPS_26 against `\.data'\Z # Verify that the section name (`.data') is printed rather than `no symbol'. diff --git a/ld/testsuite/ld-mips-elf/reloc-local-overflow.s b/ld/testsuite/ld-mips-elf/reloc-local-overflow.s index a07255c..6d50c7b 100644 --- a/ld/testsuite/ld-mips-elf/reloc-local-overflow.s +++ b/ld/testsuite/ld-mips-elf/reloc-local-overflow.s @@ -1,8 +1,5 @@ - .data - .space 0x1000 + .text + j init - .align 2 - .type bar, @object -bar: - .half bar - .size bar, . - bar + .data +init: |