diff options
| author | Maciej W. Rozycki <macro@mips.com> | 2018-06-20 00:37:51 +0100 |
|---|---|---|
| committer | Maciej W. Rozycki <macro@mips.com> | 2018-06-20 00:37:51 +0100 |
| commit | a4eb69274d3b220b6ec22d019a8994e136f9dce5 (patch) | |
| tree | 9297fb6a61c99b20ffaaea84f2b24562b285056d /ld | |
| parent | d0ac1c44885daf68f631befa37e3f3bad318fbbf (diff) | |
| download | gdb-a4eb69274d3b220b6ec22d019a8994e136f9dce5.zip gdb-a4eb69274d3b220b6ec22d019a8994e136f9dce5.tar.gz gdb-a4eb69274d3b220b6ec22d019a8994e136f9dce5.tar.bz2 | |
MIPS/LD/testsuite: XFAIL DT_TEXTREL map file warning test
Remove:
FAIL: DT_TEXTREL map file warning
introduced with commit 63c1f59d6655 ("readonly_dynrelocs"), coming from
the lack of a "dynamic relocation against `foo' in read-only section
`.rodata'" warning message produced.
The cause of the failure is that for sections which have dynamic
relocations attached the MIPS backend sets SHF_WRITE, in
`mips_elf_create_dynamic_relocation', yielding:
$ readelf -S textrel.so | grep rodata
[ 8] .rodata PROGBITS 00000254 000254 000004 00 WA 0 0 1
$
so the section is read/write and therefore there is nothing to warn
about.
This arrangement came from commit 7403cb6305f5 ("PATCH for N32 ABI"),
<https://sourceware.org/ml/binutils/1999-q2/msg00375.html>, i.e. for all
practical purposes it has been there since forever, and therefore it can
be considered a part of the ABI and the test case irrelevant for MIPS
targets.
We don't have a clean way to request UNSUPPORTED result, which would be
the most appropriate here, so just XFAIL the test instead.
ld/
* testsuite/ld-elf/shared.exp: XFAIL DT_TEXTREL map file warning
test for `mips*-*-*'.
Diffstat (limited to 'ld')
| -rw-r--r-- | ld/ChangeLog | 5 | ||||
| -rw-r--r-- | ld/testsuite/ld-elf/shared.exp | 7 |
2 files changed, 11 insertions, 1 deletions
diff --git a/ld/ChangeLog b/ld/ChangeLog index 7aa3b2e..495eeef 100644 --- a/ld/ChangeLog +++ b/ld/ChangeLog @@ -1,3 +1,8 @@ +2018-06-19 Maciej W. Rozycki <macro@mips.com> + + * testsuite/ld-elf/shared.exp: XFAIL DT_TEXTREL map file warning + test for `mips*-*-*'. + 2018-06-19 Simon Marchi <simon.marchi@ericsson.com> * configure.ac: Remove AC_PREREQ. diff --git a/ld/testsuite/ld-elf/shared.exp b/ld/testsuite/ld-elf/shared.exp index 8ec73ef..daac3be 100644 --- a/ld/testsuite/ld-elf/shared.exp +++ b/ld/testsuite/ld-elf/shared.exp @@ -176,6 +176,11 @@ run_ld_link_tests [list \ ] \ ] "xtensa-*-*" +# The MIPS backend sets SHF_WRITE, in `mips_elf_create_dynamic_relocation', +# for any section that has a dynamic relocation attached and consequently +# this test is irrelevant for MIPS targets. We don't have a clean way to +# request UNSUPPORTED result, which would be the most appropriate here, +# so we just XFAIL the test instead. run_ld_link_tests [list \ [list \ "DT_TEXTREL map file warning" \ @@ -186,7 +191,7 @@ run_ld_link_tests [list \ {{ld textrel.map}} \ "textrel.so" \ ] \ -] "cris*-*-*" +] "cris*-*-*" "mips*-*-*" # PR ld/20828 check for correct dynamic symbol table entries where: # - symbols have been defined with a linker script, |