diff options
| author | Alan Modra <amodra@gmail.com> | 2020-06-19 09:17:20 +0930 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2020-06-19 09:50:20 +0930 |
| commit | 5fd104addfddb68844fb8df67be832ee98ad9888 (patch) | |
| tree | c8a0805ad47e7cdce9e7a8d3aff24eb4a158d335 /ld/testsuite/lib | |
| parent | 753d1583f7e61ae4b6a016accaa65ab2ea776e41 (diff) | |
| download | gdb-5fd104addfddb68844fb8df67be832ee98ad9888.zip gdb-5fd104addfddb68844fb8df67be832ee98ad9888.tar.gz gdb-5fd104addfddb68844fb8df67be832ee98ad9888.tar.bz2 | |
Emit a warning when -z relro is unsupported
ld silently accepts -z relro and -z norelro for targets that lack the
necessary GNU_RELRO support. This patch makes those targets emit a
warning instead, and adds testsuite infrastructure to detect when
relro is unsupported.
binutils/
* testsuite/config/default.exp (ld_elf_shared_opt): Don't set.
* testsuite/lib/binutils-common.exp (check_relro_support): New proc.
(run_dump_test): Use check_relro_support to decide whether to pass
extra ld option "-z norelro".
ld/
* emultempl/elf.em (gld${EMULATION_NAME}_handle_option): Omit
-z relro and -z norelro when target support for GNU_RELRO is lacking.
(gld${EMULATION_NAME}_before_parse): Ignore RELRO default too.
* emultempl/aarch64elf.em (gld${EMULATION_NAME}_before_parse): Ignore
RELRO default when target support for GNU_RELRO is lacking.
* emultempl/armelf.em (gld${EMULATION_NAME}_before_parse): Likewise.
* emultempl/linux.em (gld${EMULATION_NAME}_before_parse): Likewise.
* emultempl/scoreelf.em (gld${EMULATION_NAME}_before_parse): Likewise.
* testsuite/config/default.exp (ld_elf_shared_opt): Don't set.
* testsuite/ld-elf/pr16322.d: xfail when no relro support.
* testsuite/ld-elf/pr22393-1a.d: Likewise.
* testsuite/ld-elf/pr22393-1b.d: Likewise.
* testsuite/ld-elf/shared.exp (pr20995-2.so, pr20995-2): Likewise.
* testsuite/lib/ld-lib.exp (run_ld_link_tests): Use check_relro_support
to decide whether to pass extra ld option "-z norelro".
Diffstat (limited to 'ld/testsuite/lib')
| -rw-r--r-- | ld/testsuite/lib/ld-lib.exp | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/ld/testsuite/lib/ld-lib.exp b/ld/testsuite/lib/ld-lib.exp index a949437..0a256c2 100644 --- a/ld/testsuite/lib/ld-lib.exp +++ b/ld/testsuite/lib/ld-lib.exp @@ -463,12 +463,10 @@ proc run_ld_link_tests { ldtests args } { global CFLAGS global runtests global exec_output - global ld_elf_shared_opt - if { [is_elf_format] && [check_shared_lib_support] } { - set ld_extra_opt "$ld_elf_shared_opt" - } else { - set ld_extra_opt "" + set ld_extra_opt "" + if [check_relro_support] { + set ld_extra_opt "-z norelro" } foreach testitem $ldtests { |