diff options
| author | H.J. Lu <hjl.tools@gmail.com> | 2015-08-13 04:31:38 -0700 |
|---|---|---|
| committer | H.J. Lu <hjl.tools@gmail.com> | 2015-08-13 04:31:38 -0700 |
| commit | 8efa2874ab298f3923f4127340da119435f87c39 (patch) | |
| tree | 09065381bc362db4d84940bfcc95cec64cc3fe42 /ld/testsuite/ld-i386 | |
| parent | 4ab90a7a90ccf8a671f139c1c6387ba8028e6011 (diff) | |
| download | gdb-8efa2874ab298f3923f4127340da119435f87c39.zip gdb-8efa2874ab298f3923f4127340da119435f87c39.tar.gz gdb-8efa2874ab298f3923f4127340da119435f87c39.tar.bz2 | |
Issue an error for read-only segment with dynamic IFUNC relocations
To load an ELF binary with DT_TEXTREL tag, the dynamic linker calls
__mprotect on the read-only segment with PROT_READ|PROT_WRITE before
applying dynamic relocation. It leads to segfault when performing
IFUNC relocations since the read-only segment has no execute permission.
This patch changes x86 linker to issue an error for read-only segment
with dynamic IFUNC relocations. Other backends with IFUNC support
may need a similar change.
bfd/
PR ld/18801
* elf32-i386.c (elf_i386_size_dynamic_sections): Issue an error
for read-only segment with dynamic IFUNC relocations.
* elf64-x86-64.c (elf_x86_64_size_dynamic_sections): Likewise.
ld/testsuite/
PR ld/18801
* ld-i386/i386.exp: Run pr18801.
* ld-x86-64/x86-64.exp: Likewise.
* ld-i386/pr18801.d: New file.
* ld-i386/pr18801.s: Likewise.
* ld-x86-64/pr18801.d: Likewise.
* ld-x86-64/pr18801.s: Likewise.
Diffstat (limited to 'ld/testsuite/ld-i386')
| -rw-r--r-- | ld/testsuite/ld-i386/i386.exp | 1 | ||||
| -rw-r--r-- | ld/testsuite/ld-i386/pr18801.d | 3 | ||||
| -rw-r--r-- | ld/testsuite/ld-i386/pr18801.s | 15 |
3 files changed, 19 insertions, 0 deletions
diff --git a/ld/testsuite/ld-i386/i386.exp b/ld/testsuite/ld-i386/i386.exp index 0a718cf..47911a6 100644 --- a/ld/testsuite/ld-i386/i386.exp +++ b/ld/testsuite/ld-i386/i386.exp @@ -309,6 +309,7 @@ run_dump_test "pr14215" run_dump_test "pr17057" run_dump_test "pr17935-1" run_dump_test "pr17935-2" +run_dump_test "pr18801" run_dump_test "pr18815" # Add $PLT_CFLAGS if PLT is expected. diff --git a/ld/testsuite/ld-i386/pr18801.d b/ld/testsuite/ld-i386/pr18801.d new file mode 100644 index 0000000..4bb2efb --- /dev/null +++ b/ld/testsuite/ld-i386/pr18801.d @@ -0,0 +1,3 @@ +#as: --32 +#ld: -m elf_i386 -pie +#error: read-only segment has dynamic IFUNC relocations; recompile with -fPIC diff --git a/ld/testsuite/ld-i386/pr18801.s b/ld/testsuite/ld-i386/pr18801.s new file mode 100644 index 0000000..ac3377d --- /dev/null +++ b/ld/testsuite/ld-i386/pr18801.s @@ -0,0 +1,15 @@ + .text + .type selector, %function +foo: + movl $0, %eax + ret +selector: + mov $foo, %eax + ret + .type selector, %gnu_indirect_function + .globl _start +_start: + mov $selector, %eax + call *%eax + ret + .section .note.GNU-stack,"",@progbits |