diff options
| author | H.J. Lu <hjl.tools@gmail.com> | 2016-04-11 19:41:37 -0700 |
|---|---|---|
| committer | H.J. Lu <hjl.tools@gmail.com> | 2016-04-11 19:41:52 -0700 |
| commit | 2df3368d851b653880c2e3312c99eb8adf89f3db (patch) | |
| tree | edbac9980b980c6c5bc58b15de92312e73d2f2d4 /ld/testsuite/ld-i386 | |
| parent | b545ef977bd39f4351172ab73f5d7cc2508944ec (diff) | |
| download | gdb-2df3368d851b653880c2e3312c99eb8adf89f3db.zip gdb-2df3368d851b653880c2e3312c99eb8adf89f3db.tar.gz gdb-2df3368d851b653880c2e3312c99eb8adf89f3db.tar.bz2 | |
Properly handle dynamic reloc against normal symbol
We shouldn't issue an error for read-only segment with dynamic IFUNC
relocations when dynamic relocations are against normal symbols.
bfd/
PR ld/19939
* elf-bfd.h (_bfd_elf_allocate_ifunc_dyn_relocs): Add a pointer
to bfd_boolean.
* elf-ifunc.c (_bfd_elf_allocate_ifunc_dyn_relocs): Updated.
Set *readonly_dynrelocs_against_ifunc_p to TRUE if dynamic reloc
applies to read-only section.
* elf32-i386.c (elf_i386_link_hash_table): Add
readonly_dynrelocs_against_ifunc.
(elf_i386_allocate_dynrelocs): Updated.
(elf_i386_size_dynamic_sections): Issue an error for read-only
segment with dynamic IFUNC relocations only if
readonly_dynrelocs_against_ifunc is TRUE.
* elf64-x86-64.c (elf_x86_64_link_hash_table): Add
readonly_dynrelocs_against_ifunc.
(elf_x86_64_allocate_dynrelocs): Updated.
(elf_x86_64_size_dynamic_sections): Issue an error for read-only
segment with dynamic IFUNC relocations only if
readonly_dynrelocs_against_ifunc is TRUE.
* elfnn-aarch64.c (elfNN_aarch64_allocate_ifunc_dynrelocs):
Updated.
ld/
PR ld/19939
* testsuite/ld-i386/i386.exp: Run PR ld/19939 tests.
* testsuite/ld-x86-64/x86-64.exp: Likewise.
* testsuite/ld-i386/pr19939.s: New file.
* testsuite/ld-i386/pr19939a.d: Likewise.
* testsuite/ld-i386/pr19939b.d: Likewise.
* testsuite/ld-x86-64/pr19939.s: Likewise.
* testsuite/ld-x86-64/pr19939a.d: Likewise.
* testsuite/ld-x86-64/pr19939b.d: Likewise.
Diffstat (limited to 'ld/testsuite/ld-i386')
| -rw-r--r-- | ld/testsuite/ld-i386/i386.exp | 2 | ||||
| -rw-r--r-- | ld/testsuite/ld-i386/pr19939.s | 9 | ||||
| -rw-r--r-- | ld/testsuite/ld-i386/pr19939a.d | 4 | ||||
| -rw-r--r-- | ld/testsuite/ld-i386/pr19939b.d | 8 |
4 files changed, 23 insertions, 0 deletions
diff --git a/ld/testsuite/ld-i386/i386.exp b/ld/testsuite/ld-i386/i386.exp index 2b7a09e..c6708ca 100644 --- a/ld/testsuite/ld-i386/i386.exp +++ b/ld/testsuite/ld-i386/i386.exp @@ -390,6 +390,8 @@ run_dump_test "pr17935-1" run_dump_test "pr17935-2" run_dump_test "pr18801" run_dump_test "pr18815" +run_dump_test "pr19939a" +run_dump_test "pr19939b" proc undefined_weak {cflags ldflags} { set testname "Undefined weak symbol" diff --git a/ld/testsuite/ld-i386/pr19939.s b/ld/testsuite/ld-i386/pr19939.s new file mode 100644 index 0000000..fdd1c04 --- /dev/null +++ b/ld/testsuite/ld-i386/pr19939.s @@ -0,0 +1,9 @@ + .text +selector: + movl foo@GOT(%eax), %eax + mov $bar, %ebx + ret + .type selector, %gnu_indirect_function + .globl bar +bar: + jmp selector@PLT diff --git a/ld/testsuite/ld-i386/pr19939a.d b/ld/testsuite/ld-i386/pr19939a.d new file mode 100644 index 0000000..5883cae --- /dev/null +++ b/ld/testsuite/ld-i386/pr19939a.d @@ -0,0 +1,4 @@ +#source: pr19939.s +#as: --32 +#ld: -melf_i386 -shared -z defs +#error: undefined reference to `foo' diff --git a/ld/testsuite/ld-i386/pr19939b.d b/ld/testsuite/ld-i386/pr19939b.d new file mode 100644 index 0000000..5124ae1 --- /dev/null +++ b/ld/testsuite/ld-i386/pr19939b.d @@ -0,0 +1,8 @@ +#source: pr19939.s +#as: --32 +#ld: -melf_i386 -shared +#readelf: -d --wide + +#... +.*\(TEXTREL\).* +#pass |