diff options
author | H.J. Lu <hjl.tools@gmail.com> | 2018-08-31 09:25:31 -0700 |
---|---|---|
committer | H.J. Lu <hjl.tools@gmail.com> | 2018-08-31 09:26:09 -0700 |
commit | 4d1c6335455aeeda9de8a5eb58998f919ea35a1e (patch) | |
tree | c267d4cc0dfd79f90620e21a379150721837ff6c /ld/ldlang.c | |
parent | dab999b116b507ad431c70fab0a28074dfea29df (diff) | |
download | gdb-4d1c6335455aeeda9de8a5eb58998f919ea35a1e.zip gdb-4d1c6335455aeeda9de8a5eb58998f919ea35a1e.tar.gz gdb-4d1c6335455aeeda9de8a5eb58998f919ea35a1e.tar.bz2 |
ld: Lookup section in output with the same name
When there are more than one input sections with the same section name,
SECNAME, linker picks the first one to define __start_SECNAME and
__stop_SECNAME symbols. When the first input section is removed by
comdat group, we need to check if there is still an output section
with section name SECNAME.
PR ld/23591
* ldlang.c (undef_start_stop): Lookup section in output with
the same name.
* testsuite/ld-elf/pr23591.d: New file.
* testsuite/ld-elf/pr23591a.s: Likewise.
* testsuite/ld-elf/pr23591b.s: Likewise.
* testsuite/ld-elf/pr23591c.s: Likewise.
Diffstat (limited to 'ld/ldlang.c')
-rw-r--r-- | ld/ldlang.c | 18 |
1 files changed, 18 insertions, 0 deletions
diff --git a/ld/ldlang.c b/ld/ldlang.c index 8878ccd..d644b56 100644 --- a/ld/ldlang.c +++ b/ld/ldlang.c @@ -6097,6 +6097,24 @@ undef_start_stop (struct bfd_link_hash_entry *h) || strcmp (h->u.def.section->name, h->u.def.section->output_section->name) != 0) { + asection *sec = bfd_get_section_by_name (link_info.output_bfd, + h->u.def.section->name); + if (sec != NULL) + { + /* When there are more than one input sections with the same + section name, SECNAME, linker picks the first one to define + __start_SECNAME and __stop_SECNAME symbols. When the first + input section is removed by comdat group, we need to check + if there is still an output section with section name + SECNAME. */ + asection *i; + for (i = sec->map_head.s; i != NULL; i = i->map_head.s) + if (strcmp (h->u.def.section->name, i->name) == 0) + { + h->u.def.section = i; + return; + } + } h->type = bfd_link_hash_undefined; h->u.undef.abfd = NULL; } |