aboutsummaryrefslogtreecommitdiff
path: root/ld/deffilep.y
diff options
context:
space:
mode:
authorPedro Alves <palves@redhat.com>2013-07-04 16:08:22 +0000
committerPedro Alves <palves@redhat.com>2013-07-04 16:08:22 +0000
commit58722cac5aa9ea0b18a8fe5e76031f62cea017bc (patch)
tree57613c08aa66afd137cc72da3c52b1e1b98c4317 /ld/deffilep.y
parent691a26f5ddd5f061ae8cd1be7c68212041da6ac2 (diff)
downloadgdb-58722cac5aa9ea0b18a8fe5e76031f62cea017bc.zip
gdb-58722cac5aa9ea0b18a8fe5e76031f62cea017bc.tar.gz
gdb-58722cac5aa9ea0b18a8fe5e76031f62cea017bc.tar.bz2
value_bits_valid: Fix latent bug.
Doing something else, I factored out the bits of the value_bits_valid function that actually handle the check_validity hook, and surprisingly found out that the result was misbehaving. Turns out value_bits_valid has a latent bug. If the value is not lval_computed, or doesn't have a check_validity hook, then we should assume the value is entirely valid, not invalid. This is currently masked by the value->optimized_out check -- I ran the testsuite with a gdb_assert(0) inserted in place of that return being touched by the patch, and it never triggers. Tested on x86_64 Fedora 17. gdb/ 2013-07-04 Pedro Alves <palves@redhat.com> * value.c (value_bits_valid): If the value is not lval_computed, or doesn't have a check_validity hook, assume the value is entirely valid.
Diffstat (limited to 'ld/deffilep.y')
0 files changed, 0 insertions, 0 deletions