aboutsummaryrefslogtreecommitdiff
path: root/ld/Makefile.in
diff options
context:
space:
mode:
authorJoel Brobecker <brobecker@adacore.com>2013-11-27 17:42:24 +0400
committerJoel Brobecker <brobecker@adacore.com>2013-12-13 09:55:24 +0100
commit8a48ac9579f34efea9bc4f2d5b02230e2ac3dfc1 (patch)
tree45accfbd397324a64c302499d1f743419ee8091f /ld/Makefile.in
parentfb5e3d5c693cf9d56188a0ebd7ead5eba99bfdb4 (diff)
downloadgdb-8a48ac9579f34efea9bc4f2d5b02230e2ac3dfc1.zip
gdb-8a48ac9579f34efea9bc4f2d5b02230e2ac3dfc1.tar.gz
gdb-8a48ac9579f34efea9bc4f2d5b02230e2ac3dfc1.tar.bz2
wrong dimension found in ada-lang.c:ada_array_bound_from_type
This function has the following code: elt_type = type; for (i = n; i > 1; i--) elt_type = TYPE_TARGET_TYPE (type); For multi-dimension arrays, the code above tries to find the array type corresponding to the dimension we're trying to inspect. The problem is that, past the second dimension, the loop does nothing other than repeat the first iteration. There is a little thinko where it got the TYPE_TARGET_TYPE of TYPE instead of ELT_TYPE! To my surprise, I was unable to produce an Ada exemple that demonstrated the problem. That's because the examples I created all trigger a parallel ___XA type which we then use in place of the ELT_TYPE in order to determine the bounds - see the code that immediately follows our loop above: index_type_desc = ada_find_parallel_type (type, "___XA"); ada_fixup_array_indexes_type (index_type_desc); if (index_type_desc != NULL) [...] So, in order to avoid depending on an Ada example where the compiler can potentially decide one way or the other, I decided to use an artificial example, written in C. With ... int multi[1][2][3]; ... forcing the language to Ada, and trying to print the 'last, we get: (gdb) p multi'last(1) $1 = 0 (gdb) p multi'last(2) $2 = 1 (gdb) p multi'last(3) $3 = 1 <<<--- This should be 2! Additionally, I noticed that a couple of check_typedef's were missing. This patch adds them. And since the variable in question only gets used within an "else" block, I moved the variable declaration and use inside that block - making it clear what the scope of the variable is. gdb/ChangeLog: * ada-lang.c (ada_array_bound_from_type): Move the declaration and assignment of variable "elt_type" inside the else block where it is used. Add two missing check_typedef calls. Fix bug where we got TYPE's TYPE_TARGET_TYPE, where in fact we really wanted to get ELT_TYPE's TYPE_TARGET_TYPE. gdb/testsuite/ChangeLog: * gdb.ada/arraydim: New testcase.
Diffstat (limited to 'ld/Makefile.in')
0 files changed, 0 insertions, 0 deletions