diff options
| author | Alan Modra <amodra@gmail.com> | 2018-04-27 09:42:11 +0930 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2018-05-04 18:58:23 +0930 |
| commit | 602f16570454a1597c2af28af66852133432d1f2 (patch) | |
| tree | ad3d519fce4dcf5bdf38e46fac6b0ee090784f53 /include | |
| parent | a27ca19c95ad3ebc5bd73f072facdd71b5a976ad (diff) | |
| download | gdb-602f16570454a1597c2af28af66852133432d1f2.zip gdb-602f16570454a1597c2af28af66852133432d1f2.tar.gz gdb-602f16570454a1597c2af28af66852133432d1f2.tar.bz2 | |
-Wstringop-truncation warnings
This patch is aimed at silencing gcc8 -Wstringop-truncation warnings.
Unfortunately adding __attribute__ ((__nonstring)) doesn't work in a
number of the places patched here, (see
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85643) so if you have
recent glibc headers installed you'll need to configure binutils with
--disable-werror to compile using gcc8 or gcc9.
include/
* ansidecl.h: Import from gcc.
* coff/internal.h (struct internal_scnhdr): Add ATTRIBUTE_NONSTRING
to s_name.
(struct internal_syment): Add ATTRIBUTE_NONSTRING to _n_name.
bfd/
* elf-linux-core.h (struct elf_external_linux_prpsinfo32_ugid32),
(struct elf_external_linux_prpsinfo32_ugid16),
(struct elf_external_linux_prpsinfo64_ugid32),
(struct elf_external_linux_prpsinfo64_ugid16): Add ATTRIBUTE_NONSTRING
to pr_fname and pr_psargs fields. Remove GCC diagnostic pragmas.
Move comment to..
* elf.c (elfcore_write_prpsinfo): ..here. Indent nested preprocessor
directives.
* elf32-arm.c (elf32_arm_nabi_write_core_note): Add ATTRIBUTE_NONSTRING
to data.
* elf32-ppc.c (ppc_elf_write_core_note): Likewise.
* elf32-s390.c (elf_s390_write_core_note): Likewise.
* elf64-s390.c (elf_s390_write_core_note): Likewise.
* elfxx-aarch64.c (_bfd_aarch64_elf_write_core_note): Likewise.
* elf64-x86-64.c (elf_x86_64_write_core_note): Add GCC diagnostic
pragmas.
* peXXigen.c (_bfd_XXi_swap_scnhdr_out): Use strnlen to avoid
false positive gcc-8 warning.
gas/
* config/obj-evax.c (shorten_identifier): Use memcpy in place
of strncpy.
* config/obj-macho.c (obj_mach_o_make_or_get_sect): Ensure
segname and sectname fields are NUL terminated.
Diffstat (limited to 'include')
| -rw-r--r-- | include/ChangeLog | 7 | ||||
| -rw-r--r-- | include/ansidecl.h | 9 | ||||
| -rw-r--r-- | include/coff/internal.h | 4 |
3 files changed, 18 insertions, 2 deletions
diff --git a/include/ChangeLog b/include/ChangeLog index cf0b626..5c9913b 100644 --- a/include/ChangeLog +++ b/include/ChangeLog @@ -1,3 +1,10 @@ +2018-05-04 Alan Modra <amodra@gmail.com> + + * ansidecl.h: Import from gcc. + * coff/internal.h (struct internal_scnhdr): Add ATTRIBUTE_NONSTRING + to s_name. + (struct internal_syment): Add ATTRIBUTE_NONSTRING to _n_name. + 2018-04-30 Francois H. Theron <francois.theron@netronome.com> * dis-asm.h: Added print_nfp_disassembler_options prototype. diff --git a/include/ansidecl.h b/include/ansidecl.h index c11daff..406473c 100644 --- a/include/ansidecl.h +++ b/include/ansidecl.h @@ -283,6 +283,15 @@ So instead we use the macro below and test it against specific values. */ # endif /* GNUC >= 4.9 */ #endif /* ATTRIBUTE_NO_SANITIZE_UNDEFINED */ +/* Attribute 'nonstring' was valid as of gcc 8. */ +#ifndef ATTRIBUTE_NONSTRING +# if GCC_VERSION >= 8000 +# define ATTRIBUTE_NONSTRING __attribute__ ((__nonstring__)) +# else +# define ATTRIBUTE_NONSTRING +# endif +#endif + /* We use __extension__ in some places to suppress -pedantic warnings about GCC extensions. This feature didn't work properly before gcc 2.8. */ diff --git a/include/coff/internal.h b/include/coff/internal.h index 1879ddc..a8efedb 100644 --- a/include/coff/internal.h +++ b/include/coff/internal.h @@ -393,7 +393,7 @@ struct internal_aouthdr struct internal_scnhdr { - char s_name[SCNNMLEN]; /* section name */ + char s_name[SCNNMLEN] ATTRIBUTE_NONSTRING; /* section name */ /* Physical address, aliased s_nlib. In the pei format, this field is the virtual section size @@ -466,7 +466,7 @@ struct internal_syment { union { - char _n_name[SYMNMLEN]; /* old COFF version */ + char _n_name[SYMNMLEN] ATTRIBUTE_NONSTRING; /* old COFF version */ struct { bfd_hostptr_t _n_zeroes; /* new == 0 */ |