diff options
| author | H.J. Lu <hjl.tools@gmail.com> | 2015-10-22 04:56:10 -0700 |
|---|---|---|
| committer | H.J. Lu <hjl.tools@gmail.com> | 2015-10-22 04:56:57 -0700 |
| commit | 2891b491040ac84dfe0013454b2aa834de7b539c (patch) | |
| tree | 623066a0eabe1405028b7462c884492a4ee71efc /gold | |
| parent | 493d4b48decc2b3c5fe9d2df68bcee67fdd8b7cb (diff) | |
| download | gdb-2891b491040ac84dfe0013454b2aa834de7b539c.zip gdb-2891b491040ac84dfe0013454b2aa834de7b539c.tar.gz gdb-2891b491040ac84dfe0013454b2aa834de7b539c.tar.bz2 | |
Gold: Don't fail on R_X86_64_[REX_]GOTPCRELX relocations
This patch updates gold to treat the R_X86_64_GOTPCRELX and
R_X86_64_REX_GOTPCRELX relocations proposed in
https://groups.google.com/forum/#!topic/x86-64-abi/n9AWHogmVY0
the same as R_X86_64_GOTPCREL. FIXME: Gold should perform the
transformations as suggested.
elfcpp/
* x86_64.h (R_X86_64_GOTPCRELX): New.
(R_X86_64_REX_GOTPCRELX): Likewise.
gold/
* x86_64.cc (Target_x86_64<size>::Scan::get_reference_flags):
Treat R_X86_64_GOTPCRELX and R_X86_64_REX_GOTPCRELX the same
as R_X86_64_GOTPCREL.
(Target_x86_64<size>::Scan::local): Likewise.
(Target_x86_64<size>::Scan::possible_function_pointer_reloc):
Likewise.
(Target_x86_64<size>::Scan::global): Likewise.
(Target_x86_64<size>::Relocate::relocate): Likewise.
(Target_x86_64<size>::Relocatable_size_for_reloc::get_size_for_reloc):
Likewise.
Diffstat (limited to 'gold')
| -rw-r--r-- | gold/ChangeLog | 13 | ||||
| -rw-r--r-- | gold/x86_64.cc | 20 |
2 files changed, 31 insertions, 2 deletions
diff --git a/gold/ChangeLog b/gold/ChangeLog index c0af029..46a0636 100644 --- a/gold/ChangeLog +++ b/gold/ChangeLog @@ -1,5 +1,18 @@ 2015-10-22 H.J. Lu <hongjiu.lu@intel.com> + * x86_64.cc (Target_x86_64<size>::Scan::get_reference_flags): + Treat R_X86_64_GOTPCRELX and R_X86_64_REX_GOTPCRELX the same + as R_X86_64_GOTPCREL. + (Target_x86_64<size>::Scan::local): Likewise. + (Target_x86_64<size>::Scan::possible_function_pointer_reloc): + Likewise. + (Target_x86_64<size>::Scan::global): Likewise. + (Target_x86_64<size>::Relocate::relocate): Likewise. + (Target_x86_64<size>::Relocatable_size_for_reloc::get_size_for_reloc): + Likewise. + +2015-10-22 H.J. Lu <hongjiu.lu@intel.com> + * i386.cc (Target_i386::Scan::get_reference_flags(): Treat R_386_GOT32X the same as R_386_GOT32. (Target_i386::Scan::local): Likewise. diff --git a/gold/x86_64.cc b/gold/x86_64.cc index 007af1d..c728a00 100644 --- a/gold/x86_64.cc +++ b/gold/x86_64.cc @@ -2191,6 +2191,8 @@ Target_x86_64<size>::Scan::get_reference_flags(unsigned int r_type) case elfcpp::R_X86_64_GOT32: case elfcpp::R_X86_64_GOTPCREL64: case elfcpp::R_X86_64_GOTPCREL: + case elfcpp::R_X86_64_GOTPCRELX: + case elfcpp::R_X86_64_REX_GOTPCRELX: case elfcpp::R_X86_64_GOTPLT64: // Absolute in GOT. return Symbol::ABSOLUTE_REF; @@ -2475,6 +2477,8 @@ Target_x86_64<size>::Scan::local(Symbol_table* symtab, case elfcpp::R_X86_64_GOT32: case elfcpp::R_X86_64_GOTPCREL64: case elfcpp::R_X86_64_GOTPCREL: + case elfcpp::R_X86_64_GOTPCRELX: + case elfcpp::R_X86_64_REX_GOTPCRELX: case elfcpp::R_X86_64_GOTPLT64: { // The symbol requires a GOT section. @@ -2485,7 +2489,9 @@ Target_x86_64<size>::Scan::local(Symbol_table* symtab, // mov foo@GOTPCREL(%rip), %reg // to lea foo(%rip), %reg. // in Relocate::relocate. - if (r_type == elfcpp::R_X86_64_GOTPCREL + if ((r_type == elfcpp::R_X86_64_GOTPCREL + || r_type == elfcpp::R_X86_64_GOTPCRELX + || r_type == elfcpp::R_X86_64_REX_GOTPCRELX) && reloc.get_r_offset() >= 2 && !is_ifunc) { @@ -2713,6 +2719,8 @@ Target_x86_64<size>::Scan::possible_function_pointer_reloc(unsigned int r_type) case elfcpp::R_X86_64_GOT32: case elfcpp::R_X86_64_GOTPCREL64: case elfcpp::R_X86_64_GOTPCREL: + case elfcpp::R_X86_64_GOTPCRELX: + case elfcpp::R_X86_64_REX_GOTPCRELX: case elfcpp::R_X86_64_GOTPLT64: { return true; @@ -2901,6 +2909,8 @@ Target_x86_64<size>::Scan::global(Symbol_table* symtab, case elfcpp::R_X86_64_GOT32: case elfcpp::R_X86_64_GOTPCREL64: case elfcpp::R_X86_64_GOTPCREL: + case elfcpp::R_X86_64_GOTPCRELX: + case elfcpp::R_X86_64_REX_GOTPCRELX: case elfcpp::R_X86_64_GOTPLT64: { // The symbol requires a GOT entry. @@ -2910,7 +2920,9 @@ Target_x86_64<size>::Scan::global(Symbol_table* symtab, // mov foo@GOTPCREL(%rip), %reg // to lea foo(%rip), %reg. // in Relocate::relocate, then there is nothing to do here. - if (r_type == elfcpp::R_X86_64_GOTPCREL + if ((r_type == elfcpp::R_X86_64_GOTPCREL + || r_type == elfcpp::R_X86_64_GOTPCRELX + || r_type == elfcpp::R_X86_64_REX_GOTPCRELX) && reloc.get_r_offset() >= 2 && Target_x86_64<size>::can_convert_mov_to_lea(gsym)) { @@ -3538,6 +3550,8 @@ Target_x86_64<size>::Relocate::relocate( break; case elfcpp::R_X86_64_GOTPCREL: + case elfcpp::R_X86_64_GOTPCRELX: + case elfcpp::R_X86_64_REX_GOTPCRELX: { // Convert // mov foo@GOTPCREL(%rip), %reg @@ -4320,6 +4334,8 @@ Target_x86_64<size>::Relocatable_size_for_reloc::get_size_for_reloc( case elfcpp::R_X86_64_GOT64: case elfcpp::R_X86_64_GOTPCREL64: case elfcpp::R_X86_64_GOTPCREL: + case elfcpp::R_X86_64_GOTPCRELX: + case elfcpp::R_X86_64_REX_GOTPCRELX: case elfcpp::R_X86_64_GOTPLT64: return 8; |