diff options
| author | Cary Coutant <ccoutant@gmail.com> | 2015-06-11 13:19:38 -0700 |
|---|---|---|
| committer | Cary Coutant <ccoutant@gmail.com> | 2015-06-11 13:21:11 -0700 |
| commit | 5d7908e0880030628536a0266968a15922574735 (patch) | |
| tree | 164c158e8268ac8a66cfb08fec0edd64a26447f7 /gold | |
| parent | dd68f8fa8e2412c5c16380871d8ac5e40909aef6 (diff) | |
| download | gdb-5d7908e0880030628536a0266968a15922574735.zip gdb-5d7908e0880030628536a0266968a15922574735.tar.gz gdb-5d7908e0880030628536a0266968a15922574735.tar.bz2 | |
Fix gold build error at -O0.
In aarch64.cc, Erratum_stub::STUB_ADDR_ALIGN and Reloc_stub::STUB_ADDR_ALIGN
are declared as static const int, and initialized in the class body. These
values are referenced from outside the class body, and with no optimization,
the references go unresolved.
gold/
* aarch64.cc (Erratum_stub::STUB_ADDR_ALIGN): Move initialization
outside class body.
(Reloc_stub::STUB_ADDR_ALIGN): Likewise.
Diffstat (limited to 'gold')
| -rw-r--r-- | gold/ChangeLog | 6 | ||||
| -rw-r--r-- | gold/aarch64.cc | 8 |
2 files changed, 12 insertions, 2 deletions
diff --git a/gold/ChangeLog b/gold/ChangeLog index 4d6cd3d..7039dd2 100644 --- a/gold/ChangeLog +++ b/gold/ChangeLog @@ -1,5 +1,11 @@ 2015-06-11 Cary Coutant <ccoutant@gmail.com> + * aarch64.cc (Erratum_stub::STUB_ADDR_ALIGN): Move initialization + outside class body. + (Reloc_stub::STUB_ADDR_ALIGN): Likewise. + +2015-06-11 Cary Coutant <ccoutant@gmail.com> + PR gold/17731 * layout.cc (corresponding_uncompressed_section_name): New function. (Layout::choose_output_section): Call it. diff --git a/gold/aarch64.cc b/gold/aarch64.cc index 130fcc2..8dfd933 100644 --- a/gold/aarch64.cc +++ b/gold/aarch64.cc @@ -840,7 +840,7 @@ public: typedef typename elfcpp::Elf_types<size>::Elf_Addr AArch64_address; typedef typename AArch64_insn_utilities<big_endian>::Insntype Insntype; - static const int STUB_ADDR_ALIGN = 4; + static const int STUB_ADDR_ALIGN; static const Insntype invalid_insn = static_cast<Insntype>(-1); @@ -930,6 +930,8 @@ private: AArch64_address erratum_address_; }; // End of "Erratum_stub". +template<int size, bool big_endian> +const int Erratum_stub<size, big_endian>::STUB_ADDR_ALIGN = 4; // Comparator used in set definition. template<int size, bool big_endian> @@ -980,7 +982,7 @@ class Reloc_stub : public Stub_base<size, big_endian> static const int MIN_ADRP_IMM = -(1 << 20); static const int BYTES_PER_INSN = 4; - static const int STUB_ADDR_ALIGN = 4; + static const int STUB_ADDR_ALIGN; // Determine whether the offset fits in the jump/branch instruction. static bool @@ -1126,6 +1128,8 @@ class Reloc_stub : public Stub_base<size, big_endian> static const unsigned int invalid_index = static_cast<unsigned int>(-1); }; // End of Reloc_stub +template<int size, bool big_endian> +const int Reloc_stub<size, big_endian>::STUB_ADDR_ALIGN = 4; // Write data to output file. |