diff options
| author | Cary Coutant <ccoutant@gmail.com> | 2016-12-21 17:32:39 -0800 |
|---|---|---|
| committer | Cary Coutant <ccoutant@gmail.com> | 2016-12-22 16:00:06 -0800 |
| commit | 40d7d93ff412f4c34cde3daa04890d5cd2e0d9c9 (patch) | |
| tree | 0f063eb01c597b5b10b609e1caee825945c01acc /gold/testsuite/Makefile.am | |
| parent | ce0db13751aed2782c417bc4cf715313f9273e94 (diff) | |
| download | gdb-40d7d93ff412f4c34cde3daa04890d5cd2e0d9c9.zip gdb-40d7d93ff412f4c34cde3daa04890d5cd2e0d9c9.tar.gz gdb-40d7d93ff412f4c34cde3daa04890d5cd2e0d9c9.tar.bz2 | |
Fix problem where version script causes predefined hidden symbol to be defined twice.
When creating a predefined hidden symbol like _GLOBAL_OFFSET_TABLE_, gold
was incorrectly letting a version script add a version to the symbol,
resulting in two copies of the symbol, both STB_LOCAL, but one of which
was grouped in the globals part of the symbol table.
gold/
* symtab.cc (Symbol_table::define_special_symbol): Add is_forced_local
parameter; if set, do not check version script.
(Symbol_table::do_define_in_output_data): Pass is_forced_local for
STB_LOCAL predefined symbols.
(Symbol_table::do_define_in_output_segment): Likewise.
(Symbol_table::do_define_in_output_segment): Likewise.
(Symbol_table::do_define_as_constant): Likewise.
* symtab.h (Symbol_table::define_special_symbol): Add is_forced_local
parameter. Adjust all callers.
* testsuite/Makefile.am (ver_test_8.sh): New test case.
* testsuite/Makefile.in: Regenerate.
* ver_test_8.sh: New test script.
Diffstat (limited to 'gold/testsuite/Makefile.am')
| -rw-r--r-- | gold/testsuite/Makefile.am | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/gold/testsuite/Makefile.am b/gold/testsuite/Makefile.am index 7d91575..fbdc147 100644 --- a/gold/testsuite/Makefile.am +++ b/gold/testsuite/Makefile.am @@ -1739,6 +1739,11 @@ ver_test_8_1.so: two_file_test_1_pic.o two_file_test_1b_pic.o ver_test_8_2.so gc ver_test_8_2.so: two_file_test_2_pic.o $(srcdir)/ver_test_8.script gcctestdir/ld $(CXXLINK) -Bgcctestdir/ -shared -Wl,--version-script,$(srcdir)/ver_test_8.script two_file_test_2_pic.o +check_SCRIPTS += ver_test_8.sh +check_DATA += ver_test_8_2.so.syms +ver_test_8_2.so.syms: ver_test_8_2.so + $(TEST_READELF) -s $< >$@ 2>/dev/null + check_PROGRAMS += ver_test_9 ver_test_9_SOURCES = ver_test_main.cc ver_test_9_DEPENDENCIES = gcctestdir/ld ver_test_9.so |