diff options
author | Cary Coutant <ccoutant@gmail.com> | 2016-05-19 14:58:18 -0700 |
---|---|---|
committer | Cary Coutant <ccoutant@gmail.com> | 2016-05-19 15:05:03 -0700 |
commit | 6eeb0170bbb43ffb73e8f01b8b481adde8194c21 (patch) | |
tree | d01fc9c0add92397bb2af0b2bb308b2cb3d7ab57 /gold/symtab.h | |
parent | 15eb1bebe1525ba8baf1f56e9df791cff146a352 (diff) | |
download | gdb-6eeb0170bbb43ffb73e8f01b8b481adde8194c21.zip gdb-6eeb0170bbb43ffb73e8f01b8b481adde8194c21.tar.gz gdb-6eeb0170bbb43ffb73e8f01b8b481adde8194c21.tar.bz2 |
Don't allow COPY relocations for protected symbols.
gold/
PR gold/19823
* copy-relocs.cc (Copy_relocs::make_copy_reloc): Add object
parameter; check for protected symbol.
* copy-relocs.h (Copy_relocs::make_copy_reloc): Add object parameter.
* mips.cc (Mips_copy_relocs): Adjust call to make_copy_reloc.
* symtab.cc (Symbol::init_fields): Initialize is_protected_.
(Symbol_table::add_from_dynobj): Mark protected symbols.
* symtab.h (Symbol::is_protected): New method.
(Symbol::set_is_protected): New method.
(Symbol::is_protected_): New data member.
* testsuite/Makefile.am (copy_test_protected): New test.
* testsuite/Makefile.in: Regenerate.
* testsuite/copy_test.cc (main): Add legal reference to protected
symbol.
* testsuite/copy_test_v1.cc (main): Likewise.
* testsuite/copy_test_2.cc (ip): Add protected symbol.
* testsuite/copy_test_protected.cc: New test source file.
* testsuite/copy_test_protected.sh: New test script.
Diffstat (limited to 'gold/symtab.h')
-rw-r--r-- | gold/symtab.h | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/gold/symtab.h b/gold/symtab.h index 5cee458..b26b4e0 100644 --- a/gold/symtab.h +++ b/gold/symtab.h @@ -870,6 +870,19 @@ class Symbol is_cxx_vtable() const { return is_prefix_of("_ZTV", this->name_); } + // Return true if this symbol is protected in a shared object. + // This is not the same as checking if visibility() == elfcpp::STV_PROTECTED, + // because the visibility_ field reflects the symbol's visibility from + // outside the shared object. + bool + is_protected() const + { return this->is_protected_; } + + // Mark this symbol as protected in a shared object. + void + set_is_protected() + { this->is_protected_ = true; } + protected: // Instances of this class should always be created at a specific // size. @@ -1067,6 +1080,10 @@ class Symbol bool undef_binding_weak_ : 1; // True if this symbol is a predefined linker symbol (bit 34). bool is_predefined_ : 1; + // True if this symbol has protected visibility in a shared object (bit 35). + // The visibility_ field will be STV_DEFAULT in this case because we + // must treat it as such from outside the shared object. + bool is_protected_ : 1; }; // The parts of a symbol which are size specific. Using a template |