diff options
| author | Benjamin Peterson <bp@benjamin.pe> | 2017-12-01 12:59:36 -0800 |
|---|---|---|
| committer | Cary Coutant <ccoutant@gmail.com> | 2017-12-01 12:59:36 -0800 |
| commit | bd2e3511f74940beec6a39914480ed6ff88c0a71 (patch) | |
| tree | 4fd2c80329f90e8957276529424e4cd5fe634981 /gold/gold.cc | |
| parent | 71739b698d47945463f183619078ff680c277f0f (diff) | |
| download | gdb-bd2e3511f74940beec6a39914480ed6ff88c0a71.zip gdb-bd2e3511f74940beec6a39914480ed6ff88c0a71.tar.gz gdb-bd2e3511f74940beec6a39914480ed6ff88c0a71.tar.bz2 | |
Fix internal error from command line with unbalanced --start-lib/--end-lib.
The problem is that while the command line isn't trivially empty,
it contains no input files. As gold tries to configure the number
of threads to use based on the number of input files, this causes
the assertion failure above. Fix this problem by making the logic
in gold.cc more robust and also adding a better error message
about --start-lib to options.cc.
gold/
PR gold/22406
* gold.cc (queue_initial_tasks) Check for number of real input files.
* options.cc (Command_line::process) Check for unterminated --start-lib
options.
* testsuite/Makefile.am: Add new test script.
* testsuite/Makefile.in: Regenerate.
* testsuite/check_empty_command_lines.sh: New test script.
Diffstat (limited to 'gold/gold.cc')
| -rw-r--r-- | gold/gold.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gold/gold.cc b/gold/gold.cc index a76d155..3916f89 100644 --- a/gold/gold.cc +++ b/gold/gold.cc @@ -175,7 +175,7 @@ queue_initial_tasks(const General_options& options, Workqueue* workqueue, Input_objects* input_objects, Symbol_table* symtab, Layout* layout, Mapfile* mapfile) { - if (cmdline.begin() == cmdline.end()) + if (cmdline.number_of_input_files() == 0) { bool is_ok = false; if (options.printed_version()) |