diff options
| author | Cary Coutant <ccoutant@gmail.com> | 2018-06-21 13:51:16 -0700 |
|---|---|---|
| committer | Cary Coutant <ccoutant@gmail.com> | 2018-06-21 13:54:16 -0700 |
| commit | cea6ffbd06a6ebb5c21cb51e7775b8ebb5e34f38 (patch) | |
| tree | a051cfe643463bc74fd4c9cdd75db0d0c9137a53 /gold/ChangeLog | |
| parent | 1ced1a5f108fd0a0c88d2298dbdd2dd2a2ee38f0 (diff) | |
| download | gdb-cea6ffbd06a6ebb5c21cb51e7775b8ebb5e34f38.zip gdb-cea6ffbd06a6ebb5c21cb51e7775b8ebb5e34f38.tar.gz gdb-cea6ffbd06a6ebb5c21cb51e7775b8ebb5e34f38.tar.bz2 | |
Fix treatment of symbol versions with unused as-needed libraries.
When we have a weak reference to a symbol defined in an
as-needed library, and that library ends up not-needed, gold
simply clears the version information in the symbol table, even
if the symbol could have been resolved by a needed library later
in the link order. This results in a loss of version information,
which can cause the program to bind to the wrong version at run
time.
This patch lets a dynamic definition override an earlier one if
the earlier one is from a not-needed library, so that we can
retain the version information from the binding to the needed
library. In order to do that, the tracking of needed/not-needed
had to be moved up to symbol resolution time, instead of during
Symbol_table::set_dynsym_indexes().
In cases where we still end up discarding version information,
I've added a warning.
For the original problem report and discussion, see:
https://stackoverflow.com/questions/50751421/undefined-behavior-in-shared-lib-using-libpthread-but-not-having-it-in-elf-as-d
gold/
* resolve.cc (Symbol_table::resolve): Rename tobinding to
orig_tobinding. Call set_is_needed() for objects that resolve
non-weak references.
(Symbol_table::should_override): Allow a dynamic definition to
override an earlier one in a not-needed library.
* symtab.cc (Symbol_table::set_dynsym_indexes): Remove separate
processing for as-needed symbols. Add warning when discarding
version informatin.
* testsuite/Makefile.am (weak_as_needed): New test case.
* testsuite/Makefile.in: Regenerate.
* testsuite/weak_as_needed.sh: New test script.
* testsuite/weak_as_needed_a.c: New source file.
* testsuite/weak_as_needed_b.c: New source file.
* testsuite/weak_as_needed_b.script: New version script.
* testsuite/weak_as_needed_c.c: New source file.
* testsuite/weak_as_needed_c.script: New version script.
Diffstat (limited to 'gold/ChangeLog')
| -rw-r--r-- | gold/ChangeLog | 19 |
1 files changed, 19 insertions, 0 deletions
diff --git a/gold/ChangeLog b/gold/ChangeLog index 626bcdb..9297e6d 100644 --- a/gold/ChangeLog +++ b/gold/ChangeLog @@ -1,3 +1,22 @@ +2018-06-21 Cary Coutant <ccoutant@gmail.com> + + * resolve.cc (Symbol_table::resolve): Rename tobinding to + orig_tobinding. Call set_is_needed() for objects that resolve + non-weak references. + (Symbol_table::should_override): Allow a dynamic definition to + override an earlier one in a not-needed library. + * symtab.cc (Symbol_table::set_dynsym_indexes): Remove separate + processing for as-needed symbols. Add warning when discarding + version informatin. + * testsuite/Makefile.am (weak_as_needed): New test case. + * testsuite/Makefile.in: Regenerate. + * testsuite/weak_as_needed.sh: New test script. + * testsuite/weak_as_needed_a.c: New source file. + * testsuite/weak_as_needed_b.c: New source file. + * testsuite/weak_as_needed_b.script: New version script. + * testsuite/weak_as_needed_c.c: New source file. + * testsuite/weak_as_needed_c.script: New version script. + 2018-06-20 Cary Coutant <ccoutant@gmail.com> PR gold/23268 |