aboutsummaryrefslogtreecommitdiff
path: root/gdbsupport/scoped_fd.h
diff options
context:
space:
mode:
authorTom de Vries <tdevries@suse.de>2020-10-26 16:05:15 +0100
committerTom de Vries <tdevries@suse.de>2020-10-26 16:05:15 +0100
commit55c3ad8801359ecb166ff3c04c3bd14140f623a1 (patch)
treea6b98540e067618712389489ca256ced78ad7649 /gdbsupport/scoped_fd.h
parentae9d2233e61a98ff8dba56be10219aa5306ffc9a (diff)
downloadgdb-55c3ad8801359ecb166ff3c04c3bd14140f623a1.zip
gdb-55c3ad8801359ecb166ff3c04c3bd14140f623a1.tar.gz
gdb-55c3ad8801359ecb166ff3c04c3bd14140f623a1.tar.bz2
[gdb/testsuite] Prevent pagination in GDB_INTERNALFLAGS
When running test-case gdb.base/corefile.exp with target board readnow, we run into: ... Reading symbols from outputs/gdb.base/corefile/corefile...^M Expanding full symbols from outputs/gdb.base/corefile/corefile...^M [New LWP 2293]^M Core was generated by `outputs/gdb.base/corefile/co'.^M Program terminated with signal SIGABRT, Aborted.^M --Type <RET> for more, q to quit, c to continue without paging--\ FAIL: gdb.base/corefile.exp: (timeout) starting with -core ... In commit bd447abb24 "Make gdb.base/corefile.exp work on terminals with few rows", pagination (in the same test-case) is prevented using: ... set stty_init "rows 25 cols 80" ... but this doesn't work in our case because using -readnow adds an extra line "Expanding full symbols". The test passes when increasing rows to 26. However, increasing the rows by some n only fixes the problem for n lines, and things will break again if somehow we end up with n + 1 lines. Instead, fix this by setting heigth and width in INTERNAL_GDBFLAGS. This solution was not chosen in commit bd447abb24 because it doesn't handle pagination due to the introduction text. But it does handle the pagination due to the extra "Expanding full symbols", and any other line printed during and after file loading. Tested on x86_64-linux, with and without readnow. With -readnow, fixes timeout FAILs in gdb.base/corefile.exp and gdb.base/reread-readsym.exp. gdb/testsuite/ChangeLog: 2020-10-26 Tom de Vries <tdevries@suse.de> * lib/gdb.exp (INTERNAL_GDBFLAGS): Set heigth and width.
Diffstat (limited to 'gdbsupport/scoped_fd.h')
0 files changed, 0 insertions, 0 deletions