diff options
author | Simon Marchi <simon.marchi@efficios.com> | 2020-11-02 10:26:14 -0500 |
---|---|---|
committer | Simon Marchi <simon.marchi@efficios.com> | 2020-11-02 10:28:45 -0500 |
commit | dda83cd783075941aabe9b0292b004b11f00c831 (patch) | |
tree | 185c06ef106c06ecc55ea045a4916495c1a3526b /gdbserver | |
parent | 1c2bec1918cee91221bccc30db4f0253dc31d1b7 (diff) | |
download | gdb-dda83cd783075941aabe9b0292b004b11f00c831.zip gdb-dda83cd783075941aabe9b0292b004b11f00c831.tar.gz gdb-dda83cd783075941aabe9b0292b004b11f00c831.tar.bz2 |
gdb, gdbserver, gdbsupport: fix leading space vs tabs issues
Many spots incorrectly use only spaces for indentation (for example,
there are a lot of spots in ada-lang.c). I've always found it awkward
when I needed to edit one of these spots: do I keep the original wrong
indentation, or do I fix it? What if the lines around it are also
wrong, do I fix them too? I probably don't want to fix them in the same
patch, to avoid adding noise to my patch.
So I propose to fix as much as possible once and for all (hopefully).
One typical counter argument for this is that it makes code archeology
more difficult, because git-blame will show this commit as the last
change for these lines. My counter counter argument is: when
git-blaming, you often need to do "blame the file at the parent commit"
anyway, to go past some other refactor that touched the line you are
interested in, but is not the change you are looking for. So you
already need a somewhat efficient way to do this.
Using some interactive tool, rather than plain git-blame, makes this
trivial. For example, I use "tig blame <file>", where going back past
the commit that changed the currently selected line is one keystroke.
It looks like Magit in Emacs does it too (though I've never used it).
Web viewers of Github and Gitlab do it too. My point is that it won't
really make archeology more difficult.
The other typical counter argument is that it will cause conflicts with
existing patches. That's true... but it's a one time cost, and those
are not conflicts that are difficult to resolve. I have also tried "git
rebase --ignore-whitespace", it seems to work well. Although that will
re-introduce the faulty indentation, so one needs to take care of fixing
the indentation in the patch after that (which is easy).
gdb/ChangeLog:
* aarch64-linux-tdep.c: Fix indentation.
* aarch64-ravenscar-thread.c: Fix indentation.
* aarch64-tdep.c: Fix indentation.
* aarch64-tdep.h: Fix indentation.
* ada-lang.c: Fix indentation.
* ada-lang.h: Fix indentation.
* ada-tasks.c: Fix indentation.
* ada-typeprint.c: Fix indentation.
* ada-valprint.c: Fix indentation.
* ada-varobj.c: Fix indentation.
* addrmap.c: Fix indentation.
* addrmap.h: Fix indentation.
* agent.c: Fix indentation.
* aix-thread.c: Fix indentation.
* alpha-bsd-nat.c: Fix indentation.
* alpha-linux-tdep.c: Fix indentation.
* alpha-mdebug-tdep.c: Fix indentation.
* alpha-nbsd-tdep.c: Fix indentation.
* alpha-obsd-tdep.c: Fix indentation.
* alpha-tdep.c: Fix indentation.
* amd64-bsd-nat.c: Fix indentation.
* amd64-darwin-tdep.c: Fix indentation.
* amd64-linux-nat.c: Fix indentation.
* amd64-linux-tdep.c: Fix indentation.
* amd64-nat.c: Fix indentation.
* amd64-obsd-tdep.c: Fix indentation.
* amd64-tdep.c: Fix indentation.
* amd64-windows-tdep.c: Fix indentation.
* annotate.c: Fix indentation.
* arc-tdep.c: Fix indentation.
* arch-utils.c: Fix indentation.
* arch/arm-get-next-pcs.c: Fix indentation.
* arch/arm.c: Fix indentation.
* arm-linux-nat.c: Fix indentation.
* arm-linux-tdep.c: Fix indentation.
* arm-nbsd-tdep.c: Fix indentation.
* arm-pikeos-tdep.c: Fix indentation.
* arm-tdep.c: Fix indentation.
* arm-tdep.h: Fix indentation.
* arm-wince-tdep.c: Fix indentation.
* auto-load.c: Fix indentation.
* auxv.c: Fix indentation.
* avr-tdep.c: Fix indentation.
* ax-gdb.c: Fix indentation.
* ax-general.c: Fix indentation.
* bfin-linux-tdep.c: Fix indentation.
* block.c: Fix indentation.
* block.h: Fix indentation.
* blockframe.c: Fix indentation.
* bpf-tdep.c: Fix indentation.
* break-catch-sig.c: Fix indentation.
* break-catch-syscall.c: Fix indentation.
* break-catch-throw.c: Fix indentation.
* breakpoint.c: Fix indentation.
* breakpoint.h: Fix indentation.
* bsd-uthread.c: Fix indentation.
* btrace.c: Fix indentation.
* build-id.c: Fix indentation.
* buildsym-legacy.h: Fix indentation.
* buildsym.c: Fix indentation.
* c-typeprint.c: Fix indentation.
* c-valprint.c: Fix indentation.
* c-varobj.c: Fix indentation.
* charset.c: Fix indentation.
* cli/cli-cmds.c: Fix indentation.
* cli/cli-decode.c: Fix indentation.
* cli/cli-decode.h: Fix indentation.
* cli/cli-script.c: Fix indentation.
* cli/cli-setshow.c: Fix indentation.
* coff-pe-read.c: Fix indentation.
* coffread.c: Fix indentation.
* compile/compile-cplus-types.c: Fix indentation.
* compile/compile-object-load.c: Fix indentation.
* compile/compile-object-run.c: Fix indentation.
* completer.c: Fix indentation.
* corefile.c: Fix indentation.
* corelow.c: Fix indentation.
* cp-abi.h: Fix indentation.
* cp-namespace.c: Fix indentation.
* cp-support.c: Fix indentation.
* cp-valprint.c: Fix indentation.
* cris-linux-tdep.c: Fix indentation.
* cris-tdep.c: Fix indentation.
* darwin-nat-info.c: Fix indentation.
* darwin-nat.c: Fix indentation.
* darwin-nat.h: Fix indentation.
* dbxread.c: Fix indentation.
* dcache.c: Fix indentation.
* disasm.c: Fix indentation.
* dtrace-probe.c: Fix indentation.
* dwarf2/abbrev.c: Fix indentation.
* dwarf2/attribute.c: Fix indentation.
* dwarf2/expr.c: Fix indentation.
* dwarf2/frame.c: Fix indentation.
* dwarf2/index-cache.c: Fix indentation.
* dwarf2/index-write.c: Fix indentation.
* dwarf2/line-header.c: Fix indentation.
* dwarf2/loc.c: Fix indentation.
* dwarf2/macro.c: Fix indentation.
* dwarf2/read.c: Fix indentation.
* dwarf2/read.h: Fix indentation.
* elfread.c: Fix indentation.
* eval.c: Fix indentation.
* event-top.c: Fix indentation.
* exec.c: Fix indentation.
* exec.h: Fix indentation.
* expprint.c: Fix indentation.
* f-lang.c: Fix indentation.
* f-typeprint.c: Fix indentation.
* f-valprint.c: Fix indentation.
* fbsd-nat.c: Fix indentation.
* fbsd-tdep.c: Fix indentation.
* findvar.c: Fix indentation.
* fork-child.c: Fix indentation.
* frame-unwind.c: Fix indentation.
* frame-unwind.h: Fix indentation.
* frame.c: Fix indentation.
* frv-linux-tdep.c: Fix indentation.
* frv-tdep.c: Fix indentation.
* frv-tdep.h: Fix indentation.
* ft32-tdep.c: Fix indentation.
* gcore.c: Fix indentation.
* gdb_bfd.c: Fix indentation.
* gdbarch.sh: Fix indentation.
* gdbarch.c: Re-generate
* gdbarch.h: Re-generate.
* gdbcore.h: Fix indentation.
* gdbthread.h: Fix indentation.
* gdbtypes.c: Fix indentation.
* gdbtypes.h: Fix indentation.
* glibc-tdep.c: Fix indentation.
* gnu-nat.c: Fix indentation.
* gnu-nat.h: Fix indentation.
* gnu-v2-abi.c: Fix indentation.
* gnu-v3-abi.c: Fix indentation.
* go32-nat.c: Fix indentation.
* guile/guile-internal.h: Fix indentation.
* guile/scm-cmd.c: Fix indentation.
* guile/scm-frame.c: Fix indentation.
* guile/scm-iterator.c: Fix indentation.
* guile/scm-math.c: Fix indentation.
* guile/scm-ports.c: Fix indentation.
* guile/scm-pretty-print.c: Fix indentation.
* guile/scm-value.c: Fix indentation.
* h8300-tdep.c: Fix indentation.
* hppa-linux-nat.c: Fix indentation.
* hppa-linux-tdep.c: Fix indentation.
* hppa-nbsd-nat.c: Fix indentation.
* hppa-nbsd-tdep.c: Fix indentation.
* hppa-obsd-nat.c: Fix indentation.
* hppa-tdep.c: Fix indentation.
* hppa-tdep.h: Fix indentation.
* i386-bsd-nat.c: Fix indentation.
* i386-darwin-nat.c: Fix indentation.
* i386-darwin-tdep.c: Fix indentation.
* i386-dicos-tdep.c: Fix indentation.
* i386-gnu-nat.c: Fix indentation.
* i386-linux-nat.c: Fix indentation.
* i386-linux-tdep.c: Fix indentation.
* i386-nto-tdep.c: Fix indentation.
* i386-obsd-tdep.c: Fix indentation.
* i386-sol2-nat.c: Fix indentation.
* i386-tdep.c: Fix indentation.
* i386-tdep.h: Fix indentation.
* i386-windows-tdep.c: Fix indentation.
* i387-tdep.c: Fix indentation.
* i387-tdep.h: Fix indentation.
* ia64-libunwind-tdep.c: Fix indentation.
* ia64-libunwind-tdep.h: Fix indentation.
* ia64-linux-nat.c: Fix indentation.
* ia64-linux-tdep.c: Fix indentation.
* ia64-tdep.c: Fix indentation.
* ia64-tdep.h: Fix indentation.
* ia64-vms-tdep.c: Fix indentation.
* infcall.c: Fix indentation.
* infcmd.c: Fix indentation.
* inferior.c: Fix indentation.
* infrun.c: Fix indentation.
* iq2000-tdep.c: Fix indentation.
* language.c: Fix indentation.
* linespec.c: Fix indentation.
* linux-fork.c: Fix indentation.
* linux-nat.c: Fix indentation.
* linux-tdep.c: Fix indentation.
* linux-thread-db.c: Fix indentation.
* lm32-tdep.c: Fix indentation.
* m2-lang.c: Fix indentation.
* m2-typeprint.c: Fix indentation.
* m2-valprint.c: Fix indentation.
* m32c-tdep.c: Fix indentation.
* m32r-linux-tdep.c: Fix indentation.
* m32r-tdep.c: Fix indentation.
* m68hc11-tdep.c: Fix indentation.
* m68k-bsd-nat.c: Fix indentation.
* m68k-linux-nat.c: Fix indentation.
* m68k-linux-tdep.c: Fix indentation.
* m68k-tdep.c: Fix indentation.
* machoread.c: Fix indentation.
* macrocmd.c: Fix indentation.
* macroexp.c: Fix indentation.
* macroscope.c: Fix indentation.
* macrotab.c: Fix indentation.
* macrotab.h: Fix indentation.
* main.c: Fix indentation.
* mdebugread.c: Fix indentation.
* mep-tdep.c: Fix indentation.
* mi/mi-cmd-catch.c: Fix indentation.
* mi/mi-cmd-disas.c: Fix indentation.
* mi/mi-cmd-env.c: Fix indentation.
* mi/mi-cmd-stack.c: Fix indentation.
* mi/mi-cmd-var.c: Fix indentation.
* mi/mi-cmds.c: Fix indentation.
* mi/mi-main.c: Fix indentation.
* mi/mi-parse.c: Fix indentation.
* microblaze-tdep.c: Fix indentation.
* minidebug.c: Fix indentation.
* minsyms.c: Fix indentation.
* mips-linux-nat.c: Fix indentation.
* mips-linux-tdep.c: Fix indentation.
* mips-nbsd-tdep.c: Fix indentation.
* mips-tdep.c: Fix indentation.
* mn10300-linux-tdep.c: Fix indentation.
* mn10300-tdep.c: Fix indentation.
* moxie-tdep.c: Fix indentation.
* msp430-tdep.c: Fix indentation.
* namespace.h: Fix indentation.
* nat/fork-inferior.c: Fix indentation.
* nat/gdb_ptrace.h: Fix indentation.
* nat/linux-namespaces.c: Fix indentation.
* nat/linux-osdata.c: Fix indentation.
* nat/netbsd-nat.c: Fix indentation.
* nat/x86-dregs.c: Fix indentation.
* nbsd-nat.c: Fix indentation.
* nbsd-tdep.c: Fix indentation.
* nios2-linux-tdep.c: Fix indentation.
* nios2-tdep.c: Fix indentation.
* nto-procfs.c: Fix indentation.
* nto-tdep.c: Fix indentation.
* objfiles.c: Fix indentation.
* objfiles.h: Fix indentation.
* opencl-lang.c: Fix indentation.
* or1k-tdep.c: Fix indentation.
* osabi.c: Fix indentation.
* osabi.h: Fix indentation.
* osdata.c: Fix indentation.
* p-lang.c: Fix indentation.
* p-typeprint.c: Fix indentation.
* p-valprint.c: Fix indentation.
* parse.c: Fix indentation.
* ppc-linux-nat.c: Fix indentation.
* ppc-linux-tdep.c: Fix indentation.
* ppc-nbsd-nat.c: Fix indentation.
* ppc-nbsd-tdep.c: Fix indentation.
* ppc-obsd-nat.c: Fix indentation.
* ppc-ravenscar-thread.c: Fix indentation.
* ppc-sysv-tdep.c: Fix indentation.
* ppc64-tdep.c: Fix indentation.
* printcmd.c: Fix indentation.
* proc-api.c: Fix indentation.
* producer.c: Fix indentation.
* producer.h: Fix indentation.
* prologue-value.c: Fix indentation.
* prologue-value.h: Fix indentation.
* psymtab.c: Fix indentation.
* python/py-arch.c: Fix indentation.
* python/py-bpevent.c: Fix indentation.
* python/py-event.c: Fix indentation.
* python/py-event.h: Fix indentation.
* python/py-finishbreakpoint.c: Fix indentation.
* python/py-frame.c: Fix indentation.
* python/py-framefilter.c: Fix indentation.
* python/py-inferior.c: Fix indentation.
* python/py-infthread.c: Fix indentation.
* python/py-objfile.c: Fix indentation.
* python/py-prettyprint.c: Fix indentation.
* python/py-registers.c: Fix indentation.
* python/py-signalevent.c: Fix indentation.
* python/py-stopevent.c: Fix indentation.
* python/py-stopevent.h: Fix indentation.
* python/py-threadevent.c: Fix indentation.
* python/py-tui.c: Fix indentation.
* python/py-unwind.c: Fix indentation.
* python/py-value.c: Fix indentation.
* python/py-xmethods.c: Fix indentation.
* python/python-internal.h: Fix indentation.
* python/python.c: Fix indentation.
* ravenscar-thread.c: Fix indentation.
* record-btrace.c: Fix indentation.
* record-full.c: Fix indentation.
* record.c: Fix indentation.
* reggroups.c: Fix indentation.
* regset.h: Fix indentation.
* remote-fileio.c: Fix indentation.
* remote.c: Fix indentation.
* reverse.c: Fix indentation.
* riscv-linux-tdep.c: Fix indentation.
* riscv-ravenscar-thread.c: Fix indentation.
* riscv-tdep.c: Fix indentation.
* rl78-tdep.c: Fix indentation.
* rs6000-aix-tdep.c: Fix indentation.
* rs6000-lynx178-tdep.c: Fix indentation.
* rs6000-nat.c: Fix indentation.
* rs6000-tdep.c: Fix indentation.
* rust-lang.c: Fix indentation.
* rx-tdep.c: Fix indentation.
* s12z-tdep.c: Fix indentation.
* s390-linux-tdep.c: Fix indentation.
* score-tdep.c: Fix indentation.
* ser-base.c: Fix indentation.
* ser-mingw.c: Fix indentation.
* ser-uds.c: Fix indentation.
* ser-unix.c: Fix indentation.
* serial.c: Fix indentation.
* sh-linux-tdep.c: Fix indentation.
* sh-nbsd-tdep.c: Fix indentation.
* sh-tdep.c: Fix indentation.
* skip.c: Fix indentation.
* sol-thread.c: Fix indentation.
* solib-aix.c: Fix indentation.
* solib-darwin.c: Fix indentation.
* solib-frv.c: Fix indentation.
* solib-svr4.c: Fix indentation.
* solib.c: Fix indentation.
* source.c: Fix indentation.
* sparc-linux-tdep.c: Fix indentation.
* sparc-nbsd-tdep.c: Fix indentation.
* sparc-obsd-tdep.c: Fix indentation.
* sparc-ravenscar-thread.c: Fix indentation.
* sparc-tdep.c: Fix indentation.
* sparc64-linux-tdep.c: Fix indentation.
* sparc64-nbsd-tdep.c: Fix indentation.
* sparc64-obsd-tdep.c: Fix indentation.
* sparc64-tdep.c: Fix indentation.
* stabsread.c: Fix indentation.
* stack.c: Fix indentation.
* stap-probe.c: Fix indentation.
* stubs/ia64vms-stub.c: Fix indentation.
* stubs/m32r-stub.c: Fix indentation.
* stubs/m68k-stub.c: Fix indentation.
* stubs/sh-stub.c: Fix indentation.
* stubs/sparc-stub.c: Fix indentation.
* symfile-mem.c: Fix indentation.
* symfile.c: Fix indentation.
* symfile.h: Fix indentation.
* symmisc.c: Fix indentation.
* symtab.c: Fix indentation.
* symtab.h: Fix indentation.
* target-float.c: Fix indentation.
* target.c: Fix indentation.
* target.h: Fix indentation.
* tic6x-tdep.c: Fix indentation.
* tilegx-linux-tdep.c: Fix indentation.
* tilegx-tdep.c: Fix indentation.
* top.c: Fix indentation.
* tracefile-tfile.c: Fix indentation.
* tracepoint.c: Fix indentation.
* tui/tui-disasm.c: Fix indentation.
* tui/tui-io.c: Fix indentation.
* tui/tui-regs.c: Fix indentation.
* tui/tui-stack.c: Fix indentation.
* tui/tui-win.c: Fix indentation.
* tui/tui-winsource.c: Fix indentation.
* tui/tui.c: Fix indentation.
* typeprint.c: Fix indentation.
* ui-out.h: Fix indentation.
* unittests/copy_bitwise-selftests.c: Fix indentation.
* unittests/memory-map-selftests.c: Fix indentation.
* utils.c: Fix indentation.
* v850-tdep.c: Fix indentation.
* valarith.c: Fix indentation.
* valops.c: Fix indentation.
* valprint.c: Fix indentation.
* valprint.h: Fix indentation.
* value.c: Fix indentation.
* value.h: Fix indentation.
* varobj.c: Fix indentation.
* vax-tdep.c: Fix indentation.
* windows-nat.c: Fix indentation.
* windows-tdep.c: Fix indentation.
* xcoffread.c: Fix indentation.
* xml-syscall.c: Fix indentation.
* xml-tdesc.c: Fix indentation.
* xstormy16-tdep.c: Fix indentation.
* xtensa-config.c: Fix indentation.
* xtensa-linux-nat.c: Fix indentation.
* xtensa-linux-tdep.c: Fix indentation.
* xtensa-tdep.c: Fix indentation.
gdbserver/ChangeLog:
* ax.cc: Fix indentation.
* dll.cc: Fix indentation.
* inferiors.h: Fix indentation.
* linux-low.cc: Fix indentation.
* linux-nios2-low.cc: Fix indentation.
* linux-ppc-ipa.cc: Fix indentation.
* linux-ppc-low.cc: Fix indentation.
* linux-x86-low.cc: Fix indentation.
* linux-xtensa-low.cc: Fix indentation.
* regcache.cc: Fix indentation.
* server.cc: Fix indentation.
* tracepoint.cc: Fix indentation.
gdbsupport/ChangeLog:
* common-exceptions.h: Fix indentation.
* event-loop.cc: Fix indentation.
* fileio.cc: Fix indentation.
* filestuff.cc: Fix indentation.
* gdb-dlfcn.cc: Fix indentation.
* gdb_string_view.h: Fix indentation.
* job-control.cc: Fix indentation.
* signals.cc: Fix indentation.
Change-Id: I4bad7ae6be0fbe14168b8ebafb98ffe14964a695
Diffstat (limited to 'gdbserver')
-rw-r--r-- | gdbserver/ChangeLog | 15 | ||||
-rw-r--r-- | gdbserver/ax.cc | 4 | ||||
-rw-r--r-- | gdbserver/dll.cc | 2 | ||||
-rw-r--r-- | gdbserver/inferiors.h | 2 | ||||
-rw-r--r-- | gdbserver/linux-low.cc | 2 | ||||
-rw-r--r-- | gdbserver/linux-nios2-low.cc | 2 | ||||
-rw-r--r-- | gdbserver/linux-ppc-ipa.cc | 2 | ||||
-rw-r--r-- | gdbserver/linux-ppc-low.cc | 28 | ||||
-rw-r--r-- | gdbserver/linux-x86-low.cc | 2 | ||||
-rw-r--r-- | gdbserver/linux-xtensa-low.cc | 2 | ||||
-rw-r--r-- | gdbserver/regcache.cc | 4 | ||||
-rw-r--r-- | gdbserver/server.cc | 12 | ||||
-rw-r--r-- | gdbserver/tracepoint.cc | 2 |
13 files changed, 47 insertions, 32 deletions
diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog index e1ba057..247b5e3 100644 --- a/gdbserver/ChangeLog +++ b/gdbserver/ChangeLog @@ -1,3 +1,18 @@ +2020-11-02 Simon Marchi <simon.marchi@efficios.com> + + * ax.cc: Fix indentation. + * dll.cc: Fix indentation. + * inferiors.h: Fix indentation. + * linux-low.cc: Fix indentation. + * linux-nios2-low.cc: Fix indentation. + * linux-ppc-ipa.cc: Fix indentation. + * linux-ppc-low.cc: Fix indentation. + * linux-x86-low.cc: Fix indentation. + * linux-xtensa-low.cc: Fix indentation. + * regcache.cc: Fix indentation. + * server.cc: Fix indentation. + * tracepoint.cc: Fix indentation. + 2020-10-31 Simon Marchi <simon.marchi@polymtl.ca> * acinclude.m4: Replace AC_TRY_COMPILE with AC_COMPILE_IFELSE + diff --git a/gdbserver/ax.cc b/gdbserver/ax.cc index 361e7a2..588ea61 100644 --- a/gdbserver/ax.cc +++ b/gdbserver/ax.cc @@ -873,7 +873,7 @@ ax_printf (CORE_ADDR fn, CORE_ADDR chan, const char *format, read_inferior_memory (tem, str, j); str[j] = 0; - printf (current_substring, (char *) str); + printf (current_substring, (char *) str); } break; @@ -882,7 +882,7 @@ ax_printf (CORE_ADDR fn, CORE_ADDR chan, const char *format, { long long val = args[i]; - printf (current_substring, val); + printf (current_substring, val); break; } #else diff --git a/gdbserver/dll.cc b/gdbserver/dll.cc index fdc7bec..5f4f4e7 100644 --- a/gdbserver/dll.cc +++ b/gdbserver/dll.cc @@ -67,7 +67,7 @@ unloaded_dll (const char *name, CORE_ADDR base_addr) else { /* DLL has been found so remove the entry and free associated - resources. */ + resources. */ all_dlls.erase (iter); dlls_changed = 1; } diff --git a/gdbserver/inferiors.h b/gdbserver/inferiors.h index bf2a16f..70c09d2 100644 --- a/gdbserver/inferiors.h +++ b/gdbserver/inferiors.h @@ -119,7 +119,7 @@ find_process (Func func) next++; if (func (*cur)) - return *cur; + return *cur; cur = next; } diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc index 06ce2f0..db3620e 100644 --- a/gdbserver/linux-low.cc +++ b/gdbserver/linux-low.cc @@ -2736,7 +2736,7 @@ select_event_lwp (struct lwp_info **orig_lp) if (event_thread == NULL) { /* No single-stepping LWP. Select one at random, out of those - which have had events. */ + which have had events. */ event_thread = find_thread_in_random ([&] (thread_info *thread) { diff --git a/gdbserver/linux-nios2-low.cc b/gdbserver/linux-nios2-low.cc index 838b0e9..3f1f13e 100644 --- a/gdbserver/linux-nios2-low.cc +++ b/gdbserver/linux-nios2-low.cc @@ -189,7 +189,7 @@ nios2_target::low_breakpoint_at (CORE_ADDR where) ps_err_e ps_get_thread_area (struct ps_prochandle *ph, - lwpid_t lwpid, int idx, void **base) + lwpid_t lwpid, int idx, void **base) { if (ptrace (PTRACE_GET_THREAD_AREA, lwpid, NULL, base) != 0) return PS_ERR; diff --git a/gdbserver/linux-ppc-ipa.cc b/gdbserver/linux-ppc-ipa.cc index 42d668f..b9dc81e 100644 --- a/gdbserver/linux-ppc-ipa.cc +++ b/gdbserver/linux-ppc-ipa.cc @@ -219,7 +219,7 @@ get_ipa_tdesc (int idx) #endif default: internal_error (__FILE__, __LINE__, - "unknown ipa tdesc index: %d", idx); + "unknown ipa tdesc index: %d", idx); #ifdef __powerpc64__ return tdesc_powerpc_64l; #else diff --git a/gdbserver/linux-ppc-low.cc b/gdbserver/linux-ppc-low.cc index 337d555..e5976f6 100644 --- a/gdbserver/linux-ppc-low.cc +++ b/gdbserver/linux-ppc-low.cc @@ -249,8 +249,8 @@ ppc_target::low_collect_ptrace_register (regcache *regcache, int regno, else if (__BYTE_ORDER == __BIG_ENDIAN) { /* Big-endian values sit at the right end of the buffer. In case of - registers whose sizes are smaller than sizeof (long), we must use a - padding to access them correctly. */ + registers whose sizes are smaller than sizeof (long), we must use a + padding to access them correctly. */ int size = register_size (regcache->tdesc, regno); if (size < sizeof (long)) @@ -274,8 +274,8 @@ ppc_target::low_supply_ptrace_register (regcache *regcache, int regno, else if (__BYTE_ORDER == __BIG_ENDIAN) { /* Big-endian values sit at the right end of the buffer. In case of - registers whose sizes are smaller than sizeof (long), we must use a - padding to access them correctly. */ + registers whose sizes are smaller than sizeof (long), we must use a + padding to access them correctly. */ int size = register_size (regcache->tdesc, regno); if (size < sizeof (long)) @@ -1367,12 +1367,12 @@ gen_limm (uint32_t *buf, int reg, uint64_t imm, int is_64) ori reg, reg, <imm[15:0]> */ p += GEN_LIS (p, reg, ((imm >> 48) & 0xffff)); if (((imm >> 32) & 0xffff) != 0) - p += GEN_ORI (p, reg, reg, ((imm >> 32) & 0xffff)); + p += GEN_ORI (p, reg, reg, ((imm >> 32) & 0xffff)); p += GEN_RLDICR (p, reg, reg, 32, 31); if (((imm >> 16) & 0xffff) != 0) - p += GEN_ORIS (p, reg, reg, ((imm >> 16) & 0xffff)); + p += GEN_ORIS (p, reg, reg, ((imm >> 16) & 0xffff)); if ((imm & 0xffff) != 0) - p += GEN_ORI (p, reg, reg, (imm & 0xffff)); + p += GEN_ORI (p, reg, reg, (imm & 0xffff)); } return p - buf; @@ -1844,8 +1844,8 @@ emit_insns (uint32_t *buf, int n) | Expand stack as needed. | +- - | Some padding for minimum stack frame and 16-byte alignment. - | 16 bytes. + | Some padding for minimum stack frame and 16-byte alignment. + | 16 bytes. SP +- Back-chain (SP') initial frame size @@ -2660,8 +2660,8 @@ static struct emit_ops ppc_emit_ops_impl = | Expand stack as needed. | +- - | Some padding for minimum stack frame. - | 112 for ELFv1. + | Some padding for minimum stack frame. + | 112 for ELFv1. SP +- Back-chain (SP') initial frame size @@ -2753,7 +2753,7 @@ ppc64_emit_epilogue (void) /* Restore registers. */ "ld 31, -8(1) \n" "ld 30, -16(1) \n" - /* Restore LR. */ + /* Restore LR. */ "ld 0, 16(1) \n" /* Return 0 for no-error. */ "li 3, 0 \n" @@ -3386,9 +3386,9 @@ ppc_target::emit_ops () if (register_size (regcache->tdesc, 0) == 8) { if (is_elfv2_inferior ()) - return &ppc64v2_emit_ops_impl; + return &ppc64v2_emit_ops_impl; else - return &ppc64v1_emit_ops_impl; + return &ppc64v1_emit_ops_impl; } #endif return &ppc_emit_ops_impl; diff --git a/gdbserver/linux-x86-low.cc b/gdbserver/linux-x86-low.cc index 65a0c07..c283018 100644 --- a/gdbserver/linux-x86-low.cc +++ b/gdbserver/linux-x86-low.cc @@ -432,7 +432,7 @@ x86_fill_gregset (struct regcache *regcache, void *buf) if (register_size (regcache->tdesc, 0) == 4) { void *ptr = ((gdb_byte *) buf - + i386_regmap[find_regno (regcache->tdesc, "eax")]); + + i386_regmap[find_regno (regcache->tdesc, "eax")]); *(int64_t *) ptr = *(int32_t *) ptr; } diff --git a/gdbserver/linux-xtensa-low.cc b/gdbserver/linux-xtensa-low.cc index a666f52..431ed54 100644 --- a/gdbserver/linux-xtensa-low.cc +++ b/gdbserver/linux-xtensa-low.cc @@ -279,7 +279,7 @@ xtensa_target::low_breakpoint_at (CORE_ADDR where) ps_err_e ps_get_thread_area (struct ps_prochandle *ph, - lwpid_t lwpid, int idx, void **base) + lwpid_t lwpid, int idx, void **base) { xtensa_elf_gregset_t regs; diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc index add826b..8ae195e 100644 --- a/gdbserver/regcache.cc +++ b/gdbserver/regcache.cc @@ -437,8 +437,8 @@ regcache_raw_read_unsigned (struct regcache *regcache, int regnum, if (size > (int) sizeof (ULONGEST)) error (_("That operation is not available on integers of more than" - "%d bytes."), - (int) sizeof (ULONGEST)); + "%d bytes."), + (int) sizeof (ULONGEST)); *val = 0; collect_register (regcache, regnum, val); diff --git a/gdbserver/server.cc b/gdbserver/server.cc index 1601453..95db980 100644 --- a/gdbserver/server.cc +++ b/gdbserver/server.cc @@ -2807,7 +2807,7 @@ resume (struct thread_resume *actions, size_t num_actions) } if (cs.last_status.kind != TARGET_WAITKIND_EXITED - && cs.last_status.kind != TARGET_WAITKIND_SIGNALLED + && cs.last_status.kind != TARGET_WAITKIND_SIGNALLED && cs.last_status.kind != TARGET_WAITKIND_NO_RESUMED) current_thread->last_status = cs.last_status; @@ -2820,8 +2820,8 @@ resume (struct thread_resume *actions, size_t num_actions) disable_async_io (); if (cs.last_status.kind == TARGET_WAITKIND_EXITED - || cs.last_status.kind == TARGET_WAITKIND_SIGNALLED) - target_mourn_inferior (cs.last_ptid); + || cs.last_status.kind == TARGET_WAITKIND_SIGNALLED) + target_mourn_inferior (cs.last_ptid); } } @@ -3829,11 +3829,11 @@ captured_main (int argc, char *argv[]) - If --once was specified, we're done. - If not in extended-remote mode, and we're no longer - debugging anything, simply exit: GDB has disconnected - after processing the last process exit. + debugging anything, simply exit: GDB has disconnected + after processing the last process exit. - Otherwise, close the connection and reopen it at the - top of the loop. */ + top of the loop. */ if (run_once || (!extended_protocol && !target_running ())) throw_quit ("Quit"); diff --git a/gdbserver/tracepoint.cc b/gdbserver/tracepoint.cc index 6881f31..8788244 100644 --- a/gdbserver/tracepoint.cc +++ b/gdbserver/tracepoint.cc @@ -3242,7 +3242,7 @@ cmd_qtstart (char *packet) /* Tell IPA about the correct tdesc. */ if (write_inferior_integer (ipa_sym_addrs.addr_ipa_tdesc_idx, target_get_ipa_tdesc_idx ())) - error ("Error setting ipa_tdesc_idx variable in lib"); + error ("Error setting ipa_tdesc_idx variable in lib"); } /* Start out empty. */ |