diff options
| author | Christian Biesinger <cbiesinger@google.com> | 2019-12-13 17:35:05 -0500 |
|---|---|---|
| committer | Christian Biesinger <cbiesinger@google.com> | 2019-12-13 17:44:52 -0500 |
| commit | f1d293cc58bfe5f6b507dc2351f17632df8ab677 (patch) | |
| tree | f03ac6d9bd80f4df15eb59a4ad5194b07f540fa8 /gdb | |
| parent | 234c306803e0b3c423b3935562a029f3bad04482 (diff) | |
| download | gdb-f1d293cc58bfe5f6b507dc2351f17632df8ab677.zip gdb-f1d293cc58bfe5f6b507dc2351f17632df8ab677.tar.gz gdb-f1d293cc58bfe5f6b507dc2351f17632df8ab677.tar.bz2 | |
Revert "Turn off threaded minsym demangling by default"
This reverts commit 62e77f56f0ce8b10122881d8f0acd70e113fde93.
(except for ChangeLog and a bugfix in minimal_symbol_reader::install)
As agreed on the mailing list, now that GDB 9 has branched, this patch
reverts the change to set worker-threads to zero. After this patch,
multithreaded minsym demangling will be enabled again by default.
gdb/ChangeLog:
2019-12-13 Christian Biesinger <cbiesinger@google.com>
* maint.c (n_worker_threads): Default to -1.
(worker_threads_disabled): Remove function.
* maint.h (worker_threads_disabled): Remove function.
* minsyms.c (minimal_symbol_reader::record_full): Don't call
symbol_set_names here if worker_threads_disabled () is true.
Change-Id: I5ff3e318d96f60968c8b8bedb84546ad2314d94b
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/maint.c | 7 | ||||
| -rw-r--r-- | gdb/maint.h | 2 | ||||
| -rw-r--r-- | gdb/minsyms.c | 10 |
3 files changed, 1 insertions, 18 deletions
diff --git a/gdb/maint.c b/gdb/maint.c index f71cb80..51b803a 100644 --- a/gdb/maint.c +++ b/gdb/maint.c @@ -845,12 +845,7 @@ maintenance_set_profile_cmd (const char *args, int from_tty, } #endif -static int n_worker_threads = 0; - -bool worker_threads_disabled () -{ - return n_worker_threads == 0; -} +static int n_worker_threads = -1; /* Update the thread pool for the desired number of threads. */ static void diff --git a/gdb/maint.h b/gdb/maint.h index cbaf9de..827964d 100644 --- a/gdb/maint.h +++ b/gdb/maint.h @@ -26,8 +26,6 @@ extern void set_per_command_time (int); extern void set_per_command_space (int); -extern bool worker_threads_disabled (); - /* Records a run time and space usage to be used as a base for reporting elapsed time or change in space. */ diff --git a/gdb/minsyms.c b/gdb/minsyms.c index 4f7260b..40bedbd 100644 --- a/gdb/minsyms.c +++ b/gdb/minsyms.c @@ -54,7 +54,6 @@ #include <algorithm> #include "safe-ctype.h" #include "gdbsupport/parallel-for.h" -#include "maint.h" #if CXX_STD_THREAD #include <mutex> @@ -1138,15 +1137,6 @@ minimal_symbol_reader::record_full (gdb::string_view name, else msymbol->name = name.data (); - if (worker_threads_disabled ()) - { - /* To keep our behavior as close as possible to the previous non-threaded - behavior for GDB 9.1, we call symbol_set_names here when threads - are disabled. */ - symbol_set_names (msymbol, msymbol->name, false, m_objfile->per_bfd); - msymbol->name_set = 1; - } - SET_MSYMBOL_VALUE_ADDRESS (msymbol, address); MSYMBOL_SECTION (msymbol) = section; |