diff options
| author | Andrew Burgess <andrew.burgess@embecosm.com> | 2018-12-19 22:31:50 +0000 |
|---|---|---|
| committer | Andrew Burgess <andrew.burgess@embecosm.com> | 2019-02-27 16:54:43 +0200 |
| commit | 2fbe7ad059d9ec2a8a378a5c2b973a1188677422 (patch) | |
| tree | a06f896bfe4f9bbb487ea535aa80dbddaf71120a /gdb | |
| parent | 76055cbe88cc6623f88c8ae43ed8b8ae6883df9e (diff) | |
| download | gdb-2fbe7ad059d9ec2a8a378a5c2b973a1188677422.zip gdb-2fbe7ad059d9ec2a8a378a5c2b973a1188677422.tar.gz gdb-2fbe7ad059d9ec2a8a378a5c2b973a1188677422.tar.bz2 | |
gdb/frv: Use default gdbarch methods where possible
Make use of the default gdbarch methods for gdbarch_dummy_id,
gdbarch_unwind_pc, and gdbarch_unwind_sp where possible.
I have not tested this change but, by inspecting the code, I believe
the default methods are equivalent to the code being deleted.
gdb/ChangeLog:
* gdb/frv-tdep.c (frv_dummy_id): Delete.
(frv_unwind_pc): Delete.
(frv_unwind_sp): Delete.
(frv_gdbarch_init): Don't register deleted functions with
gdbarch.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/ChangeLog | 8 | ||||
| -rw-r--r-- | gdb/frv-tdep.c | 27 |
2 files changed, 8 insertions, 27 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 49e312f..cb8f674 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,13 @@ 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com> + * gdb/frv-tdep.c (frv_dummy_id): Delete. + (frv_unwind_pc): Delete. + (frv_unwind_sp): Delete. + (frv_gdbarch_init): Don't register deleted functions with + gdbarch. + +2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com> + * gdb/riscv-tdep.c (riscv_dummy_id): Delete. (riscv_unwind_pc): Delete. (riscv_unwind_sp): Delete. diff --git a/gdb/frv-tdep.c b/gdb/frv-tdep.c index 6372691..804206b 100644 --- a/gdb/frv-tdep.c +++ b/gdb/frv-tdep.c @@ -1367,12 +1367,6 @@ frv_return_value (struct gdbarch *gdbarch, struct value *function, return RETURN_VALUE_REGISTER_CONVENTION; } -static CORE_ADDR -frv_unwind_pc (struct gdbarch *gdbarch, struct frame_info *next_frame) -{ - return frame_unwind_register_unsigned (next_frame, pc_regnum); -} - /* Given a GDB frame, determine the address of the calling function's frame. This will be used to create a new GDB frame struct. */ @@ -1439,24 +1433,6 @@ static const struct frame_base frv_frame_base = { frv_frame_base_address }; -static CORE_ADDR -frv_unwind_sp (struct gdbarch *gdbarch, struct frame_info *next_frame) -{ - return frame_unwind_register_unsigned (next_frame, sp_regnum); -} - - -/* Assuming THIS_FRAME is a dummy, return the frame ID of that dummy - frame. The frame ID's base needs to match the TOS value saved by - save_dummy_frame_tos(), and the PC match the dummy frame's breakpoint. */ - -static struct frame_id -frv_dummy_id (struct gdbarch *gdbarch, struct frame_info *this_frame) -{ - CORE_ADDR sp = get_frame_register_unsigned (this_frame, sp_regnum); - return frame_id_build (sp, get_frame_pc (this_frame)); -} - static struct gdbarch * frv_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) { @@ -1540,8 +1516,6 @@ frv_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) set_gdbarch_return_value (gdbarch, frv_return_value); /* Frame stuff. */ - set_gdbarch_unwind_pc (gdbarch, frv_unwind_pc); - set_gdbarch_unwind_sp (gdbarch, frv_unwind_sp); set_gdbarch_frame_align (gdbarch, frv_frame_align); frame_base_set_default (gdbarch, &frv_frame_base); /* We set the sniffer lower down after the OSABI hooks have been @@ -1549,7 +1523,6 @@ frv_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) /* Settings for calling functions in the inferior. */ set_gdbarch_push_dummy_call (gdbarch, frv_push_dummy_call); - set_gdbarch_dummy_id (gdbarch, frv_dummy_id); /* Settings that should be unnecessary. */ set_gdbarch_inner_than (gdbarch, core_addr_lessthan); |