diff options
| author | Yao Qi <yao@codesourcery.com> | 2013-11-04 11:16:37 +0800 |
|---|---|---|
| committer | Yao Qi <yao@codesourcery.com> | 2013-12-18 11:46:56 +0800 |
| commit | cde33bf1035aac8e2e35c4699544dcc166f2054d (patch) | |
| tree | 8c267914f48f291eab0b3168acc927870daee4a5 /gdb | |
| parent | 230de03ab46fe0ed122dc0ed0370781f39692eb7 (diff) | |
| download | gdb-cde33bf1035aac8e2e35c4699544dcc166f2054d.zip gdb-cde33bf1035aac8e2e35c4699544dcc166f2054d.tar.gz gdb-cde33bf1035aac8e2e35c4699544dcc166f2054d.tar.bz2 | |
Replace sprintf with xsnprintf
gdb:
2013-12-18 Yao Qi <yao@codesourcery.com>
* linux-nat.c (linux_proc_xfer_partial): Call xsnprintf instead
of sprintf.
(linux_nat_detach, linux_child_pid_to_exec_file): Likewise.
(linux_proc_pending_signals): Likewise.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/ChangeLog | 7 | ||||
| -rw-r--r-- | gdb/linux-nat.c | 9 |
2 files changed, 12 insertions, 4 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 6e67bac..196bcb0 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,10 @@ +2013-12-18 Yao Qi <yao@codesourcery.com> + + * linux-nat.c (linux_proc_xfer_partial): Call xsnprintf instead + of sprintf. + (linux_nat_detach, linux_child_pid_to_exec_file): Likewise. + (linux_proc_pending_signals): Likewise. + 2013-12-18 Joel Brobecker <brobecker@adacore.com> * value.c (value_entirely_unavailable): ARI fix: Move trailing diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c index d2091ca..a34b29a 100644 --- a/gdb/linux-nat.c +++ b/gdb/linux-nat.c @@ -1592,7 +1592,7 @@ linux_nat_detach (struct target_ops *ops, const char *args, int from_tty) /* Put the signal number in ARGS so that inf_ptrace_detach will pass it along with PTRACE_DETACH. */ tem = alloca (8); - sprintf (tem, "%d", (int) WSTOPSIG (status)); + xsnprintf (tem, 8, "%d", (int) WSTOPSIG (status)); args = tem; if (debug_linux_nat) fprintf_unfiltered (gdb_stdlog, @@ -4049,7 +4049,7 @@ linux_child_pid_to_exec_file (int pid) make_cleanup (xfree, name2); memset (name2, 0, PATH_MAX); - sprintf (name1, "/proc/%d/exe", pid); + xsnprintf (name1, PATH_MAX, "/proc/%d/exe", pid); if (readlink (name1, name2, PATH_MAX - 1) > 0) return name2; else @@ -4135,7 +4135,8 @@ linux_proc_xfer_partial (struct target_ops *ops, enum target_object object, /* We could keep this file open and cache it - possibly one per thread. That requires some juggling, but is even faster. */ - sprintf (filename, "/proc/%d/mem", ptid_get_pid (inferior_ptid)); + xsnprintf (filename, sizeof filename, "/proc/%d/mem", + ptid_get_pid (inferior_ptid)); fd = gdb_open_cloexec (filename, O_RDONLY | O_LARGEFILE, 0); if (fd == -1) return 0; @@ -4305,7 +4306,7 @@ linux_proc_pending_signals (int pid, sigset_t *pending, sigemptyset (pending); sigemptyset (blocked); sigemptyset (ignored); - sprintf (fname, "/proc/%d/status", pid); + xsnprintf (fname, sizeof fname, "/proc/%d/status", pid); procfile = gdb_fopen_cloexec (fname, "r"); if (procfile == NULL) error (_("Could not open %s"), fname); |