aboutsummaryrefslogtreecommitdiff
path: root/gdb
diff options
context:
space:
mode:
authorTom Tromey <tom@tromey.com>2019-07-05 12:00:06 -0600
committerTom Tromey <tom@tromey.com>2019-08-13 14:52:09 -0600
commita3504e96544b3f8918c4521116d537a4a07c2106 (patch)
tree0ee7a2446c9305b36e5fc54cdcc355b02ec216e7 /gdb
parent011168429859e3e3a2342ee043cbc2c7a5cf5e2f (diff)
downloadgdb-a3504e96544b3f8918c4521116d537a4a07c2106.zip
gdb-a3504e96544b3f8918c4521116d537a4a07c2106.tar.gz
gdb-a3504e96544b3f8918c4521116d537a4a07c2106.tar.bz2
clear_detail can only be called on TUI source windows
The clear_detail method can only be called on source windows, so remove definitions from the base of the class hierarchy, leaving only a single non-virtual method. gdb/ChangeLog 2019-08-13 Tom Tromey <tom@tromey.com> * tui/tui-winsource.h (struct tui_source_window_base) <clear_detail>: No longer "override". * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove. * tui/tui-regs.c (tui_data_window::clear_detail): Remove. * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove. * tui/tui-command.h (struct tui_cmd_window) <clear_detail>: Remove. * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
Diffstat (limited to 'gdb')
-rw-r--r--gdb/ChangeLog11
-rw-r--r--gdb/tui/tui-command.c8
-rw-r--r--gdb/tui/tui-command.h2
-rw-r--r--gdb/tui/tui-data.h3
-rw-r--r--gdb/tui/tui-regs.c10
-rw-r--r--gdb/tui/tui-regs.h1
-rw-r--r--gdb/tui/tui-winsource.h2
7 files changed, 12 insertions, 25 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 6c4208f..58a32a2 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,14 @@
+2019-08-13 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-winsource.h (struct tui_source_window_base)
+ <clear_detail>: No longer "override".
+ * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
+ * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
+ * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
+ * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
+ Remove.
+ * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
+
2019-08-13 Tom Tromey <tromey@adacore.com>
* tracepoint.c: Don't include readline.h or history.h.
diff --git a/gdb/tui/tui-command.c b/gdb/tui/tui-command.c
index 5af3484..034abd5 100644
--- a/gdb/tui/tui-command.c
+++ b/gdb/tui/tui-command.c
@@ -31,14 +31,6 @@
/* See tui-command.h. */
void
-tui_cmd_window::clear_detail ()
-{
- wmove (handle, 0, 0);
-}
-
-/* See tui-command.h. */
-
-void
tui_cmd_window::do_make_visible_with_new_height ()
{
#ifdef HAVE_WRESIZE
diff --git a/gdb/tui/tui-command.h b/gdb/tui/tui-command.h
index d2a8ab1..af80b14 100644
--- a/gdb/tui/tui-command.h
+++ b/gdb/tui/tui-command.h
@@ -35,8 +35,6 @@ struct tui_cmd_window : public tui_win_info
DISABLE_COPY_AND_ASSIGN (tui_cmd_window);
- void clear_detail () override;
-
void make_visible (bool visible) override
{
}
diff --git a/gdb/tui/tui-data.h b/gdb/tui/tui-data.h
index 214f728..5a7c487 100644
--- a/gdb/tui/tui-data.h
+++ b/gdb/tui/tui-data.h
@@ -249,9 +249,6 @@ public:
{
}
- /* Clear the pertinent detail in the window. */
- virtual void clear_detail () = 0;
-
/* Called after all the TUI windows are refreshed, to let this
window have a chance to update itself further. */
virtual void refresh_all ()
diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c
index c13a5b1..2765462 100644
--- a/gdb/tui/tui-regs.c
+++ b/gdb/tui/tui-regs.c
@@ -521,16 +521,6 @@ tui_data_window::do_scroll_vertical (int num_to_scroll)
/* See tui-regs.h. */
void
-tui_data_window::clear_detail ()
-{
- regs_content.clear ();
- regs_column_count = 1;
- display_regs = false;
-}
-
-/* See tui-regs.h. */
-
-void
tui_data_window::set_new_height (int height)
{
/* Delete all data item windows. */
diff --git a/gdb/tui/tui-regs.h b/gdb/tui/tui-regs.h
index 0646729..b2abfc2 100644
--- a/gdb/tui/tui-regs.h
+++ b/gdb/tui/tui-regs.h
@@ -53,7 +53,6 @@ struct tui_data_window : public tui_win_info
DISABLE_COPY_AND_ASSIGN (tui_data_window);
- void clear_detail () override;
void refresh_all () override;
void set_new_height (int height) override;
diff --git a/gdb/tui/tui-winsource.h b/gdb/tui/tui-winsource.h
index ec44d1d..9d7f0a7 100644
--- a/gdb/tui/tui-winsource.h
+++ b/gdb/tui/tui-winsource.h
@@ -67,7 +67,7 @@ protected:
public:
- void clear_detail () override;
+ void clear_detail ();
void make_visible (bool visible) override;
void refresh_window () override;