diff options
| author | Andrew Burgess <andrew.burgess@embecosm.com> | 2018-09-09 15:52:28 +0100 |
|---|---|---|
| committer | Andrew Burgess <andrew.burgess@embecosm.com> | 2019-02-27 16:54:42 +0200 |
| commit | 7a995095f35f024517ddaa07b8a8ad04463e3ce5 (patch) | |
| tree | fbbb762927e26794c1f4fd94cc89cc2a1ac8dc47 /gdb | |
| parent | 52d6f3ee9439bb20c45421ecfeef2a69fd0b5511 (diff) | |
| download | gdb-7a995095f35f024517ddaa07b8a8ad04463e3ce5.zip gdb-7a995095f35f024517ddaa07b8a8ad04463e3ce5.tar.gz gdb-7a995095f35f024517ddaa07b8a8ad04463e3ce5.tar.bz2 | |
gdb/aarch64: Use default gdbarch methods where possible
Make use of the default gdbarch methods for gdbarch_dummy_id,
gdbarch_unwind_pc, and gdbarch_unwind_sp where possible.
I have not tested this change but, by inspecting the code, I believe
the default methods are equivalent to the code being deleted.
gdb/ChangeLog:
* gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
(aarch64_unwind_pc): Delete.
(aarch64_unwind_sp): Delete.
(aarch64_gdbarch_init): Don't register deleted functions with
gdbarch.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/ChangeLog | 8 | ||||
| -rw-r--r-- | gdb/aarch64-tdep.c | 38 |
2 files changed, 8 insertions, 38 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index ae9a68f..e06d2d9 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,13 @@ 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com> + * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete. + (aarch64_unwind_pc): Delete. + (aarch64_unwind_sp): Delete. + (aarch64_gdbarch_init): Don't register deleted functions with + gdbarch. + +2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com> + * gdbtypes.c (type_align): Don't consider static members when computing structure alignment. diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c index f855393..dd57ef9 100644 --- a/gdb/aarch64-tdep.c +++ b/gdb/aarch64-tdep.c @@ -998,39 +998,6 @@ struct frame_base aarch64_normal_base = aarch64_normal_frame_base }; -/* Assuming THIS_FRAME is a dummy, return the frame ID of that - dummy frame. The frame ID's base needs to match the TOS value - saved by save_dummy_frame_tos () and returned from - aarch64_push_dummy_call, and the PC needs to match the dummy - frame's breakpoint. */ - -static struct frame_id -aarch64_dummy_id (struct gdbarch *gdbarch, struct frame_info *this_frame) -{ - return frame_id_build (get_frame_register_unsigned (this_frame, - AARCH64_SP_REGNUM), - get_frame_pc (this_frame)); -} - -/* Implement the "unwind_pc" gdbarch method. */ - -static CORE_ADDR -aarch64_unwind_pc (struct gdbarch *gdbarch, struct frame_info *this_frame) -{ - CORE_ADDR pc - = frame_unwind_register_unsigned (this_frame, AARCH64_PC_REGNUM); - - return pc; -} - -/* Implement the "unwind_sp" gdbarch method. */ - -static CORE_ADDR -aarch64_unwind_sp (struct gdbarch *gdbarch, struct frame_info *this_frame) -{ - return frame_unwind_register_unsigned (this_frame, AARCH64_SP_REGNUM); -} - /* Return the value of the REGNUM register in the previous frame of *THIS_FRAME. */ @@ -3091,11 +3058,6 @@ aarch64_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) set_gdbarch_push_dummy_call (gdbarch, aarch64_push_dummy_call); set_gdbarch_frame_align (gdbarch, aarch64_frame_align); - /* Frame handling. */ - set_gdbarch_dummy_id (gdbarch, aarch64_dummy_id); - set_gdbarch_unwind_pc (gdbarch, aarch64_unwind_pc); - set_gdbarch_unwind_sp (gdbarch, aarch64_unwind_sp); - /* Advance PC across function entry code. */ set_gdbarch_skip_prologue (gdbarch, aarch64_skip_prologue); |