diff options
| author | Tom Tromey <tom@tromey.com> | 2016-09-27 11:28:18 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2018-05-04 22:04:46 -0600 |
| commit | 565e0edacc48c86adfb12515ed6911c08c1f64d9 (patch) | |
| tree | 6c3259b9f9037b2dfda5f38905c87c2358cc57d5 /gdb | |
| parent | 621846f4e258167be2147894e013c85e42de1447 (diff) | |
| download | gdb-565e0edacc48c86adfb12515ed6911c08c1f64d9.zip gdb-565e0edacc48c86adfb12515ed6911c08c1f64d9.tar.gz gdb-565e0edacc48c86adfb12515ed6911c08c1f64d9.tar.bz2 | |
Fix "obvious" fall-through warnings
This patch fixes the subset of -Wimplicit-fallthrough warnings that I
considered obvious. In most cases it was obvious from context that
falling through was desired; here I added the appropriate comment. In
a couple of cases it seemed clear that a "break" was missing.
ChangeLog
2018-05-04 Tom Tromey <tom@tromey.com>
* riscv-tdep.c (riscv_isa_xlen): Add fall-through comment.
* utils.c (can_dump_core) <LIMIT_CUR>: Add fall-through comment.
* eval.c (fetch_subexp_value) <MEMORY_ERROR>: Add fall-through
comment.
* d-valprint.c (d_val_print) <TYPE_CODE_STRUCT>: Add fall-through
comment.
* coffread.c (coff_symtab_read) <C_LABEL>: Add fall-through
comment.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/ChangeLog | 11 | ||||
| -rw-r--r-- | gdb/coffread.c | 1 | ||||
| -rw-r--r-- | gdb/d-valprint.c | 1 | ||||
| -rw-r--r-- | gdb/eval.c | 1 | ||||
| -rw-r--r-- | gdb/riscv-tdep.c | 1 | ||||
| -rw-r--r-- | gdb/utils.c | 1 |
6 files changed, 16 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index d627749..4bdd444 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,16 @@ 2018-05-04 Tom Tromey <tom@tromey.com> + * riscv-tdep.c (riscv_isa_xlen): Add fall-through comment. + * utils.c (can_dump_core) <LIMIT_CUR>: Add fall-through comment. + * eval.c (fetch_subexp_value) <MEMORY_ERROR>: Add fall-through + comment. + * d-valprint.c (d_val_print) <TYPE_CODE_STRUCT>: Add fall-through + comment. + * coffread.c (coff_symtab_read) <C_LABEL>: Add fall-through + comment. + +2018-05-04 Tom Tromey <tom@tromey.com> + * dwarf2loc.c (unimplemented): Add ATTRIBUTE_NORETURN. 2018-05-04 Tom Tromey <tom@tromey.com> diff --git a/gdb/coffread.c b/gdb/coffread.c index 192d38c..f24ec07 100644 --- a/gdb/coffread.c +++ b/gdb/coffread.c @@ -928,6 +928,7 @@ coff_symtab_read (minimal_symbol_reader &reader, backtraces, so filter them out (from phdm@macqel.be). */ if (within_function) break; + /* Fall through. */ case C_STAT: case C_THUMBLABEL: case C_THUMBSTAT: diff --git a/gdb/d-valprint.c b/gdb/d-valprint.c index e2d8431..579d3c8 100644 --- a/gdb/d-valprint.c +++ b/gdb/d-valprint.c @@ -88,6 +88,7 @@ d_val_print (struct type *type, int embedded_offset, stream, recurse, val, options); if (ret == 0) break; + /* Fall through. */ default: c_val_print (type, embedded_offset, address, stream, recurse, val, options); @@ -215,6 +215,7 @@ fetch_subexp_value (struct expression *exp, int *pc, struct value **valp, case MEMORY_ERROR: if (!preserve_errors) break; + /* Fall through. */ default: throw_exception (ex); break; diff --git a/gdb/riscv-tdep.c b/gdb/riscv-tdep.c index 149e5e3..9fa458b 100644 --- a/gdb/riscv-tdep.c +++ b/gdb/riscv-tdep.c @@ -369,6 +369,7 @@ riscv_isa_xlen (struct gdbarch *gdbarch) { default: warning (_("unknown xlen size, assuming 4 bytes")); + /* Fall through. */ case 1: return 4; case 2: diff --git a/gdb/utils.c b/gdb/utils.c index e274f02..63929b2 100644 --- a/gdb/utils.c +++ b/gdb/utils.c @@ -275,6 +275,7 @@ can_dump_core (enum resource_limit_kind limit_kind) case LIMIT_CUR: if (rlim.rlim_cur == 0) return 0; + /* Fall through. */ case LIMIT_MAX: if (rlim.rlim_max == 0) |