aboutsummaryrefslogtreecommitdiff
path: root/gdb
diff options
context:
space:
mode:
authorTom Tromey <tromey@redhat.com>2013-12-18 20:16:56 -0700
committerTom Tromey <tromey@redhat.com>2014-02-19 07:48:24 -0700
commit8444ab58be111620c35932b1639a7b6b17845309 (patch)
treee50673706502a50cea45db6222073277a6eaa1fe /gdb
parentc29302cc8aef5856ae6ed63cef46c17dcc1b790a (diff)
downloadgdb-8444ab58be111620c35932b1639a7b6b17845309.zip
gdb-8444ab58be111620c35932b1639a7b6b17845309.tar.gz
gdb-8444ab58be111620c35932b1639a7b6b17845309.tar.bz2
convert to_insn_history_from
2014-02-19 Tom Tromey <tromey@redhat.com> * target-delegates.c: Rebuild. * target.c (target_insn_history_from): Unconditionally delegate. * target.h (struct target_ops) <to_insn_history_from>: Use TARGET_DEFAULT_NORETURN.
Diffstat (limited to 'gdb')
-rw-r--r--gdb/ChangeLog7
-rw-r--r--gdb/target-delegates.c16
-rw-r--r--gdb/target.c11
-rw-r--r--gdb/target.h3
4 files changed, 26 insertions, 11 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index f2aa5c2..584f6c1 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,6 +1,13 @@
2014-02-19 Tom Tromey <tromey@redhat.com>
* target-delegates.c: Rebuild.
+ * target.c (target_insn_history_from): Unconditionally delegate.
+ * target.h (struct target_ops) <to_insn_history_from>: Use
+ TARGET_DEFAULT_NORETURN.
+
+2014-02-19 Tom Tromey <tromey@redhat.com>
+
+ * target-delegates.c: Rebuild.
* target.c (target_insn_history_range): Unconditionally delegate.
* target.h (struct target_ops) <to_insn_history_range>: Use
TARGET_DEFAULT_NORETURN.
diff --git a/gdb/target-delegates.c b/gdb/target-delegates.c
index a1d748c..be52f50 100644
--- a/gdb/target-delegates.c
+++ b/gdb/target-delegates.c
@@ -1261,6 +1261,19 @@ tdefault_supports_btrace (struct target_ops *self)
}
static void
+delegate_insn_history_from (struct target_ops *self, ULONGEST arg1, int arg2, int arg3)
+{
+ self = self->beneath;
+ self->to_insn_history_from (self, arg1, arg2, arg3);
+}
+
+static void
+tdefault_insn_history_from (struct target_ops *self, ULONGEST arg1, int arg2, int arg3)
+{
+ tcomplain ();
+}
+
+static void
delegate_insn_history_range (struct target_ops *self, ULONGEST arg1, ULONGEST arg2, int arg3)
{
self = self->beneath;
@@ -1540,6 +1553,8 @@ install_delegators (struct target_ops *ops)
ops->to_can_use_agent = delegate_can_use_agent;
if (ops->to_supports_btrace == NULL)
ops->to_supports_btrace = delegate_supports_btrace;
+ if (ops->to_insn_history_from == NULL)
+ ops->to_insn_history_from = delegate_insn_history_from;
if (ops->to_insn_history_range == NULL)
ops->to_insn_history_range = delegate_insn_history_range;
if (ops->to_call_history == NULL)
@@ -1661,6 +1676,7 @@ install_dummy_methods (struct target_ops *ops)
ops->to_use_agent = tdefault_use_agent;
ops->to_can_use_agent = tdefault_can_use_agent;
ops->to_supports_btrace = tdefault_supports_btrace;
+ ops->to_insn_history_from = tdefault_insn_history_from;
ops->to_insn_history_range = tdefault_insn_history_range;
ops->to_call_history = tdefault_call_history;
ops->to_call_history_from = tdefault_call_history_from;
diff --git a/gdb/target.c b/gdb/target.c
index b20c150..453d7ad 100644
--- a/gdb/target.c
+++ b/gdb/target.c
@@ -4029,16 +4029,7 @@ target_insn_history (int size, int flags)
void
target_insn_history_from (ULONGEST from, int size, int flags)
{
- struct target_ops *t;
-
- for (t = current_target.beneath; t != NULL; t = t->beneath)
- if (t->to_insn_history_from != NULL)
- {
- t->to_insn_history_from (t, from, size, flags);
- return;
- }
-
- tcomplain ();
+ current_target.to_insn_history_from (&current_target, from, size, flags);
}
/* See target.h. */
diff --git a/gdb/target.h b/gdb/target.h
index f53b73e..73288cf 100644
--- a/gdb/target.h
+++ b/gdb/target.h
@@ -1054,7 +1054,8 @@ struct target_ops
If SIZE < 0, disassemble abs (SIZE) instructions before FROM; otherwise,
disassemble SIZE instructions after FROM. */
void (*to_insn_history_from) (struct target_ops *,
- ULONGEST from, int size, int flags);
+ ULONGEST from, int size, int flags)
+ TARGET_DEFAULT_NORETURN (tcomplain ());
/* Disassemble a section of the recorded execution trace from instruction
BEGIN (inclusive) to instruction END (inclusive). */