diff options
| author | Michael Snyder <msnyder@vmware.com> | 2002-01-08 02:09:31 +0000 |
|---|---|---|
| committer | Michael Snyder <msnyder@vmware.com> | 2002-01-08 02:09:31 +0000 |
| commit | 34c0bd933de019af43d6c8fe0bb7bdf87442eaa9 (patch) | |
| tree | 5dcae8fc9fb820641aa4316a71c8661fa53cfc25 /gdb | |
| parent | d33fc4e447bc1a277ab1e49b7a7d39e07f01f33e (diff) | |
| download | gdb-34c0bd933de019af43d6c8fe0bb7bdf87442eaa9.zip gdb-34c0bd933de019af43d6c8fe0bb7bdf87442eaa9.tar.gz gdb-34c0bd933de019af43d6c8fe0bb7bdf87442eaa9.tar.bz2 | |
2002-01-07 Michael Snyder <msnyder@redhat.com>
* cp-valprint.c (cp_print_value): FIXME comment, alloca size.
* p-valprint.c (pascal_object_print_value): Ditto.
* somread.c (som_symtab_read): Ditto.
* symfile.c (simple_free_overlay_region_table): Ditto.
* valops.c (value_assign): Ditto.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/ChangeLog | 6 | ||||
| -rw-r--r-- | gdb/cp-valprint.c | 1 | ||||
| -rw-r--r-- | gdb/p-valprint.c | 1 | ||||
| -rw-r--r-- | gdb/somread.c | 2 | ||||
| -rw-r--r-- | gdb/symfile.c | 1 | ||||
| -rw-r--r-- | gdb/valops.c | 1 |
6 files changed, 12 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 1ab3eb4..b1f4539 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,11 @@ 2002-01-07 Michael Snyder <msnyder@redhat.com> + * cp-valprint.c (cp_print_value): FIXME comment, alloca size. + * p-valprint.c (pascal_object_print_value): Ditto. + * somread.c (som_symtab_read): Ditto. + * symfile.c (simple_free_overlay_region_table): Ditto. + * valops.c (value_assign): Ditto. + * tracepoint.c (tracepoint_save_command): From Klee Dienes -- use tilde_expand and strerror for opening save-tracepoints file. diff --git a/gdb/cp-valprint.c b/gdb/cp-valprint.c index 567e0ab..66920312 100644 --- a/gdb/cp-valprint.c +++ b/gdb/cp-valprint.c @@ -570,6 +570,7 @@ cp_print_value (struct type *type, struct type *real_type, char *valaddr, && ((boffset + offset) < 0 || (boffset + offset) >= TYPE_LENGTH (type))) { + /* FIXME (alloca): unsafe if baseclass is really really large. */ base_valaddr = (char *) alloca (TYPE_LENGTH (baseclass)); if (target_read_memory (address + offset + boffset, base_valaddr, TYPE_LENGTH (baseclass)) != 0) diff --git a/gdb/p-valprint.c b/gdb/p-valprint.c index 08a862e..0b89c72 100644 --- a/gdb/p-valprint.c +++ b/gdb/p-valprint.c @@ -970,6 +970,7 @@ pascal_object_print_value (struct type *type, char *valaddr, CORE_ADDR address, if (boffset != -1 && (boffset < 0 || boffset >= TYPE_LENGTH (type))) { + /* FIXME (alloc): not safe is baseclass is really really big. */ base_valaddr = (char *) alloca (TYPE_LENGTH (baseclass)); if (target_read_memory (address + boffset, base_valaddr, TYPE_LENGTH (baseclass)) != 0) diff --git a/gdb/somread.c b/gdb/somread.c index aba3323..bab25d4 100644 --- a/gdb/somread.c +++ b/gdb/somread.c @@ -99,12 +99,14 @@ som_symtab_read (bfd *abfd, struct objfile *objfile, number_of_symbols = bfd_get_symcount (abfd); + /* FIXME (alloca): could be quite large. */ buf = alloca (symsize * number_of_symbols); bfd_seek (abfd, obj_som_sym_filepos (abfd), SEEK_SET); val = bfd_bread (buf, symsize * number_of_symbols, abfd); if (val != symsize * number_of_symbols) error ("Couldn't read symbol dictionary!"); + /* FIXME (alloca): could be quite large. */ stringtab = alloca (obj_som_stringtab_size (abfd)); bfd_seek (abfd, obj_som_str_filepos (abfd), SEEK_SET); val = bfd_bread (stringtab, obj_som_stringtab_size (abfd), abfd); diff --git a/gdb/symfile.c b/gdb/symfile.c index d999cf9..c0b9d3e 100644 --- a/gdb/symfile.c +++ b/gdb/symfile.c @@ -3009,6 +3009,7 @@ simple_free_overlay_region_table (void) static void read_target_long_array (CORE_ADDR memaddr, unsigned int *myaddr, int len) { + /* FIXME (alloca): Not safe if array is very large. */ char *buf = alloca (len * TARGET_LONG_BYTES); int i; diff --git a/gdb/valops.c b/gdb/valops.c index cb30222..f211753 100644 --- a/gdb/valops.c +++ b/gdb/valops.c @@ -697,6 +697,7 @@ value_assign (struct value *toval, struct value *fromval) int amount_copied; /* Make the buffer large enough in all cases. */ + /* FIXME (alloca): Not safe for very large data types. */ char *buffer = (char *) alloca (amount_to_copy + sizeof (LONGEST) + MAX_REGISTER_RAW_SIZE); |