diff options
| author | Simon Marchi <simon.marchi@polymtl.ca> | 2020-07-14 23:18:01 -0400 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@polymtl.ca> | 2020-07-14 23:18:30 -0400 |
| commit | 054a0959265eb89210626b6f2d84b93b82ef7ae9 (patch) | |
| tree | 59b62b08662c42c20e51e262fa327b987c4756a3 /gdb | |
| parent | 360f1cd72da997ff5300db7ce76c8727db046868 (diff) | |
| download | gdb-054a0959265eb89210626b6f2d84b93b82ef7ae9.zip gdb-054a0959265eb89210626b6f2d84b93b82ef7ae9.tar.gz gdb-054a0959265eb89210626b6f2d84b93b82ef7ae9.tar.bz2 | |
gdb/testsuite/lib/dwarf.exp: fix addr_size parameter comments
The comments modified in this patch claim that the addr_size parameters
can take the value 32 or 64 (suggesting the value is in bits). In fact,
the expected value is in bytes, either 4 or 8.
The actual value in the DWARF info is in bytes. And we can see that the
default values used (if addr_size == "default") are:
if {$_cu_addr_size == "default"} {
if {[is_64_target]} {
set _cu_addr_size 8
} else {
set _cu_addr_size 4
}
}
gdb/testsuite/ChangeLog:
* lib/dwarf.exp (Dwarf::cu, Dwarf::tu, Dwarf::lines): Change valid
values in documentation for addr_size to 4 and 8.
Change-Id: I4a02dca2bb7992198864e545ef099f020f54ff2f
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/testsuite/lib/dwarf.exp | 6 |
2 files changed, 8 insertions, 3 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 6126048..4e4ba05 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2020-07-14 Simon Marchi <simon.marchi@polymtl.ca> + + * lib/dwarf.exp (Dwarf::cu, Dwarf::tu, Dwarf::lines): Change valid + values in documentation for addr_size to 4 and 8. + 2020-07-14 Andrew Burgess <andrew.burgess@embecosm.com> * gdb.arch/amd64-osabi.exp: Update. diff --git a/gdb/testsuite/lib/dwarf.exp b/gdb/testsuite/lib/dwarf.exp index a7dbe25..5febc75 100644 --- a/gdb/testsuite/lib/dwarf.exp +++ b/gdb/testsuite/lib/dwarf.exp @@ -1026,7 +1026,7 @@ namespace eval Dwarf { # default = 0 (32-bit) # version n - DWARF version number to emit # default = 4 - # addr_size n - the size of addresses, 32, 64, or default + # addr_size n - the size of addresses in bytes: 4, 8, or default # default = default # fission 0|1 - boolean indicating if generating Fission debug info # default = 0 @@ -1117,7 +1117,7 @@ namespace eval Dwarf { # default = 0 (32-bit) # version n - DWARF version number to emit # default = 4 - # addr_size n - the size of addresses, 32, 64, or default + # addr_size n - the size of addresses in bytes: 4, 8, or default # default = default # fission 0|1 - boolean indicating if generating Fission debug info # default = 0 @@ -1298,7 +1298,7 @@ namespace eval Dwarf { # default = 0 (32-bit) # version n - DWARF version number to emit # default = 4 - # addr_size n - the size of addresses, 32, 64, or default + # addr_size n - the size of addresses in bytes: 4, 8, or default # default = default # # LABEL is the label of the current unit (which is probably |