diff options
| author | Tom Tromey <tom@tromey.com> | 2018-04-05 16:09:29 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2018-05-04 22:04:46 -0600 |
| commit | e3829d13f6d0615f663d2a85ef4281a4365a947c (patch) | |
| tree | 012878c439bca11999404bb2a1e24c7efd886403 /gdb | |
| parent | da0e15638de59238ad811cdc3cc1d1a7803829c7 (diff) | |
| download | gdb-e3829d13f6d0615f663d2a85ef4281a4365a947c.zip gdb-e3829d13f6d0615f663d2a85ef4281a4365a947c.tar.gz gdb-e3829d13f6d0615f663d2a85ef4281a4365a947c.tar.bz2 | |
Add two fall-through comments in rs6000-tdep.c
This adds two fall-through comments in rs6000-tdep.c. I looked at the
PPC instruction manual and convinced myself that this was correct.
And, this isn't a semantic change. However, close review would still
be good.
2018-05-04 Tom Tromey <tom@tromey.com>
* rs6000-tdep.c (ppc_process_record_op4)
(ppc_process_record_op63): Add fall-through comment.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/rs6000-tdep.c | 2 |
2 files changed, 7 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index aad7830..c0deadf 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2018-05-04 Tom Tromey <tom@tromey.com> + * rs6000-tdep.c (ppc_process_record_op4) + (ppc_process_record_op63): Add fall-through comment. + +2018-05-04 Tom Tromey <tom@tromey.com> + * i386-tdep.c (i386_process_record): Add fall-through comment. 2018-05-04 Tom Tromey <tom@tromey.com> diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c index 425c41d..c5b49c5 100644 --- a/gdb/rs6000-tdep.c +++ b/gdb/rs6000-tdep.c @@ -3969,6 +3969,7 @@ ppc_process_record_op4 (struct gdbarch *gdbarch, struct regcache *regcache, && vra != 7 /* Decimal Convert From National */ && vra != 31) /* Decimal Set Sign */ break; + /* Fall through. */ /* 5.16 Decimal Integer Arithmetic Instructions */ case 1: /* Decimal Add Modulo */ case 65: /* Decimal Subtract Modulo */ @@ -5565,6 +5566,7 @@ ppc_process_record_op63 (struct gdbarch *gdbarch, struct regcache *regcache, case 22: /* Move From FPSCR Control & set RN */ case 23: /* Move From FPSCR Control & set RN Immediate */ record_full_arch_list_add_reg (regcache, tdep->ppc_fpscr_regnum); + /* Fall through. */ case 0: /* Move From FPSCR */ case 24: /* Move From FPSCR Lightweight */ if (PPC_FIELD (insn, 11, 5) == 0 && PPC_RC (insn)) |