diff options
| author | Tom de Vries <tdevries@suse.de> | 2020-07-23 13:45:46 +0200 |
|---|---|---|
| committer | Tom de Vries <tdevries@suse.de> | 2020-07-23 13:45:46 +0200 |
| commit | 90fcc46681979a7759d16e738a98c9e666e6e88f (patch) | |
| tree | 68acb6ec444ebc7a8e96afb3ac8e3cea8dfca1a1 /gdb | |
| parent | 78344df7b5d7d7fcf6aa7945b8c4b56bcc9388ce (diff) | |
| download | gdb-90fcc46681979a7759d16e738a98c9e666e6e88f.zip gdb-90fcc46681979a7759d16e738a98c9e666e6e88f.tar.gz gdb-90fcc46681979a7759d16e738a98c9e666e6e88f.tar.bz2 | |
[gdb/tui] Fix Wmaybe-uninitialized warning in tui-winsource.c
When compiling with CFLAGS/CXXFLAGS="-O0 -g -Wall" and using g++ 11.0.0, we
run into:
...
src/gdb/tui/tui-winsource.c: In function \
'void tui_update_all_breakpoint_info(breakpoint*)':
src/gdb/tui/tui-winsource.c:427:58: warning: '<unknown>' may be used \
uninitialized [-Wmaybe-uninitialized]
427 | for (tui_source_window_base *win : tui_source_windows ())
| ^
In file included from src/gdb/tui/tui-winsource.c:38:
src/gdb/tui/tui-winsource.h:236:30: note: by argument 1 of type \
'const tui_source_windows*' to 'tui_source_window_iterator \
tui_source_windows::begin() const' declared here
236 | tui_source_window_iterator begin () const
| ^~~~~
src/gdb/tui/tui-winsource.c:427:58: note: '<anonymous>' declared here
427 | for (tui_source_window_base *win : tui_source_windows ())
| ^
...
The warning doesn't make sense for an empty struct, PR gcc/96295 has been
filed about that.
For now, work around the warning by defining a default constructor.
Build on x86_64-linux.
gdb/ChangeLog:
2020-07-23 Tom de Vries <tdevries@suse.de>
PR tui/26282
* tui/tui-winsource.h (struct tui_source_windows::tui_source_windows):
New default constructor.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/ChangeLog | 6 | ||||
| -rw-r--r-- | gdb/tui/tui-winsource.h | 5 |
2 files changed, 11 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index c400d23..3703520 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2020-07-23 Tom de Vries <tdevries@suse.de> + + PR tui/26282 + * tui/tui-winsource.h (struct tui_source_windows::tui_source_windows): + New default constructor. + 2020-07-23 Andrew Burgess <andrew.burgess@embecosm.com> * disasm.c (do_mixed_source_and_assembly_deprecated): Don't diff --git a/gdb/tui/tui-winsource.h b/gdb/tui/tui-winsource.h index fab1487..ba9c0fd 100644 --- a/gdb/tui/tui-winsource.h +++ b/gdb/tui/tui-winsource.h @@ -233,6 +233,11 @@ private: struct tui_source_windows { + /* Work around Wmaybe-uninitalized warning with g++ 11.0.0, see also + PR gcc/96295. Note that "tui_source_windows () = default" doesn't work + around the warning. */ + tui_source_windows () {} + tui_source_window_iterator begin () const { return tui_source_window_iterator (tui_windows.begin (), |