aboutsummaryrefslogtreecommitdiff
path: root/gdb
diff options
context:
space:
mode:
authorPedro Alves <palves@redhat.com>2013-04-19 17:48:10 +0000
committerPedro Alves <palves@redhat.com>2013-04-19 17:48:10 +0000
commitc49e7f76afc4507257d66f1c72fabd83c2d6ef18 (patch)
treea4d1e31bd4785bdc87068f40a57d7e01c8a1ae3d /gdb
parent12ff8552b9d6e9adf04d1b0443c9a77e27bf0d82 (diff)
downloadgdb-c49e7f76afc4507257d66f1c72fabd83c2d6ef18.zip
gdb-c49e7f76afc4507257d66f1c72fabd83c2d6ef18.tar.gz
gdb-c49e7f76afc4507257d66f1c72fabd83c2d6ef18.tar.bz2
Make GDB -Wpointer-sign clean on MinGW too.
This is the remaining issue impeding GDB to build with "-Wpointer-sign -Werror" with Fedora 17's i686-w64-mingw32 cross toolchain. ../../src/gdb/ser-tcp.c: In function 'net_read_prim': ../../src/gdb/ser-tcp.c:341:3: error: pointer targets in passing argument 2 of 'recv' differ in signedness [-Werror=pointer-sign] In file included from ../../src/gdb/serial.h:23:0, from ../../src/gdb/ser-tcp.c:21: /usr/i686-w64-mingw32/sys-root/mingw/include/winsock2.h:983:34: note: expected 'char *' but argument is of type 'unsigned char *' gdb/ 2013-04-19 Pedro Alves <palves@redhat.com> * ser-tcp.c (net_read_prim): Cast second argument to recv to 'void *'.
Diffstat (limited to 'gdb')
-rw-r--r--gdb/ChangeLog5
-rw-r--r--gdb/ser-tcp.c5
2 files changed, 9 insertions, 1 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 178ee2b..e795950 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2013-04-19 Pedro Alves <palves@redhat.com>
+ * ser-tcp.c (net_read_prim): Cast second argument to recv to
+ 'void *'.
+
+2013-04-19 Pedro Alves <palves@redhat.com>
+
* monitor.c (monitor_write_memory, monitor_write_memory_bytes):
Change type of 'myaddr' parameter to gdb_byte pointer.
(monitor_write_memory_longlongs): Likewise. Cast 'myaddr' pointer
diff --git a/gdb/ser-tcp.c b/gdb/ser-tcp.c
index e4fbf26..75c8b76 100644
--- a/gdb/ser-tcp.c
+++ b/gdb/ser-tcp.c
@@ -338,7 +338,10 @@ net_close (struct serial *scb)
int
net_read_prim (struct serial *scb, size_t count)
{
- return recv (scb->fd, scb->buf, count, 0);
+ /* Need to cast to silence -Wpointer-sign on MinGW, as Winsock's
+ 'recv' takes 'char *' as second argument, while 'scb->buf' is
+ 'unsigned char *'. */
+ return recv (scb->fd, (void *) scb->buf, count, 0);
}
int