diff options
author | Keith Seitz <keiths@redhat.com> | 2012-07-30 17:45:37 +0000 |
---|---|---|
committer | Keith Seitz <keiths@redhat.com> | 2012-07-30 17:45:37 +0000 |
commit | eff9c3e636220ad8610d42d696a36a3a3f68dbfb (patch) | |
tree | 6d94700755fab78635e6364def8d66618d780fab /gdb | |
parent | 728400d7698631b5f58f222c1506a2e30ca2aa2d (diff) | |
download | gdb-eff9c3e636220ad8610d42d696a36a3a3f68dbfb.zip gdb-eff9c3e636220ad8610d42d696a36a3a3f68dbfb.tar.gz gdb-eff9c3e636220ad8610d42d696a36a3a3f68dbfb.tar.bz2 |
* linespec.c (linespec_lex_number): A number followed
by quotes is a valid number, too.
* gdb.linespec/ls-errs.exp: Check some quote-enclosed
linespecs.
Diffstat (limited to 'gdb')
-rw-r--r-- | gdb/ChangeLog | 5 | ||||
-rw-r--r-- | gdb/linespec.c | 5 | ||||
-rw-r--r-- | gdb/testsuite/gdb.linespec/ls-errs.exp | 2 |
3 files changed, 10 insertions, 2 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 00411df..3bc3450 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2012-07-30 Keith Seitz <keiths@redhat.com> + + * linespec.c (linespec_lex_number): A number followed + by quotes is a valid number, too. + 2012-07-30 Tom Tromey <tromey@redhat.com> * remote-sim.c (gdb_os_poll_quit): Don't check immediate_quit. diff --git a/gdb/linespec.c b/gdb/linespec.c index 3d7f62f..51994c8 100644 --- a/gdb/linespec.c +++ b/gdb/linespec.c @@ -391,10 +391,11 @@ linespec_lexer_lex_number (linespec_parser *parser, linespec_token *tokenp) } /* If the next character in the input buffer is not a space, comma, - or colon, this input does not represent a number. */ + quote, or colon, this input does not represent a number. */ if (*PARSER_STREAM (parser) != '\0' && !isspace (*PARSER_STREAM (parser)) && *PARSER_STREAM (parser) != ',' - && *PARSER_STREAM (parser) != ':') + && *PARSER_STREAM (parser) != ':' + && !strchr (linespec_quote_characters, *PARSER_STREAM (parser))) { PARSER_STREAM (parser) = LS_TOKEN_STOKEN (*tokenp).ptr; return 0; diff --git a/gdb/testsuite/gdb.linespec/ls-errs.exp b/gdb/testsuite/gdb.linespec/ls-errs.exp index 7db8ae4..5668397 100644 --- a/gdb/testsuite/gdb.linespec/ls-errs.exp +++ b/gdb/testsuite/gdb.linespec/ls-errs.exp @@ -146,6 +146,8 @@ add the_tests "$srcfile:3 foo" unexpected_opt "string" "foo" foreach x $invalid_offsets { add the_tests "$srcfile:$x" invalid_offset_f $x $srcfile + add the_tests "\"$srcfile:$x\"" invalid_offset_f $x $srcfile + add the_tests "'$srcfile:$x'" invalid_offset_f $x $srcfile } # Test invalid filespecs starting with function. |