diff options
| author | Jim Kingdon <jkingdon@engr.sgi.com> | 1993-04-07 22:45:34 +0000 |
|---|---|---|
| committer | Jim Kingdon <jkingdon@engr.sgi.com> | 1993-04-07 22:45:34 +0000 |
| commit | ef5b809c7c731d525f53f2963c2d186bb37621f9 (patch) | |
| tree | 493e8ed3530da2d346f1f4451c8a12f1635d00dc /gdb | |
| parent | 8a177da6582bc176c0dd3b58583c8096674ea853 (diff) | |
| download | gdb-ef5b809c7c731d525f53f2963c2d186bb37621f9.zip gdb-ef5b809c7c731d525f53f2963c2d186bb37621f9.tar.gz gdb-ef5b809c7c731d525f53f2963c2d186bb37621f9.tar.bz2 | |
* xcoffread.c (struct coff_symbol): Change c_sclass to unsigned char.
Remove FIXME comment regarding this.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/ChangeLog | 25 | ||||
| -rw-r--r-- | gdb/xcoffread.c | 10 |
2 files changed, 5 insertions, 30 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 0040362..18868a7 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,27 +1,8 @@ -Tue Apr 6 00:24:32 1993 Per Bothner (bothner@rtl.cygnus.com) - - * ch-exp.y: Remove ambiguities. Fix or add support for - UNOP_IND, UNOP_CAST, UNOP_ADDR, STRUCOP_STRUCT, OP_TYPE. - * ch-typeprint.c (chill_print_type): Move support - for TYPE_CODE_ARRAY and TYPE_CODE_STRING from here ... - * ch-typeprint.c (chill_type_print_base): ... here. - * ch-typeprint.c (chill_type_print_base): Improve - support for PTR, REF, and FUNC types. - * ch-valprint.c: Prefer H'%x format to 0x%s. - * ch-valprint.c (chill_val_print): Add support for printing - TYPE_CODE_REF (return for LOC parameters and variables). - Use c_val_print to print random types (including ENUM). - * ch-valprint,c (chill_print_value_fields): Make - output look more like Chill tuples. - * stabsread.c (read_struct_type): Factor common code. - -Wed Apr 7 11:22:43 1993 Fred Fish (fnf@cygnus.com) - - * sparclite/Makefile.in: Add dummy mostlyclean, clean, - distclean, and realclean targets. - Wed Apr 7 10:11:22 1993 Jim Kingdon (kingdon@cygnus.com) + * xcoffread.c (struct coff_symbol): Change c_sclass to unsigned char. + Remove FIXME comment regarding this. + * symfile.h: Change NULL->'\0' in comment (that wasn't a typo). * xcoffread.c (read_xcoff_symtab): Use E_SYMNMLEN. diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c index 6d1606b..a8f9e7c 100644 --- a/gdb/xcoffread.c +++ b/gdb/xcoffread.c @@ -73,7 +73,7 @@ struct coff_symbol { int c_symnum; /* symbol number of this entry */ int c_nsyms; /* 0 if syment only, 1 if syment + auxent */ long c_value; - int c_sclass; + unsigned char c_sclass; int c_secnum; unsigned int c_type; }; @@ -1083,13 +1083,7 @@ read_xcoff_symtab (objfile, nsyms) symname_alloced = 1; } cs->c_value = symbol->n_value; - /* n_sclass is signed (FIXME), so we had better not mask off any - high bits it contains, since the values we will be comparing - it to are also signed (FIXME). Defined in <coff/internal.h>. - At this point (3Jun92, gnu@cygnus.com) I think the fix is to - make the fields and values unsigned chars, but changing the next - line is a simple patch late in the release cycle, for now. */ - cs->c_sclass = symbol->n_sclass /* & 0xff */; + cs->c_sclass = symbol->n_sclass; cs->c_secnum = symbol->n_scnum; cs->c_type = (unsigned)symbol->n_type; |