diff options
author | nobody <> | 2006-05-01 19:36:28 +0000 |
---|---|---|
committer | nobody <> | 2006-05-01 19:36:28 +0000 |
commit | 4b5eb65210b3b44b4f0ea8c7a95a16f199fbd057 (patch) | |
tree | e5dbcf020020ebfd3dc5fb6e160924e5f19ae4df /gdb | |
parent | 49b5a1f5dc74a0e693a51409252b3d590cc00bbb (diff) | |
download | gdb-4b5eb65210b3b44b4f0ea8c7a95a16f199fbd057.zip gdb-4b5eb65210b3b44b4f0ea8c7a95a16f199fbd057.tar.gz gdb-4b5eb65210b3b44b4f0ea8c7a95a16f199fbd057.tar.bz2 |
This commit was manufactured by cvs2svn to create branch 'msnyder-msnyder-reverse-20060502-branchpoint
reverse-20060502-branch'.
Sprout from readline_5_1-import-branch 2006-04-20 20:13:22 UTC nobody 'This commit was manufactured by cvs2svn to create branch 'readline_5_1'
Cherrypick from master 2006-05-01 19:36:27 UTC DJ Delorie <dj@redhat.com> '* bfd-in.h (bfd_hash_table): Add count field.':
bfd/ChangeLog
bfd/bfd-in.h
bfd/bfd-in2.h
bfd/coff-rs6000.c
bfd/elf.c
bfd/elf32-arm.c
bfd/elfxx-target.h
bfd/hash.c
bfd/libbfd-in.h
bfd/libbfd.h
bfd/opncls.c
bfd/tekhex.c
bfd/version.h
gdb/ChangeLog
gdb/MAINTAINERS
gdb/Makefile.in
gdb/NEWS
gdb/breakpoint.c
gdb/config/m32c/m32c.mt
gdb/configure.tgt
gdb/doc/ChangeLog
gdb/doc/gdb.texinfo
gdb/doc/gdbint.texinfo
gdb/dwarf2read.c
gdb/linux-fork.c
gdb/m32c-tdep.c
gdb/mingw-hdep.c
gdb/mips-mdebug-tdep.c
gdb/ppcnbsd-tdep.c
gdb/remote.c
gdb/rs6000-tdep.c
gdb/ser-mingw.c
gdb/serial.c
gdb/serial.h
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.asm/asm-source.exp
gdb/testsuite/gdb.asm/m32c.inc
gdb/testsuite/gdb.base/multi-forks.exp
gdb/testsuite/gdb.base/sigbpt.exp
gdb/testsuite/gdb.base/siginfo.exp
gdb/testsuite/gdb.base/sigstep.exp
gdb/version.in
include/ChangeLog
include/opcode/ChangeLog
include/opcode/arm.h
include/opcode/mips.h
libiberty/ChangeLog
libiberty/floatformat.c
opcodes/ChangeLog
opcodes/arm-dis.c
opcodes/m68k-dis.c
opcodes/mips-dis.c
opcodes/mips-opc.c
sim/ppc/ChangeLog
sim/ppc/Makefile.in
Delete:
readline/examples/rlfe/ChangeLog
readline/examples/rlfe/Makefile.in
readline/examples/rlfe/README
readline/examples/rlfe/config.h.in
readline/examples/rlfe/configure
readline/examples/rlfe/configure.in
readline/examples/rlfe/extern.h
readline/examples/rlfe/os.h
readline/examples/rlfe/pty.c
readline/examples/rlfe/rlfe.c
readline/examples/rlfe/screen.h
sim/testsuite/sim/cris/hw/rv-n-cris/host1.ms
sim/testsuite/sim/cris/hw/rv-n-cris/irq1.ms
sim/testsuite/sim/cris/hw/rv-n-cris/irq2.ms
sim/testsuite/sim/cris/hw/rv-n-cris/irq3.ms
sim/testsuite/sim/cris/hw/rv-n-cris/irq4.ms
sim/testsuite/sim/cris/hw/rv-n-cris/irq5.ms
sim/testsuite/sim/cris/hw/rv-n-cris/irq6.ms
sim/testsuite/sim/cris/hw/rv-n-cris/mbox1.ms
sim/testsuite/sim/cris/hw/rv-n-cris/mem1.ms
sim/testsuite/sim/cris/hw/rv-n-cris/mem2.ms
sim/testsuite/sim/cris/hw/rv-n-cris/poll1.ms
sim/testsuite/sim/cris/hw/rv-n-cris/quit.s
sim/testsuite/sim/cris/hw/rv-n-cris/rvc.exp
sim/testsuite/sim/cris/hw/rv-n-cris/std.dev
sim/testsuite/sim/cris/hw/rv-n-cris/testutils.inc
sim/testsuite/sim/cris/hw/rv-n-cris/trivial1.ms
sim/testsuite/sim/cris/hw/rv-n-cris/trivial2.ms
sim/testsuite/sim/cris/hw/rv-n-cris/trivial3.ms
sim/testsuite/sim/cris/hw/rv-n-cris/trivial4.ms
sim/testsuite/sim/cris/hw/rv-n-cris/trivial4.r
sim/testsuite/sim/cris/hw/rv-n-cris/trivial5.ms
sim/testsuite/sim/cris/hw/rv-n-cris/wd1.ms
Diffstat (limited to 'gdb')
-rw-r--r-- | gdb/ChangeLog | 101 | ||||
-rw-r--r-- | gdb/MAINTAINERS | 3 | ||||
-rw-r--r-- | gdb/Makefile.in | 9 | ||||
-rw-r--r-- | gdb/NEWS | 6 | ||||
-rw-r--r-- | gdb/breakpoint.c | 2 | ||||
-rw-r--r-- | gdb/config/m32c/m32c.mt | 7 | ||||
-rw-r--r-- | gdb/configure.tgt | 2 | ||||
-rw-r--r-- | gdb/doc/ChangeLog | 9 | ||||
-rw-r--r-- | gdb/doc/gdb.texinfo | 23 | ||||
-rw-r--r-- | gdb/doc/gdbint.texinfo | 56 | ||||
-rw-r--r-- | gdb/dwarf2read.c | 61 | ||||
-rw-r--r-- | gdb/linux-fork.c | 25 | ||||
-rw-r--r-- | gdb/m32c-tdep.c | 2552 | ||||
-rw-r--r-- | gdb/mingw-hdep.c | 10 | ||||
-rw-r--r-- | gdb/mips-mdebug-tdep.c | 2 | ||||
-rw-r--r-- | gdb/ppcnbsd-tdep.c | 4 | ||||
-rw-r--r-- | gdb/remote.c | 2 | ||||
-rw-r--r-- | gdb/rs6000-tdep.c | 1 | ||||
-rw-r--r-- | gdb/ser-mingw.c | 516 | ||||
-rw-r--r-- | gdb/serial.c | 7 | ||||
-rw-r--r-- | gdb/serial.h | 4 | ||||
-rw-r--r-- | gdb/testsuite/ChangeLog | 22 | ||||
-rw-r--r-- | gdb/testsuite/gdb.asm/asm-source.exp | 3 | ||||
-rw-r--r-- | gdb/testsuite/gdb.asm/m32c.inc | 33 | ||||
-rw-r--r-- | gdb/testsuite/gdb.base/multi-forks.exp | 41 | ||||
-rw-r--r-- | gdb/testsuite/gdb.base/sigbpt.exp | 4 | ||||
-rw-r--r-- | gdb/testsuite/gdb.base/siginfo.exp | 4 | ||||
-rw-r--r-- | gdb/testsuite/gdb.base/sigstep.exp | 8 | ||||
-rw-r--r-- | gdb/version.in | 2 |
29 files changed, 3343 insertions, 176 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index dcb436b..b2dd5f4 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,104 @@ +2006-04-30 Mark Kettenis <kettenis@gnu.org> + + * breakpoint.c (insert_single_step_breakpoint): Make a failure to + insert a single-step breakpoint an error instead of a warning. + +2006-05-01 Nathan J. Williams <nathanw@wasabisystems.com> + + * ppcnbsd-tdep.c (ppcnbsd_return_value): Change type of last two + arguments from void * to gdb_byte *. + +2006-04-26 Michael Snyder <msnyder@redhat.com> + + * linux-fork.c (_initialize_linux_fork): Rename "delete-fork" + command to "delete fork" (no hyphen), compatible with other + "delete" commands. + (info_forks_command): Accept a fork ID argument, for info + on a single fork. Report if no matching forks. + +2006-04-25 Mark Kettenis <kettenis@gnu.org> + + * breakpoint.c (remove_single_step_breakpoints): Bail out early if + no breakpoints are inserted. + + From Masaki MURANAKA <monaka@monami-software.com>: + * mips-mdebug-tdep.c (mips_mdebug_frame_prev_register): Change + type of last argument to `gdb_byte *' + +2006-04-25 Jim Blandy <jimb@codesourcery.com> + + Add support for 'target remote |' on MinGW. + * ser-mingw.c (struct pipe_state): New structure. + (make_pipe_state, free_pipe_state, cleanup_pipe_state) + (pipe_windows_open, pipe_windows_close, pipe_windows_read) + (pipe_windows_write, pipe_wait_handle): New functions. + (_initialize_ser_windows): Register a "pipe" interface based on + them. + +2006-04-24 Daniel Jacobowitz <dan@codesourcery.com> + + * ser-mingw.c: Include <conio.h>. + (struct ser_console_state, struct net_windows_state): Add exit_select, + have_stopped, thread. + (pipe_select_thread, console_select_thread) + (net_windows_select_thread): Don't create a local state copy or + close stop_select. Exit on exit_select instead of stop_select. Set + have_stopped. + (console_select_thread): Don't report control keypresses as pending + input. + (pipe_select_thread): Allow stop_select to interrupt sleeping. + (set_console_wait_handle): Create exit_select and have_stopped. + Save the thread handle. Check _kbhit before starting a thread. + (ser_console_done_wait_handle): New. + (ser_console_close): Close new handles. Wait for the thread to + exit. + (new_windows_select_thread): Assert that an event occurred. + (net_windows_wait_handle): Check for pending input before starting + a thread. + (net_windows_done_wait_handle): New. + (net_windows_open): Create exit_select and have_stopped. + Save the thread handle. + (net_windows_close): Close new handles. Wait for the thread to + exit. + (_intiialize_ser_windows): Register done_wait_handle methods. + + * serial.c [USE_WIN32API] (serial_done_wait_handle): New. + * serial.h [USE_WIN32API] (struct serial_ops): Add done_wait_handle. + [USE_WIN32API] (serial_done_wait_handle): New prototype. + * mingw-hdep.c (gdb_select): Use serial_done_wait_handle. + +2006-04-23 Andreas Schwab <schwab@suse.de> + + * rs6000-tdep.c: Include "reggroups.h" only once. + * Makefile.in (rs6000-tdep.o): Update dependencies. + +2006-04-21 Frederic Riss <frederic.riss@st.com> + + * dwarf2read.c (dwarf2_start_subfile): Change prototype to accept + compilation directory as last argument. + Always pass comp_dir as second argument to start_subfile and prepend + dirname to the filename when necessary. + Remove now superfluous search for pre-existing subfile. + (dwarf_decode_lines): Pass the compilation directory to + dwarf2_start_subfile. + +2006-04-20 Michael Snyder <msnyder@redhat.com> + + * 2006-03-22 Jim Blandy <jimb@redhat.com> + Add support for the Renesas M32C and M16C. + + * configure.tgt (m32c-*-*): New entry. + * config/m32c/m32c.mt: New file. + * m32c-tdep.c: New file. + * Makefile.in (elf_m32c_h): New variable. + (m32c-tdep.o): New rule. + * NEWS: Mention new target. + * MAINTAINERS: Designate Jim Blandy as responsible maintainer. + +2006-04-20 Michael Snyder <msnyder@redhat.com> + + * remote.c: Fix spelling error in comment. + 2006-04-20 Daniel Jacobowitz <dan@codesourcery.com> * m68klinux-tdep.c (m68k_linux_sigtramp_frame_prev_register): diff --git a/gdb/MAINTAINERS b/gdb/MAINTAINERS index dbd2f93..48f8c00 100644 --- a/gdb/MAINTAINERS +++ b/gdb/MAINTAINERS @@ -266,6 +266,9 @@ the native maintainer when resolving ABI issues. ia64 --target=ia64-linux-gnu ,-Werror (--target=ia64-elf broken) + m32c --target=m32c-elf ,-Werror + Jim Blandy, jimb@codesourcery.com + m32r --target=m32r-elf ,-Werror m68hc11 --target=m68hc11-elf ,-Werror , diff --git a/gdb/Makefile.in b/gdb/Makefile.in index beab57c..e27a718 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -582,6 +582,7 @@ elf_sh_h = $(INCLUDE_DIR)/elf/sh.h elf_arm_h = $(INCLUDE_DIR)/elf/arm.h $(elf_reloc_macros_h) elf_bfd_h = $(BFD_SRC)/elf-bfd.h elf_frv_h = $(INCLUDE_DIR)/elf/frv.h $(elf_reloc_macros_h) +elf_m32c_h = $(INCLUDE_DIR)/elf/m32c.h $(elf_reloc_macros_h) libaout_h = $(BFD_SRC)/libaout.h libiberty_h = $(INCLUDE_DIR)/libiberty.h libbfd_h = $(BFD_SRC)/libbfd.h @@ -598,6 +599,7 @@ gdb_callback_h = $(INCLUDE_DIR)/gdb/callback.h gdb_sim_arm_h = $(INCLUDE_DIR)/gdb/sim-arm.h gdb_sim_d10v_h = $(INCLUDE_DIR)/gdb/sim-d10v.h gdb_sim_frv_h = $(INCLUDE_DIR)/gdb/sim-frv.h +gdb_sim_m32c_h = $(INCLUDE_DIR)/gdb/sim-m32c.h gdb_sim_ppc_h = $(INCLUDE_DIR)/gdb/sim-ppc.h gdb_sim_sh_h = $(INCLUDE_DIR)/gdb/sim-sh.h splay_tree_h = $(INCLUDE_DIR)/splay-tree.h @@ -2215,6 +2217,11 @@ m2-typeprint.o: m2-typeprint.c $(defs_h) $(bfd_h) $(symtab_h) $(gdbtypes_h) \ $(expression_h) $(value_h) $(gdbcore_h) $(target_h) $(m2_lang_h) m2-valprint.o: m2-valprint.c $(defs_h) $(symtab_h) $(gdbtypes_h) \ $(m2_lang_h) $(c_lang_h) +m32c-tdep.o: m32c-tdep.c $(defs_h) $(gdb_assert_h) $(elf_bfd_h) \ + $(elf_m32c_h) $(gdb_sim_m32c_h) $(dis_asm_h) $(gdbtypes_h) \ + $(regcache_h) $(arch_utils_h) $(frame_h) $(frame_unwind_h) \ + $(dwarf2_frame_h) $(dwarf2expr_h) $(symtab_h) $(gdbcore_h) \ + $(value_h) $(reggroups_h) $(prologue_value_h) $(target_h) m32r-linux-nat.o: m32r-linux-nat.c $(defs_h) $(inferior_h) $(gdbcore_h) \ $(regcache_h) $(linux_nat_h) $(gdb_assert_h) $(gdb_string_h) \ $(gregset_h) $(m32r_tdep_h) $(target_h) @@ -2508,7 +2515,7 @@ rs6000-tdep.o: rs6000-tdep.c $(defs_h) $(frame_h) $(inferior_h) $(symtab_h) \ $(reggroups_h) $(libbfd_h) $(coff_internal_h) $(libcoff_h) \ $(coff_xcoff_h) $(libxcoff_h) $(elf_bfd_h) $(solib_svr4_h) \ $(ppc_tdep_h) $(gdb_assert_h) $(dis_asm_h) $(trad_frame_h) \ - $(frame_unwind_h) $(frame_base_h) $(reggroups_h) $(rs6000_tdep_h) + $(frame_unwind_h) $(frame_base_h) $(rs6000_tdep_h) rs6000-aix-tdep.o: rs6000-aix-tdep.c $(defs_h) $(osabi_h) $(rs6000_tdep_h) s390-nat.o: s390-nat.c $(defs_h) $(tm_h) $(regcache_h) $(inferior_h) \ $(s390_tdep_h) $(target_h) $(linux_nat_h) @@ -3,6 +3,12 @@ *** Changes since GDB 6.4 +* New targets + +Renesas M32C/M16C m32c-elf + +Morpho Technologies ms1 ms1-elf + * New commands init-if-undefined Initialize a convenience variable, but diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 130b684..fd231de 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -7717,7 +7717,7 @@ insert_single_step_breakpoint (CORE_ADDR next_pc) *bpt_p = deprecated_insert_raw_breakpoint (next_pc); if (*bpt_p == NULL) - warning (_("Could not insert single-step breakpoint at 0x%s"), + error (_("Could not insert single-step breakpoint at 0x%s"), paddr_nz (next_pc)); } diff --git a/gdb/config/m32c/m32c.mt b/gdb/config/m32c/m32c.mt new file mode 100644 index 0000000..2a404d4 --- /dev/null +++ b/gdb/config/m32c/m32c.mt @@ -0,0 +1,7 @@ +# Target: Renesas M32C family +TDEPFILES = m32c-tdep.o prologue-value.o + +# There may also be a SID / CGEN simulator for this, but we do have DJ +# Delorie's mini-sim. +SIM_OBS = remote-sim.o +SIM = ../sim/m32c/libsim.a diff --git a/gdb/configure.tgt b/gdb/configure.tgt index 4092fe1..f6e1ad8 100644 --- a/gdb/configure.tgt +++ b/gdb/configure.tgt @@ -107,6 +107,8 @@ ia64*-*-*) gdb_target=ia64 ;; iq2000-*-*) gdb_target=iq2000 ;; +m32c-*-*) gdb_target=m32c ;; + m32r*-*-linux*) gdb_target=linux ;; m32r*-*-*) gdb_target=m32r ;; diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog index 66ff9d7..dc5f4f1 100644 --- a/gdb/doc/ChangeLog +++ b/gdb/doc/ChangeLog @@ -1,3 +1,12 @@ +2006-04-27 Michael Snyder <msnyder@redhat.com> + + * gdb.texinfo (delete-fork): Command renamed to "delete fork". + +2006-04-22 Andrew Cagney <cagney@redhat.com> + + * gdb.texinfo (Contributors): Credit frame unwinder contributors. + * gdbint.texinfo (Algorithms): Fix errors in frame documentation. + 2006-04-18 Daniel Jacobowitz <dan@codesourcery.com> * gdbint.texinfo (x86 Watchpoints, Target Conditionals): Update insert diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 790c58d..3230dcb 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -484,6 +484,19 @@ Sakamoto, Yoshinori Sato, Michael Snyder, Andreas Schwab, Jason Thorpe, Corinna Vinschen, Ulrich Weigand, and Elena Zannoni, helped with the migration of old architectures to this new framework. +Andrew Cagney completely re-designed and re-implemented @value{GDBN}'s +unwinder framework, this consisting of a fresh new design featuring +frame IDs, independent frame sniffers, and the sentinel frame. Mark +Kettenis implemented the @sc{dwarf 2} unwinder, Jeff Johnston the +libunwind unwinder, and Andrew Cagney the dummy, sentinel, tramp, and +trad unwinders. The architecture specific changes, each involving a +complete rewrite of the architecture's frame code, were carried out by +Jim Blandy, Joel Brobecker, Kevin Buettner, Andrew Cagney, Stephane +Carrez, Randolph Chung, Orjan Friberg, Richard Henderson, Daniel +Jacobowitz, Jeff Johnston, Mark Kettenis, Theodore A. Roth, Kei +Sakamoto, Yoshinori Sato, Michael Snyder, Corinna Vinschen, and Ulrich +Weigand. + @node Sample Session @chapter A Sample @value{GDBN} Session @@ -2563,7 +2576,7 @@ as shown in the first field of the @samp{info forks} display. To quit debugging one of the forked processes, you can either detach from it by using the @w{@code{detach-fork}} command (allowing it to run independently), or delete (and kill) it using the -@w{@code{delete-fork}} command. +@w{@code{delete fork}} command. @table @code @kindex detach-fork @var{fork-id} @@ -2572,8 +2585,8 @@ Detach from the process identified by @value{GDBN} fork number @var{fork-id}, and remove it from the fork list. The process will be allowed to run independently. -@kindex delete-fork @var{fork-id} -@item delete-fork @var{fork-id} +@kindex delete fork @var{fork-id} +@item delete fork @var{fork-id} Kill the process identified by @value{GDBN} fork number @var{fork-id}, and remove it from the fork list. @@ -2662,8 +2675,8 @@ are not affected by restoring a checkpoint. In general, a checkpoint only restores things that reside in the program being debugged, not in the debugger. -@kindex delete-checkpoint @var{checkpoint-id} -@item delete-checkpoint @var{checkpoint-id} +@kindex delete checkpoint @var{checkpoint-id} +@item delete checkpoint @var{checkpoint-id} Delete the previously-saved checkpoint identified by @var{checkpoint-id}. @end table diff --git a/gdb/doc/gdbint.texinfo b/gdb/doc/gdbint.texinfo index e1d1557..7bbd417 100644 --- a/gdb/doc/gdbint.texinfo +++ b/gdb/doc/gdbint.texinfo @@ -232,25 +232,21 @@ A frame is a construct that @value{GDBN} uses to keep track of calling and called functions. @cindex frame, unwind -@value{GDBN}'s current frame model is the result of an incremental -cleanup of working code, not a fresh design, so it's a little weird. - -The natural model would have a frame object, with methods that read -and write that frame's registers. Reading or writing the youngest -frame's registers would simply read or write the processor's current -registers, since the youngest frame is running directly on the -processor. Older frames might have some registers saved on the stack -by younger frames, so accessing the older frames' registers would do a -mix of memory accesses and register accesses, as appropriate. +@value{GDBN}'s frame model, a fresh design, was implemented with the +need to support @sc{dwarf}'s Call Frame Information in mind. In fact, +the term ``unwind'' is taken directly from that specification. +Developers wishing to learn more about unwinders, are encouraged to +read the the @sc{dwarf} specification. @findex frame_register_unwind -Instead, @value{GDBN}'s model is that you find a frame's registers by -``unwinding'' them from the next younger frame. That is, to access -the registers of frame #1 (the next-to-youngest frame), you actually -apply @code{frame_register_unwind} to frame #0 (the youngest frame). -But then the obvious question is: how do you access the registers of -the youngest frame itself? How do you ``unwind'' them when they're -not wound up? +@findex get_frame_register +@value{GDBN}'s model is that you find a frame's registers by +``unwinding'' them from the next younger frame. That is, +@samp{get_frame_register} which returns the value of a register in +frame #1 (the next-to-youngest frame), is implemented by calling frame +#0's @code{frame_register_unwind} (the youngest frame). But then the +obvious question is: how do you access the registers of the youngest +frame itself? @cindex sentinel frame @findex get_frame_type @@ -261,32 +257,6 @@ the current values of the youngest real frame's registers. If @var{f} is a sentinel frame, then @code{get_frame_type (@var{f}) == SENTINEL_FRAME}. -@findex create_new_frame -@vindex FRAME_FP -@code{FRAME_FP} in the machine description has no meaning to the -machine-independent part of @value{GDBN}, except that it is used when -setting up a new frame from scratch, as follows: - -@smallexample -create_new_frame (read_register (DEPRECATED_FP_REGNUM), read_pc ())); -@end smallexample - -@cindex frame pointer register -Other than that, all the meaning imparted to @code{DEPRECATED_FP_REGNUM} -is imparted by the machine-dependent code. So, -@code{DEPRECATED_FP_REGNUM} can have any value that is convenient for -the code that creates new frames. (@code{create_new_frame} calls -@code{DEPRECATED_INIT_EXTRA_FRAME_INFO} if it is defined; that is where -you should use the @code{DEPRECATED_FP_REGNUM} value, if your frames are -nonstandard.) - -@cindex frame chain -Given a @value{GDBN} frame, define @code{DEPRECATED_FRAME_CHAIN} to -determine the address of the calling function's frame. This will be -used to create a new @value{GDBN} frame struct, and then -@code{DEPRECATED_INIT_EXTRA_FRAME_INFO} and -@code{DEPRECATED_INIT_FRAME_PC} will be called for the new frame. - @section Prologue Analysis @cindex prologue analysis diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index 6fe9245..32bf163 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -846,7 +846,7 @@ static struct line_header *(dwarf_decode_line_header static void dwarf_decode_lines (struct line_header *, char *, bfd *, struct dwarf2_cu *, struct partial_symtab *); -static void dwarf2_start_subfile (char *, char *); +static void dwarf2_start_subfile (char *, char *, char *); static struct symbol *new_symbol (struct die_info *, struct type *, struct dwarf2_cu *); @@ -6529,13 +6529,12 @@ dwarf_decode_lines (struct line_header *lh, char *comp_dir, bfd *abfd, directory and file name numbers in the statement program are 1-based. */ struct file_entry *fe = &lh->file_names[file - 1]; - char *dir; + char *dir = NULL; if (fe->dir_index) dir = lh->include_dirs[fe->dir_index - 1]; - else - dir = comp_dir; - dwarf2_start_subfile (fe->name, dir); + + dwarf2_start_subfile (fe->name, dir, comp_dir); } /* Decode the table. */ @@ -6627,17 +6626,16 @@ dwarf_decode_lines (struct line_header *lh, char *comp_dir, bfd *abfd, 0-based, but the directory and file name numbers in the statement program are 1-based. */ struct file_entry *fe; - char *dir; + char *dir = NULL; file = read_unsigned_leb128 (abfd, line_ptr, &bytes_read); line_ptr += bytes_read; fe = &lh->file_names[file - 1]; if (fe->dir_index) dir = lh->include_dirs[fe->dir_index - 1]; - else - dir = comp_dir; + if (!decode_for_pst_p) - dwarf2_start_subfile (fe->name, dir); + dwarf2_start_subfile (fe->name, dir, comp_dir); } break; case DW_LNS_set_column: @@ -6717,7 +6715,8 @@ dwarf_decode_lines (struct line_header *lh, char *comp_dir, bfd *abfd, /* Start a subfile for DWARF. FILENAME is the name of the file and DIRNAME the name of the source directory which contains FILENAME - or NULL if not known. + or NULL if not known. COMP_DIR is the compilation directory for the + linetable's compilation unit or NULL if not known. This routine tries to keep line numbers from identical absolute and relative file names in a common subfile. @@ -6733,31 +6732,35 @@ dwarf_decode_lines (struct line_header *lh, char *comp_dir, bfd *abfd, files.files[1].dir: /srcdir The line number information for list0.c has to end up in a single - subfile, so that `break /srcdir/list0.c:1' works as expected. */ + subfile, so that `break /srcdir/list0.c:1' works as expected. + start_subfile will ensure that this happens provided that we pass the + concatenation of files.files[1].dir and files.files[1].name as the + subfile's name. */ static void -dwarf2_start_subfile (char *filename, char *dirname) +dwarf2_start_subfile (char *filename, char *dirname, char *comp_dir) { - /* If the filename isn't absolute, try to match an existing subfile - with the full pathname. */ + char *fullname; + + /* While reading the DIEs, we call start_symtab(DW_AT_name, DW_AT_comp_dir). + `start_symtab' will always pass the contents of DW_AT_comp_dir as + second argument to start_subfile. To be consistent, we do the + same here. In order not to lose the line information directory, + we concatenate it to the filename when it makes sense. + Note that the Dwarf3 standard says (speaking of filenames in line + information): ``The directory index is ignored for file names + that represent full path names''. Thus ignoring dirname in the + `else' branch below isn't an issue. */ if (!IS_ABSOLUTE_PATH (filename) && dirname != NULL) - { - struct subfile *subfile; - char *fullname = concat (dirname, "/", filename, (char *)NULL); + fullname = concat (dirname, SLASH_STRING, filename, (char *)NULL); + else + fullname = filename; - for (subfile = subfiles; subfile; subfile = subfile->next) - { - if (FILENAME_CMP (subfile->name, fullname) == 0) - { - current_subfile = subfile; - xfree (fullname); - return; - } - } - xfree (fullname); - } - start_subfile (filename, dirname); + start_subfile (fullname, comp_dir); + + if (fullname != filename) + xfree (fullname); } static void diff --git a/gdb/linux-fork.c b/gdb/linux-fork.c index bb44682..e96275b 100644 --- a/gdb/linux-fork.c +++ b/gdb/linux-fork.c @@ -448,9 +448,18 @@ info_forks_command (char *arg, int from_tty) struct fork_info *fp; int cur_line; ULONGEST pc; + int requested = -1; + struct fork_info *printed = NULL; + + if (arg && *arg) + requested = (int) parse_and_eval_long (arg); for (fp = fork_list; fp; fp = fp->next) { + if (requested > 0 && fp->num != requested) + continue; + + printed = fp; if (ptid_equal (fp->ptid, inferior_ptid)) { printf_filtered ("* "); @@ -490,6 +499,13 @@ info_forks_command (char *arg, int from_tty) putchar_filtered ('\n'); } + if (printed == NULL) + { + if (requested > 0) + printf_filtered (_("No fork number %d.\n"), requested); + else + printf_filtered (_("No forks.\n")); + } } /* Save/restore mode variable 'detach_fork': @@ -670,11 +686,12 @@ Fork a duplicate process (experimental).")); restart <n>: restore program context from a checkpoint.\n\ Argument 'n' is checkpoint ID, as displayed by 'info checkpoints'.")); - /* Delete-checkpoint command: kill the process and remove it from + /* Delete checkpoint command: kill the process and remove it from fork list. */ - add_com ("delete-checkpoint", class_obscure, delete_fork_command, _("\ -Delete a fork/checkpoint (experimental).")); + add_cmd ("checkpoint", class_obscure, delete_fork_command, _("\ +Delete a fork/checkpoint (experimental)."), + &deletelist); /* Detach-checkpoint command: release the process to run independantly, and remove it from the fork list. */ @@ -691,7 +708,7 @@ Detach from a fork/checkpoint (experimental).")); /* Command aliases (let "fork" and "checkpoint" be used interchangeably). */ - add_com_alias ("delete-fork", "delete-checkpoint", class_obscure, 1); + add_alias_cmd ("fork", "checkpoint", class_obscure, 1, &deletelist); add_com_alias ("detach-fork", "detach-checkpoint", class_obscure, 1); add_info_alias ("forks", "checkpoints", 0); diff --git a/gdb/m32c-tdep.c b/gdb/m32c-tdep.c new file mode 100644 index 0000000..e93a98c --- /dev/null +++ b/gdb/m32c-tdep.c @@ -0,0 +1,2552 @@ +/* Renesas M32C target-dependent code for GDB, the GNU debugger. + + Copyright 2004, 2005 Free Software Foundation, Inc. + + This file is part of GDB. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, write to the Free Software + Foundation, Inc., 59 Temple Place - Suite 330, + Boston, MA 02111-1307, USA. */ + +#include "defs.h" + +#include <stdarg.h> + +#if defined (HAVE_STRING_H) +#include <string.h> +#endif + +#include "gdb_assert.h" +#include "elf-bfd.h" +#include "elf/m32c.h" +#include "gdb/sim-m32c.h" +#include "dis-asm.h" +#include "gdbtypes.h" +#include "regcache.h" +#include "arch-utils.h" +#include "frame.h" +#include "frame-unwind.h" +#include "dwarf2-frame.h" +#include "dwarf2expr.h" +#include "symtab.h" +#include "gdbcore.h" +#include "value.h" +#include "reggroups.h" +#include "prologue-value.h" +#include "target.h" + + +/* The m32c tdep structure. */ + +static struct reggroup *m32c_dma_reggroup; + +struct m32c_reg; + +/* The type of a function that moves the value of REG between CACHE or + BUF --- in either direction. */ +typedef void (m32c_move_reg_t) (struct m32c_reg *reg, + struct regcache *cache, + void *buf); + +struct m32c_reg +{ + /* The name of this register. */ + const char *name; + + /* Its type. */ + struct type *type; + + /* The architecture this register belongs to. */ + struct gdbarch *arch; + + /* Its GDB register number. */ + int num; + + /* Its sim register number. */ + int sim_num; + + /* Its DWARF register number, or -1 if it doesn't have one. */ + int dwarf_num; + + /* Register group memberships. */ + unsigned int general_p : 1; + unsigned int dma_p : 1; + unsigned int system_p : 1; + unsigned int save_restore_p : 1; + + /* Functions to read its value from a regcache, and write its value + to a regcache. */ + m32c_move_reg_t *read, *write; + + /* Data for READ and WRITE functions. The exact meaning depends on + the specific functions selected; see the comments for those + functions. */ + struct m32c_reg *rx, *ry; + int n; +}; + + +/* An overestimate of the number of raw and pseudoregisters we will + have. The exact answer depends on the variant of the architecture + at hand, but we can use this to declare statically allocated + arrays, and bump it up when needed. */ +#define M32C_MAX_NUM_REGS (75) + +/* The largest assigned DWARF register number. */ +#define M32C_MAX_DWARF_REGNUM (40) + + +struct gdbarch_tdep +{ + /* All the registers for this variant, indexed by GDB register + number, and the number of registers present. */ + struct m32c_reg regs[M32C_MAX_NUM_REGS]; + + /* The number of valid registers. */ + int num_regs; + + /* Interesting registers. These are pointers into REGS. */ + struct m32c_reg *pc, *flg; + struct m32c_reg *r0, *r1, *r2, *r3, *a0, *a1; + struct m32c_reg *r2r0, *r3r2r1r0, *r3r1r2r0; + struct m32c_reg *sb, *fb, *sp; + + /* A table indexed by DWARF register numbers, pointing into + REGS. */ + struct m32c_reg *dwarf_regs[M32C_MAX_DWARF_REGNUM + 1]; + + /* Types for this architecture. We can't use the builtin_type_foo + types, because they're not initialized when building a gdbarch + structure. */ + struct type *voyd, *ptr_voyd, *func_voyd; + struct type *uint8, *uint16; + struct type *int8, *int16, *int32, *int64; + + /* The types for data address and code address registers. */ + struct type *data_addr_reg_type, *code_addr_reg_type; + + /* The number of bytes a return address pushed by a 'jsr' instruction + occupies on the stack. */ + int ret_addr_bytes; + + /* The number of bytes an address register occupies on the stack + when saved by an 'enter' or 'pushm' instruction. */ + int push_addr_bytes; +}; + + +/* Types. */ + +static void +make_types (struct gdbarch *arch) +{ + struct gdbarch_tdep *tdep = gdbarch_tdep (arch); + unsigned long mach = gdbarch_bfd_arch_info (arch)->mach; + int data_addr_reg_bits, code_addr_reg_bits; + char type_name[50]; + +#if 0 + /* This is used to clip CORE_ADDR values, so this value is + appropriate both on the m32c, where pointers are 32 bits long, + and on the m16c, where pointers are sixteen bits long, but there + may be code above the 64k boundary. */ + set_gdbarch_addr_bit (arch, 24); +#else + /* GCC uses 32 bits for addrs in the dwarf info, even though + only 16/24 bits are used. Setting addr_bit to 24 causes + errors in reading the dwarf addresses. */ + set_gdbarch_addr_bit (arch, 32); +#endif + + set_gdbarch_int_bit (arch, 16); + switch (mach) + { + case bfd_mach_m16c: + data_addr_reg_bits = 16; + code_addr_reg_bits = 24; + set_gdbarch_ptr_bit (arch, 16); + tdep->ret_addr_bytes = 3; + tdep->push_addr_bytes = 2; + break; + + case bfd_mach_m32c: + data_addr_reg_bits = 24; + code_addr_reg_bits = 24; + set_gdbarch_ptr_bit (arch, 32); + tdep->ret_addr_bytes = 4; + tdep->push_addr_bytes = 4; + break; + + default: + gdb_assert (0); + } + + /* The builtin_type_mumble variables are sometimes uninitialized when + this is called, so we avoid using them. */ + tdep->voyd = init_type (TYPE_CODE_VOID, 1, 0, "void", NULL); + tdep->ptr_voyd = init_type (TYPE_CODE_PTR, gdbarch_ptr_bit (arch) / 8, + TYPE_FLAG_UNSIGNED, NULL, NULL); + TYPE_TARGET_TYPE (tdep->ptr_voyd) = tdep->voyd; + tdep->func_voyd = lookup_function_type (tdep->voyd); + + sprintf (type_name, "%s_data_addr_t", + gdbarch_bfd_arch_info (arch)->printable_name); + tdep->data_addr_reg_type + = init_type (TYPE_CODE_PTR, data_addr_reg_bits / 8, + TYPE_FLAG_UNSIGNED, xstrdup (type_name), NULL); + TYPE_TARGET_TYPE (tdep->data_addr_reg_type) = tdep->voyd; + + sprintf (type_name, "%s_code_addr_t", + gdbarch_bfd_arch_info (arch)->printable_name); + tdep->code_addr_reg_type + = init_type (TYPE_CODE_PTR, code_addr_reg_bits / 8, + TYPE_FLAG_UNSIGNED, xstrdup (type_name), NULL); + TYPE_TARGET_TYPE (tdep->code_addr_reg_type) = tdep->func_voyd; + + tdep->uint8 = init_type (TYPE_CODE_INT, 1, TYPE_FLAG_UNSIGNED, + "uint8_t", NULL); + tdep->uint16 = init_type (TYPE_CODE_INT, 2, TYPE_FLAG_UNSIGNED, + "uint16_t", NULL); + tdep->int8 = init_type (TYPE_CODE_INT, 1, 0, "int8_t", NULL); + tdep->int16 = init_type (TYPE_CODE_INT, 2, 0, "int16_t", NULL); + tdep->int32 = init_type (TYPE_CODE_INT, 4, 0, "int32_t", NULL); + tdep->int64 = init_type (TYPE_CODE_INT, 8, 0, "int64_t", NULL); +} + + + +/* Register set. */ + +static const char * +m32c_register_name (int num) +{ + return gdbarch_tdep (current_gdbarch)->regs[num].name; +} + + +static struct type * +m32c_register_type (struct gdbarch *arch, int reg_nr) +{ + return gdbarch_tdep (arch)->regs[reg_nr].type; +} + + +static int +m32c_register_sim_regno (int reg_nr) +{ + return gdbarch_tdep (current_gdbarch)->regs[reg_nr].sim_num; +} + + +static int +m32c_debug_info_reg_to_regnum (int reg_nr) +{ + struct gdbarch_tdep *tdep = gdbarch_tdep (current_gdbarch); + if (0 <= reg_nr && reg_nr <= M32C_MAX_DWARF_REGNUM + && tdep->dwarf_regs[reg_nr]) + return tdep->dwarf_regs[reg_nr]->num; + else + /* The DWARF CFI code expects to see -1 for invalid register + numbers. */ + return -1; +} + + +int +m32c_register_reggroup_p (struct gdbarch *gdbarch, int regnum, + struct reggroup *group) +{ + struct gdbarch_tdep *tdep = gdbarch_tdep (current_gdbarch); + struct m32c_reg *reg = &tdep->regs[regnum]; + + /* The anonymous raw registers aren't in any groups. */ + if (! reg->name) + return 0; + + if (group == all_reggroup) + return 1; + + if (group == general_reggroup + && reg->general_p) + return 1; + + if (group == m32c_dma_reggroup + && reg->dma_p) + return 1; + + if (group == system_reggroup + && reg->system_p) + return 1; + + /* Since the m32c DWARF register numbers refer to cooked registers, not + raw registers, and frame_pop depends on the save and restore groups + containing registers the DWARF CFI will actually mention, our save + and restore groups are cooked registers, not raw registers. (This is + why we can't use the default reggroup function.) */ + if ((group == save_reggroup + || group == restore_reggroup) + && reg->save_restore_p) + return 1; + + return 0; +} + + +/* Register move functions. We declare them here using + m32c_move_reg_t to check the types. */ +static m32c_move_reg_t m32c_raw_read, m32c_raw_write; +static m32c_move_reg_t m32c_banked_read, m32c_banked_write; +static m32c_move_reg_t m32c_sb_read, m32c_sb_write; +static m32c_move_reg_t m32c_part_read, m32c_part_write; +static m32c_move_reg_t m32c_cat_read, m32c_cat_write; +static m32c_move_reg_t m32c_r3r2r1r0_read, m32c_r3r2r1r0_write; + + +/* Copy the value of the raw register REG from CACHE to BUF. */ +static void +m32c_raw_read (struct m32c_reg *reg, struct regcache *cache, void *buf) +{ + regcache_raw_read (cache, reg->num, buf); +} + + +/* Copy the value of the raw register REG from BUF to CACHE. */ +static void +m32c_raw_write (struct m32c_reg *reg, struct regcache *cache, void *buf) +{ + regcache_raw_write (cache, reg->num, (const void *) buf); +} + + +/* Return the value of the 'flg' register in CACHE. */ +static int +m32c_read_flg (struct regcache *cache) +{ + struct gdbarch_tdep *tdep = gdbarch_tdep (get_regcache_arch (cache)); + ULONGEST flg; + regcache_raw_read_unsigned (cache, tdep->flg->num, &flg); + return flg & 0xffff; +} + + +/* Move the value of a banked register from CACHE to BUF. + If the value of the 'flg' register in CACHE has any of the bits + masked in REG->n set, then read REG->ry. Otherwise, read + REG->rx. */ +static void +m32c_banked_read (struct m32c_reg *reg, struct regcache *cache, void *buf) +{ + struct m32c_reg *bank_reg + = ((m32c_read_flg (cache) & reg->n) ? reg->ry : reg->rx); + regcache_raw_read (cache, bank_reg->num, buf); +} + + +/* Move the value of a banked register from BUF to CACHE. + If the value of the 'flg' register in CACHE has any of the bits + masked in REG->n set, then write REG->ry. Otherwise, write + REG->rx. */ +static void +m32c_banked_write (struct m32c_reg *reg, struct regcache *cache, void *buf) +{ + struct m32c_reg *bank_reg + = ((m32c_read_flg (cache) & reg->n) ? reg->ry : reg->rx); + regcache_raw_write (cache, bank_reg->num, (const void *) buf); +} + + +/* Move the value of SB from CACHE to BUF. On bfd_mach_m32c, SB is a + banked register; on bfd_mach_m16c, it's not. */ +static void +m32c_sb_read (struct m32c_reg *reg, struct regcache *cache, void *buf) +{ + if (gdbarch_bfd_arch_info (reg->arch)->mach == bfd_mach_m16c) + m32c_raw_read (reg->rx, cache, buf); + else + m32c_banked_read (reg, cache, buf); +} + + +/* Move the value of SB from BUF to CACHE. On bfd_mach_m32c, SB is a + banked register; on bfd_mach_m16c, it's not. */ +static void +m32c_sb_write (struct m32c_reg *reg, struct regcache *cache, void *buf) +{ + if (gdbarch_bfd_arch_info (reg->arch)->mach == bfd_mach_m16c) + m32c_raw_write (reg->rx, cache, buf); + else + m32c_banked_write (reg, cache, buf); +} + + +/* Assuming REG uses m32c_part_read and m32c_part_write, set *OFFSET_P + and *LEN_P to the offset and length, in bytes, of the part REG + occupies in its underlying register. The offset is from the + lower-addressed end, regardless of the architecture's endianness. + (The M32C family is always little-endian, but let's keep those + assumptions out of here.) */ +static void +m32c_find_part (struct m32c_reg *reg, int *offset_p, int *len_p) +{ + /* The length of the containing register, of which REG is one part. */ + int containing_len = TYPE_LENGTH (reg->rx->type); + + /* The length of one "element" in our imaginary array. */ + int elt_len = TYPE_LENGTH (reg->type); + + /* The offset of REG's "element" from the least significant end of + the containing register. */ + int elt_offset = reg->n * elt_len; + + /* If we extend off the end, trim the length of the element. */ + if (elt_offset + elt_len > containing_len) + { + elt_len = containing_len - elt_offset; + /* We shouldn't be declaring partial registers that go off the + end of their containing registers. */ + gdb_assert (elt_len > 0); + } + + /* Flip the offset around if we're big-endian. */ + if (gdbarch_byte_order (reg->arch) == BFD_ENDIAN_BIG) + elt_offset = TYPE_LENGTH (reg->rx->type) - elt_offset - elt_len; + + *offset_p = elt_offset; + *len_p = elt_len; +} + + +/* Move the value of a partial register (r0h, intbl, etc.) from CACHE + to BUF. Treating the value of the register REG->rx as an array of + REG->type values, where higher indices refer to more significant + bits, read the value of the REG->n'th element. */ +static void +m32c_part_read (struct m32c_reg *reg, struct regcache *cache, void *buf) +{ + int offset, len; + memset (buf, 0, TYPE_LENGTH (reg->type)); + m32c_find_part (reg, &offset, &len); + regcache_cooked_read_part (cache, reg->rx->num, offset, len, buf); +} + + +/* Move the value of a banked register from BUF to CACHE. + Treating the value of the register REG->rx as an array of REG->type + values, where higher indices refer to more significant bits, write + the value of the REG->n'th element. */ +static void +m32c_part_write (struct m32c_reg *reg, struct regcache *cache, void *buf) +{ + int offset, len; + m32c_find_part (reg, &offset, &len); + regcache_cooked_write_part (cache, reg->rx->num, offset, len, buf); +} + + +/* Move the value of REG from CACHE to BUF. REG's value is the + concatenation of the values of the registers REG->rx and REG->ry, + with REG->rx contributing the more significant bits. */ +static void +m32c_cat_read (struct m32c_reg *reg, struct regcache *cache, void *buf) +{ + int high_bytes = TYPE_LENGTH (reg->rx->type); + int low_bytes = TYPE_LENGTH (reg->ry->type); + /* For address arithmetic. */ + unsigned char *cbuf = buf; + + gdb_assert (TYPE_LENGTH (reg->type) == high_bytes + low_bytes); + + if (gdbarch_byte_order (reg->arch) == BFD_ENDIAN_BIG) + { + regcache_cooked_read (cache, reg->rx->num, cbuf); + regcache_cooked_read (cache, reg->ry->num, cbuf + high_bytes); + } + else + { + regcache_cooked_read (cache, reg->rx->num, cbuf + low_bytes); + regcache_cooked_read (cache, reg->ry->num, cbuf); + } +} + + +/* Move the value of REG from CACHE to BUF. REG's value is the + concatenation of the values of the registers REG->rx and REG->ry, + with REG->rx contributing the more significant bits. */ +static void +m32c_cat_write (struct m32c_reg *reg, struct regcache *cache, void *buf) +{ + int high_bytes = TYPE_LENGTH (reg->rx->type); + int low_bytes = TYPE_LENGTH (reg->ry->type); + /* For address arithmetic. */ + unsigned char *cbuf = buf; + + gdb_assert (TYPE_LENGTH (reg->type) == high_bytes + low_bytes); + + if (gdbarch_byte_order (reg->arch) == BFD_ENDIAN_BIG) + { + regcache_cooked_write (cache, reg->rx->num, cbuf); + regcache_cooked_write (cache, reg->ry->num, cbuf + high_bytes); + } + else + { + regcache_cooked_write (cache, reg->rx->num, cbuf + low_bytes); + regcache_cooked_write (cache, reg->ry->num, cbuf); + } +} + + +/* Copy the value of the raw register REG from CACHE to BUF. REG is + the concatenation (from most significant to least) of r3, r2, r1, + and r0. */ +static void +m32c_r3r2r1r0_read (struct m32c_reg *reg, struct regcache *cache, void *buf) +{ + struct gdbarch_tdep *tdep = gdbarch_tdep (reg->arch); + int len = TYPE_LENGTH (tdep->r0->type); + + /* For address arithmetic. */ + unsigned char *cbuf = buf; + + if (gdbarch_byte_order (reg->arch) == BFD_ENDIAN_BIG) + { + regcache_cooked_read (cache, tdep->r0->num, cbuf + len * 3); + regcache_cooked_read (cache, tdep->r1->num, cbuf + len * 2); + regcache_cooked_read (cache, tdep->r2->num, cbuf + len * 1); + regcache_cooked_read (cache, tdep->r3->num, cbuf); + } + else + { + regcache_cooked_read (cache, tdep->r0->num, cbuf); + regcache_cooked_read (cache, tdep->r1->num, cbuf + len * 1); + regcache_cooked_read (cache, tdep->r2->num, cbuf + len * 2); + regcache_cooked_read (cache, tdep->r3->num, cbuf + len * 3); + } +} + + +/* Copy the value of the raw register REG from BUF to CACHE. REG is + the concatenation (from most significant to least) of r3, r2, r1, + and r0. */ +static void +m32c_r3r2r1r0_write (struct m32c_reg *reg, struct regcache *cache, void *buf) +{ + struct gdbarch_tdep *tdep = gdbarch_tdep (reg->arch); + int len = TYPE_LENGTH (tdep->r0->type); + + /* For address arithmetic. */ + unsigned char *cbuf = buf; + + if (gdbarch_byte_order (reg->arch) == BFD_ENDIAN_BIG) + { + regcache_cooked_write (cache, tdep->r0->num, cbuf + len * 3); + regcache_cooked_write (cache, tdep->r1->num, cbuf + len * 2); + regcache_cooked_write (cache, tdep->r2->num, cbuf + len * 1); + regcache_cooked_write (cache, tdep->r3->num, cbuf); + } + else + { + regcache_cooked_write (cache, tdep->r0->num, cbuf); + regcache_cooked_write (cache, tdep->r1->num, cbuf + len * 1); + regcache_cooked_write (cache, tdep->r2->num, cbuf + len * 2); + regcache_cooked_write (cache, tdep->r3->num, cbuf + len * 3); + } +} + + +static void +m32c_pseudo_register_read (struct gdbarch *arch, + struct regcache *cache, + int cookednum, + gdb_byte *buf) +{ + struct gdbarch_tdep *tdep = gdbarch_tdep (arch); + struct m32c_reg *reg; + + gdb_assert (0 <= cookednum && cookednum < tdep->num_regs); + gdb_assert (arch == get_regcache_arch (cache)); + gdb_assert (arch == tdep->regs[cookednum].arch); + reg = &tdep->regs[cookednum]; + + reg->read (reg, cache, buf); +} + + +static void +m32c_pseudo_register_write (struct gdbarch *arch, + struct regcache *cache, + int cookednum, + const gdb_byte *buf) +{ + struct gdbarch_tdep *tdep = gdbarch_tdep (arch); + struct m32c_reg *reg; + + gdb_assert (0 <= cookednum && cookednum < tdep->num_regs); + gdb_assert (arch == get_regcache_arch (cache)); + gdb_assert (arch == tdep->regs[cookednum].arch); + reg = &tdep->regs[cookednum]; + + reg->write (reg, cache, (void *) buf); +} + + +/* Add a register with the given fields to the end of ARCH's table. + Return a pointer to the newly added register. */ +static struct m32c_reg * +add_reg (struct gdbarch *arch, + const char *name, + struct type *type, + int sim_num, + m32c_move_reg_t *read, + m32c_move_reg_t *write, + struct m32c_reg *rx, + struct m32c_reg *ry, + int n) +{ + struct gdbarch_tdep *tdep = gdbarch_tdep (arch); + struct m32c_reg *r = &tdep->regs[tdep->num_regs]; + + gdb_assert (tdep->num_regs < M32C_MAX_NUM_REGS); + + r->name = name; + r->type = type; + r->arch = arch; + r->num = tdep->num_regs; + r->sim_num = sim_num; + r->dwarf_num = -1; + r->general_p = 0; + r->dma_p = 0; + r->system_p = 0; + r->save_restore_p = 0; + r->read = read; + r->write = write; + r->rx = rx; + r->ry = ry; + r->n = n; + + tdep->num_regs++; + + return r; +} + + +/* Record NUM as REG's DWARF register number. */ +static void +set_dwarf_regnum (struct m32c_reg *reg, int num) +{ + gdb_assert (num < M32C_MAX_NUM_REGS); + + /* Update the reg->DWARF mapping. Only count the first number + assigned to this register. */ + if (reg->dwarf_num == -1) + reg->dwarf_num = num; + + /* Update the DWARF->reg mapping. */ + gdbarch_tdep (reg->arch)->dwarf_regs[num] = reg; +} + + +/* Mark REG as a general-purpose register, and return it. */ +static struct m32c_reg * +mark_general (struct m32c_reg *reg) +{ + reg->general_p = 1; + return reg; +} + + +/* Mark REG as a DMA register, and return it. */ +static struct m32c_reg * +mark_dma (struct m32c_reg *reg) +{ + reg->dma_p = 1; + return reg; +} + + +/* Mark REG as a SYSTEM register, and return it. */ +static struct m32c_reg * +mark_system (struct m32c_reg *reg) +{ + reg->system_p = 1; + return reg; +} + + +/* Mark REG as a save-restore register, and return it. */ +static struct m32c_reg * +mark_save_restore (struct m32c_reg *reg) +{ + reg->save_restore_p = 1; + return reg; +} + + +#define FLAGBIT_B 0x0010 +#define FLAGBIT_U 0x0080 + +/* Handy macros for declaring registers. These all evaluate to + pointers to the register declared. Macros that define two + registers evaluate to a pointer to the first. */ + +/* A raw register named NAME, with type TYPE and sim number SIM_NUM. */ +#define R(name, type, sim_num) \ + (add_reg (arch, (name), (type), (sim_num), \ + m32c_raw_read, m32c_raw_write, NULL, NULL, 0)) + +/* The simulator register number for a raw register named NAME. */ +#define SIM(name) (m32c_sim_reg_ ## name) + +/* A raw unsigned 16-bit data register named NAME. + NAME should be an identifier, not a string. */ +#define R16U(name) \ + (R(#name, tdep->uint16, SIM (name))) + +/* A raw data address register named NAME. + NAME should be an identifier, not a string. */ +#define RA(name) \ + (R(#name, tdep->data_addr_reg_type, SIM (name))) + +/* A raw code address register named NAME. NAME should + be an identifier, not a string. */ +#define RC(name) \ + (R(#name, tdep->code_addr_reg_type, SIM (name))) + +/* A pair of raw registers named NAME0 and NAME1, with type TYPE. + NAME should be an identifier, not a string. */ +#define RP(name, type) \ + (R(#name "0", (type), SIM (name ## 0)), \ + R(#name "1", (type), SIM (name ## 1)) - 1) + +/* A raw banked general-purpose data register named NAME. + NAME should be an identifier, not a string. */ +#define RBD(name) \ + (R(NULL, tdep->int16, SIM (name ## _bank0)), \ + R(NULL, tdep->int16, SIM (name ## _bank1)) - 1) + +/* A raw banked data address register named NAME. + NAME should be an identifier, not a string. */ +#define RBA(name) \ + (R(NULL, tdep->data_addr_reg_type, SIM (name ## _bank0)), \ + R(NULL, tdep->data_addr_reg_type, SIM (name ## _bank1)) - 1) + +/* A cooked register named NAME referring to a raw banked register + from the bank selected by the current value of FLG. RAW_PAIR + should be a pointer to the first register in the banked pair. + NAME must be an identifier, not a string. */ +#define CB(name, raw_pair) \ + (add_reg (arch, #name, (raw_pair)->type, 0, \ + m32c_banked_read, m32c_banked_write, \ + (raw_pair), (raw_pair + 1), FLAGBIT_B)) + +/* A pair of registers named NAMEH and NAMEL, of type TYPE, that + access the top and bottom halves of the register pointed to by + NAME. NAME should be an identifier. */ +#define CHL(name, type) \ + (add_reg (arch, #name "h", (type), 0, \ + m32c_part_read, m32c_part_write, name, NULL, 1), \ + add_reg (arch, #name "l", (type), 0, \ + m32c_part_read, m32c_part_write, name, NULL, 0) - 1) + +/* A register constructed by concatenating the two registers HIGH and + LOW, whose name is HIGHLOW and whose type is TYPE. */ +#define CCAT(high, low, type) \ + (add_reg (arch, #high #low, (type), 0, \ + m32c_cat_read, m32c_cat_write, (high), (low), 0)) + +/* Abbreviations for marking register group membership. */ +#define G(reg) (mark_general (reg)) +#define S(reg) (mark_system (reg)) +#define DMA(reg) (mark_dma (reg)) + + +/* Construct the register set for ARCH. */ +static void +make_regs (struct gdbarch *arch) +{ + struct gdbarch_tdep *tdep = gdbarch_tdep (arch); + int mach = gdbarch_bfd_arch_info (arch)->mach; + + struct m32c_reg *raw_r0_pair = RBD (r0); + struct m32c_reg *raw_r1_pair = RBD (r1); + struct m32c_reg *raw_r2_pair = RBD (r2); + struct m32c_reg *raw_r3_pair = RBD (r3); + struct m32c_reg *raw_a0_pair = RBA (a0); + struct m32c_reg *raw_a1_pair = RBA (a1); + struct m32c_reg *raw_fb_pair = RBA (fb); + + /* sb is banked on the bfd_mach_m32c, but not on bfd_mach_m16c. + We always declare both raw registers, and deal with the distinction + in the pseudoregister. */ + struct m32c_reg *raw_sb_pair = RBA (sb); + + struct m32c_reg *usp = S (RA (usp)); + struct m32c_reg *isp = S (RA (isp)); + struct m32c_reg *intb = S (RC (intb)); + struct m32c_reg *pc = G (RC (pc)); + struct m32c_reg *flg = G (R16U (flg)); + + if (mach == bfd_mach_m32c) + { + struct m32c_reg *svf = S (R16U (svf)); + struct m32c_reg *svp = S (RC (svp)); + struct m32c_reg *vct = S (RC (vct)); + + struct m32c_reg *dmd01 = DMA (RP (dmd, tdep->uint8)); + struct m32c_reg *dct01 = DMA (RP (dct, tdep->uint16)); + struct m32c_reg *drc01 = DMA (RP (drc, tdep->uint16)); + struct m32c_reg *dma01 = DMA (RP (dma, tdep->data_addr_reg_type)); + struct m32c_reg *dsa01 = DMA (RP (dsa, tdep->data_addr_reg_type)); + struct m32c_reg *dra01 = DMA (RP (dra, tdep->data_addr_reg_type)); + } + + int num_raw_regs = tdep->num_regs; + + struct m32c_reg *r0 = G (CB (r0, raw_r0_pair)); + struct m32c_reg *r1 = G (CB (r1, raw_r1_pair)); + struct m32c_reg *r2 = G (CB (r2, raw_r2_pair)); + struct m32c_reg *r3 = G (CB (r3, raw_r3_pair)); + struct m32c_reg *a0 = G (CB (a0, raw_a0_pair)); + struct m32c_reg *a1 = G (CB (a1, raw_a1_pair)); + struct m32c_reg *fb = G (CB (fb, raw_fb_pair)); + + /* sb is banked on the bfd_mach_m32c, but not on bfd_mach_m16c. + Specify custom read/write functions that do the right thing. */ + struct m32c_reg *sb + = G (add_reg (arch, "sb", raw_sb_pair->type, 0, + m32c_sb_read, m32c_sb_write, + raw_sb_pair, raw_sb_pair + 1, 0)); + + /* The current sp is either usp or isp, depending on the value of + the FLG register's U bit. */ + struct m32c_reg *sp + = G (add_reg (arch, "sp", usp->type, 0, + m32c_banked_read, m32c_banked_write, isp, usp, FLAGBIT_U)); + + struct m32c_reg *r0hl = CHL (r0, tdep->int8); + struct m32c_reg *r1hl = CHL (r1, tdep->int8); + struct m32c_reg *r2hl = CHL (r2, tdep->int8); + struct m32c_reg *r3hl = CHL (r3, tdep->int8); + struct m32c_reg *intbhl = CHL (intb, tdep->int16); + + struct m32c_reg *r2r0 = CCAT (r2, r0, tdep->int32); + struct m32c_reg *r3r1 = CCAT (r3, r1, tdep->int32); + struct m32c_reg *r3r1r2r0 = CCAT (r3r1, r2r0, tdep->int64); + + struct m32c_reg *r3r2r1r0 + = add_reg (arch, "r3r2r1r0", tdep->int64, 0, + m32c_r3r2r1r0_read, m32c_r3r2r1r0_write, NULL, NULL, 0); + + struct m32c_reg *a1a0; + if (mach == bfd_mach_m16c) + a1a0 = CCAT (a1, a0, tdep->int32); + else + a1a0 = NULL; + + int num_cooked_regs = tdep->num_regs - num_raw_regs; + + tdep->pc = pc; + tdep->flg = flg; + tdep->r0 = r0; + tdep->r1 = r1; + tdep->r2 = r2; + tdep->r3 = r3; + tdep->r2r0 = r2r0; + tdep->r3r2r1r0 = r3r2r1r0; + tdep->r3r1r2r0 = r3r1r2r0; + tdep->a0 = a0; + tdep->a1 = a1; + tdep->sb = sb; + tdep->fb = fb; + tdep->sp = sp; + + /* Set up the DWARF register table. */ + memset (tdep->dwarf_regs, 0, sizeof (tdep->dwarf_regs)); + set_dwarf_regnum (r0hl + 1, 0x01); + set_dwarf_regnum (r0hl + 0, 0x02); + set_dwarf_regnum (r1hl + 1, 0x03); + set_dwarf_regnum (r1hl + 0, 0x04); + set_dwarf_regnum (r0, 0x05); + set_dwarf_regnum (r1, 0x06); + set_dwarf_regnum (r2, 0x07); + set_dwarf_regnum (r3, 0x08); + set_dwarf_regnum (a0, 0x09); + set_dwarf_regnum (a1, 0x0a); + set_dwarf_regnum (fb, 0x0b); + set_dwarf_regnum (sp, 0x0c); + set_dwarf_regnum (pc, 0x0d); /* GCC's invention */ + set_dwarf_regnum (sb, 0x13); + set_dwarf_regnum (r2r0, 0x15); + set_dwarf_regnum (r3r1, 0x16); + if (a1a0) + set_dwarf_regnum (a1a0, 0x17); + + /* Enumerate the save/restore register group. + + The regcache_save and regcache_restore functions apply their read + function to each register in this group. + + Since frame_pop supplies frame_unwind_register as its read + function, the registers meaningful to the Dwarf unwinder need to + be in this group. + + On the other hand, when we make inferior calls, save_inferior_status + and restore_inferior_status use them to preserve the current register + values across the inferior call. For this, you'd kind of like to + preserve all the raw registers, to protect the interrupted code from + any sort of bank switching the callee might have done. But we handle + those cases so badly anyway --- for example, it matters whether we + restore FLG before or after we restore the general-purpose registers, + but there's no way to express that --- that it isn't worth worrying + about. + + We omit control registers like inthl: if you call a function that + changes those, it's probably because you wanted that change to be + visible to the interrupted code. */ + mark_save_restore (r0); + mark_save_restore (r1); + mark_save_restore (r2); + mark_save_restore (r3); + mark_save_restore (a0); + mark_save_restore (a1); + mark_save_restore (sb); + mark_save_restore (fb); + mark_save_restore (sp); + mark_save_restore (pc); + mark_save_restore (flg); + + set_gdbarch_num_regs (arch, num_raw_regs); + set_gdbarch_num_pseudo_regs (arch, num_cooked_regs); + set_gdbarch_pc_regnum (arch, pc->num); + set_gdbarch_sp_regnum (arch, sp->num); + set_gdbarch_register_name (arch, m32c_register_name); + set_gdbarch_register_type (arch, m32c_register_type); + set_gdbarch_pseudo_register_read (arch, m32c_pseudo_register_read); + set_gdbarch_pseudo_register_write (arch, m32c_pseudo_register_write); + set_gdbarch_register_sim_regno (arch, m32c_register_sim_regno); + set_gdbarch_stab_reg_to_regnum (arch, m32c_debug_info_reg_to_regnum); + set_gdbarch_dwarf_reg_to_regnum (arch, m32c_debug_info_reg_to_regnum); + set_gdbarch_dwarf2_reg_to_regnum (arch, m32c_debug_info_reg_to_regnum); + set_gdbarch_register_reggroup_p (arch, m32c_register_reggroup_p); + + reggroup_add (arch, general_reggroup); + reggroup_add (arch, all_reggroup); + reggroup_add (arch, save_reggroup); + reggroup_add (arch, restore_reggroup); + reggroup_add (arch, system_reggroup); + reggroup_add (arch, m32c_dma_reggroup); +} + + + +/* Breakpoints. */ + +static const unsigned char * +m32c_breakpoint_from_pc (CORE_ADDR *pc, int *len) +{ + static unsigned char break_insn[] = { 0x00 }; /* brk */ + + *len = sizeof (break_insn); + return break_insn; +} + + + +/* Prologue analysis. */ + +struct m32c_prologue +{ + /* For consistency with the DWARF 2 .debug_frame info generated by + GCC, a frame's CFA is the address immediately after the saved + return address. */ + + /* The architecture for which we generated this prologue info. */ + struct gdbarch *arch; + + enum { + /* This function uses a frame pointer. */ + prologue_with_frame_ptr, + + /* This function has no frame pointer. */ + prologue_sans_frame_ptr, + + /* This function sets up the stack, so its frame is the first + frame on the stack. */ + prologue_first_frame + + } kind; + + /* If KIND is prologue_with_frame_ptr, this is the offset from the + CFA to where the frame pointer points. This is always zero or + negative. */ + LONGEST frame_ptr_offset; + + /* If KIND is prologue_sans_frame_ptr, the offset from the CFA to + the stack pointer --- always zero or negative. + + Calling this a "size" is a bit misleading, but given that the + stack grows downwards, using offsets for everything keeps one + from going completely sign-crazy: you never change anything's + sign for an ADD instruction; always change the second operand's + sign for a SUB instruction; and everything takes care of + itself. + + Functions that use alloca don't have a constant frame size. But + they always have frame pointers, so we must use that to find the + CFA (and perhaps to unwind the stack pointer). */ + LONGEST frame_size; + + /* The address of the first instruction at which the frame has been + set up and the arguments are where the debug info says they are + --- as best as we can tell. */ + CORE_ADDR prologue_end; + + /* reg_offset[R] is the offset from the CFA at which register R is + saved, or 1 if register R has not been saved. (Real values are + always zero or negative.) */ + LONGEST reg_offset[M32C_MAX_NUM_REGS]; +}; + + +/* The longest I've seen, anyway. */ +#define M32C_MAX_INSN_LEN (9) + +/* Processor state, for the prologue analyzer. */ +struct m32c_pv_state +{ + struct gdbarch *arch; + pv_t r0, r1, r2, r3; + pv_t a0, a1; + pv_t sb, fb, sp; + pv_t pc; + struct pv_area *stack; + + /* Bytes from the current PC, the address they were read from, + and the address of the next unconsumed byte. */ + gdb_byte insn[M32C_MAX_INSN_LEN]; + CORE_ADDR scan_pc, next_addr; +}; + + +/* Push VALUE on STATE's stack, occupying SIZE bytes. Return zero if + all went well, or non-zero if simulating the action would trash our + state. */ +static int +m32c_pv_push (struct m32c_pv_state *state, pv_t value, int size) +{ + if (pv_area_store_would_trash (state->stack, state->sp)) + return 1; + + state->sp = pv_add_constant (state->sp, -size); + pv_area_store (state->stack, state->sp, size, value); + + return 0; +} + + +/* A source or destination location for an m16c or m32c + instruction. */ +struct srcdest +{ + /* If srcdest_reg, the location is a register pointed to by REG. + If srcdest_partial_reg, the location is part of a register pointed + to by REG. We don't try to handle this too well. + If srcdest_mem, the location is memory whose address is ADDR. */ + enum { srcdest_reg, srcdest_partial_reg, srcdest_mem } kind; + pv_t *reg, addr; +}; + + +/* Return the SIZE-byte value at LOC in STATE. */ +static pv_t +m32c_srcdest_fetch (struct m32c_pv_state *state, struct srcdest loc, int size) +{ + if (loc.kind == srcdest_mem) + return pv_area_fetch (state->stack, loc.addr, size); + else if (loc.kind == srcdest_partial_reg) + return pv_unknown (); + else + return *loc.reg; +} + + +/* Write VALUE, a SIZE-byte value, to LOC in STATE. Return zero if + all went well, or non-zero if simulating the store would trash our + state. */ +static int +m32c_srcdest_store (struct m32c_pv_state *state, struct srcdest loc, + pv_t value, int size) +{ + if (loc.kind == srcdest_mem) + { + if (pv_area_store_would_trash (state->stack, loc.addr)) + return 1; + pv_area_store (state->stack, loc.addr, size, value); + } + else if (loc.kind == srcdest_partial_reg) + *loc.reg = pv_unknown (); + else + *loc.reg = value; + + return 0; +} + + +static int +m32c_sign_ext (int v, int bits) +{ + int mask = 1 << (bits - 1); + return (v ^ mask) - mask; +} + +static unsigned int +m32c_next_byte (struct m32c_pv_state *st) +{ + gdb_assert (st->next_addr - st->scan_pc < sizeof (st->insn)); + return st->insn[st->next_addr++ - st->scan_pc]; +} + +static int +m32c_udisp8 (struct m32c_pv_state *st) +{ + return m32c_next_byte (st); +} + + +static int +m32c_sdisp8 (struct m32c_pv_state *st) +{ + return m32c_sign_ext (m32c_next_byte (st), 8); +} + + +static int +m32c_udisp16 (struct m32c_pv_state *st) +{ + int low = m32c_next_byte (st); + int high = m32c_next_byte (st); + + return low + (high << 8); +} + + +static int +m32c_sdisp16 (struct m32c_pv_state *st) +{ + int low = m32c_next_byte (st); + int high = m32c_next_byte (st); + + return m32c_sign_ext (low + (high << 8), 16); +} + + +static int +m32c_udisp24 (struct m32c_pv_state *st) +{ + int low = m32c_next_byte (st); + int mid = m32c_next_byte (st); + int high = m32c_next_byte (st); + + return low + (mid << 8) + (high << 16); +} + + +/* Extract the 'source' field from an m32c MOV.size:G-format instruction. */ +static int +m32c_get_src23 (unsigned char *i) +{ + return (((i[0] & 0x70) >> 2) + | ((i[1] & 0x30) >> 4)); +} + + +/* Extract the 'dest' field from an m32c MOV.size:G-format instruction. */ +static int +m32c_get_dest23 (unsigned char *i) +{ + return (((i[0] & 0x0e) << 1) + | ((i[1] & 0xc0) >> 6)); +} + + +static struct srcdest +m32c_decode_srcdest4 (struct m32c_pv_state *st, + int code, int size) +{ + struct srcdest sd; + + if (code < 6) + sd.kind = (size == 2 ? srcdest_reg : srcdest_partial_reg); + else + sd.kind = srcdest_mem; + + switch (code) + { + case 0x0: sd.reg = (size == 1 ? &st->r0 : &st->r0); break; + case 0x1: sd.reg = (size == 1 ? &st->r0 : &st->r1); break; + case 0x2: sd.reg = (size == 1 ? &st->r1 : &st->r2); break; + case 0x3: sd.reg = (size == 1 ? &st->r1 : &st->r3); break; + + case 0x4: sd.reg = &st->a0; break; + case 0x5: sd.reg = &st->a1; break; + + case 0x6: sd.addr = st->a0; break; + case 0x7: sd.addr = st->a1; break; + + case 0x8: sd.addr = pv_add_constant (st->a0, m32c_udisp8 (st)); break; + case 0x9: sd.addr = pv_add_constant (st->a1, m32c_udisp8 (st)); break; + case 0xa: sd.addr = pv_add_constant (st->sb, m32c_udisp8 (st)); break; + case 0xb: sd.addr = pv_add_constant (st->fb, m32c_sdisp8 (st)); break; + + case 0xc: sd.addr = pv_add_constant (st->a0, m32c_udisp16 (st)); break; + case 0xd: sd.addr = pv_add_constant (st->a1, m32c_udisp16 (st)); break; + case 0xe: sd.addr = pv_add_constant (st->sb, m32c_udisp16 (st)); break; + case 0xf: sd.addr = pv_constant (m32c_udisp16 (st)); break; + + default: + gdb_assert (0); + } + + return sd; +} + + +static struct srcdest +m32c_decode_sd23 (struct m32c_pv_state *st, int code, int size, int ind) +{ + struct srcdest sd; + + switch (code) + { + case 0x12: + case 0x13: + case 0x10: + case 0x11: + sd.kind = (size == 1) ? srcdest_partial_reg : srcdest_reg; + break; + + case 0x02: + case 0x03: + sd.kind = (size == 4) ? srcdest_reg : srcdest_partial_reg; + break; + + default: + sd.kind = srcdest_mem; + break; + + } + + switch (code) + { + case 0x12: sd.reg = &st->r0; break; + case 0x13: sd.reg = &st->r1; break; + case 0x10: sd.reg = ((size == 1) ? &st->r0 : &st->r2); break; + case 0x11: sd.reg = ((size == 1) ? &st->r1 : &st->r3); break; + case 0x02: sd.reg = &st->a0; break; + case 0x03: sd.reg = &st->a1; break; + + case 0x00: sd.addr = st->a0; break; + case 0x01: sd.addr = st->a1; break; + case 0x04: sd.addr = pv_add_constant (st->a0, m32c_udisp8 (st)); break; + case 0x05: sd.addr = pv_add_constant (st->a1, m32c_udisp8 (st)); break; + case 0x06: sd.addr = pv_add_constant (st->sb, m32c_udisp8 (st)); break; + case 0x07: sd.addr = pv_add_constant (st->fb, m32c_sdisp8 (st)); break; + case 0x08: sd.addr = pv_add_constant (st->a0, m32c_udisp16 (st)); break; + case 0x09: sd.addr = pv_add_constant (st->a1, m32c_udisp16 (st)); break; + case 0x0a: sd.addr = pv_add_constant (st->sb, m32c_udisp16 (st)); break; + case 0x0b: sd.addr = pv_add_constant (st->fb, m32c_sdisp16 (st)); break; + case 0x0c: sd.addr = pv_add_constant (st->a0, m32c_udisp24 (st)); break; + case 0x0d: sd.addr = pv_add_constant (st->a1, m32c_udisp24 (st)); break; + case 0x0f: sd.addr = pv_constant (m32c_udisp16 (st)); break; + case 0x0e: sd.addr = pv_constant (m32c_udisp24 (st)); break; + default: + gdb_assert (0); + } + + if (ind) + { + sd.addr = m32c_srcdest_fetch (st, sd, 4); + sd.kind = srcdest_mem; + } + + return sd; +} + + +/* The r16c and r32c machines have instructions with similar + semantics, but completely different machine language encodings. So + we break out the semantics into their own functions, and leave + machine-specific decoding in m32c_analyze_prologue. + + The following functions all expect their arguments already decoded, + and they all return zero if analysis should continue past this + instruction, or non-zero if analysis should stop. */ + + +/* Simulate an 'enter SIZE' instruction in STATE. */ +static int +m32c_pv_enter (struct m32c_pv_state *state, int size) +{ + struct gdbarch_tdep *tdep = gdbarch_tdep (state->arch); + + /* If simulating this store would require us to forget + everything we know about the stack frame in the name of + accuracy, it would be better to just quit now. */ + if (pv_area_store_would_trash (state->stack, state->sp)) + return 1; + + if (m32c_pv_push (state, state->fb, tdep->push_addr_bytes)) + return 1; + state->fb = state->sp; + state->sp = pv_add_constant (state->sp, -size); + + return 0; +} + + +static int +m32c_pv_pushm_one (struct m32c_pv_state *state, pv_t reg, + int bit, int src, int size) +{ + if (bit & src) + { + if (m32c_pv_push (state, reg, size)) + return 1; + } + + return 0; +} + + +/* Simulate a 'pushm SRC' instruction in STATE. */ +static int +m32c_pv_pushm (struct m32c_pv_state *state, int src) +{ + struct gdbarch_tdep *tdep = gdbarch_tdep (state->arch); + + /* The bits in SRC indicating which registers to save are: + r0 r1 r2 r3 a0 a1 sb fb */ + return + ( m32c_pv_pushm_one (state, state->fb, 0x01, src, tdep->push_addr_bytes) + || m32c_pv_pushm_one (state, state->sb, 0x02, src, tdep->push_addr_bytes) + || m32c_pv_pushm_one (state, state->a1, 0x04, src, tdep->push_addr_bytes) + || m32c_pv_pushm_one (state, state->a0, 0x08, src, tdep->push_addr_bytes) + || m32c_pv_pushm_one (state, state->r3, 0x10, src, 2) + || m32c_pv_pushm_one (state, state->r2, 0x20, src, 2) + || m32c_pv_pushm_one (state, state->r1, 0x40, src, 2) + || m32c_pv_pushm_one (state, state->r0, 0x80, src, 2)); +} + +/* Return non-zero if VALUE is the first incoming argument register. */ + +static int +m32c_is_1st_arg_reg (struct m32c_pv_state *state, pv_t value) +{ + struct gdbarch_tdep *tdep = gdbarch_tdep (state->arch); + return (value.kind == pvk_register + && (gdbarch_bfd_arch_info (state->arch)->mach == bfd_mach_m16c + ? (value.reg == tdep->r1->num) + : (value.reg == tdep->r0->num)) + && value.k == 0); +} + +/* Return non-zero if VALUE is an incoming argument register. */ + +static int +m32c_is_arg_reg (struct m32c_pv_state *state, pv_t value) +{ + struct gdbarch_tdep *tdep = gdbarch_tdep (state->arch); + return (value.kind == pvk_register + && (gdbarch_bfd_arch_info (state->arch)->mach == bfd_mach_m16c + ? (value.reg == tdep->r1->num || value.reg == tdep->r2->num) + : (value.reg == tdep->r0->num)) + && value.k == 0); +} + +/* Return non-zero if a store of VALUE to LOC is probably spilling an + argument register to its stack slot in STATE. Such instructions + should be included in the prologue, if possible. + + The store is a spill if: + - the value being stored is the original value of an argument register; + - the value has not already been stored somewhere in STACK; and + - LOC is a stack slot (e.g., a memory location whose address is + relative to the original value of the SP). */ + +static int +m32c_is_arg_spill (struct m32c_pv_state *st, + struct srcdest loc, + pv_t value) +{ + struct gdbarch_tdep *tdep = gdbarch_tdep (st->arch); + + return (m32c_is_arg_reg (st, value) + && loc.kind == srcdest_mem + && pv_is_register (loc.addr, tdep->sp->num) + && ! pv_area_find_reg (st->stack, st->arch, value.reg, 0)); +} + +/* Return non-zero if a store of VALUE to LOC is probably + copying the struct return address into an address register + for immediate use. This is basically a "spill" into the + address register, instead of onto the stack. + + The prerequisites are: + - value being stored is original value of the FIRST arg register; + - value has not already been stored on stack; and + - LOC is an address register (a0 or a1). */ + +static int +m32c_is_struct_return (struct m32c_pv_state *st, + struct srcdest loc, + pv_t value) +{ + struct gdbarch_tdep *tdep = gdbarch_tdep (st->arch); + + return (m32c_is_1st_arg_reg (st, value) + && !pv_area_find_reg (st->stack, st->arch, value.reg, 0) + && loc.kind == srcdest_reg + && (pv_is_register (*loc.reg, tdep->a0->num) + || pv_is_register (*loc.reg, tdep->a1->num))); +} + +/* Return non-zero if a 'pushm' saving the registers indicated by SRC + was a register save: + - all the named registers should have their original values, and + - the stack pointer should be at a constant offset from the + original stack pointer. */ +static int +m32c_pushm_is_reg_save (struct m32c_pv_state *st, int src) +{ + struct gdbarch_tdep *tdep = gdbarch_tdep (st->arch); + /* The bits in SRC indicating which registers to save are: + r0 r1 r2 r3 a0 a1 sb fb */ + return + (pv_is_register (st->sp, tdep->sp->num) + && (! (src & 0x01) || pv_is_register_k (st->fb, tdep->fb->num, 0)) + && (! (src & 0x02) || pv_is_register_k (st->sb, tdep->sb->num, 0)) + && (! (src & 0x04) || pv_is_register_k (st->a1, tdep->a1->num, 0)) + && (! (src & 0x08) || pv_is_register_k (st->a0, tdep->a0->num, 0)) + && (! (src & 0x10) || pv_is_register_k (st->r3, tdep->r3->num, 0)) + && (! (src & 0x20) || pv_is_register_k (st->r2, tdep->r2->num, 0)) + && (! (src & 0x40) || pv_is_register_k (st->r1, tdep->r1->num, 0)) + && (! (src & 0x80) || pv_is_register_k (st->r0, tdep->r0->num, 0))); +} + + +/* Function for finding saved registers in a 'struct pv_area'; we pass + this to pv_area_scan. + + If VALUE is a saved register, ADDR says it was saved at a constant + offset from the frame base, and SIZE indicates that the whole + register was saved, record its offset in RESULT_UNTYPED. */ +static void +check_for_saved (void *prologue_untyped, pv_t addr, CORE_ADDR size, pv_t value) +{ + struct m32c_prologue *prologue = (struct m32c_prologue *) prologue_untyped; + struct gdbarch *arch = prologue->arch; + struct gdbarch_tdep *tdep = gdbarch_tdep (arch); + + /* Is this the unchanged value of some register being saved on the + stack? */ + if (value.kind == pvk_register + && value.k == 0 + && pv_is_register (addr, tdep->sp->num)) + { + /* Some registers require special handling: they're saved as a + larger value than the register itself. */ + CORE_ADDR saved_size = register_size (arch, value.reg); + + if (value.reg == tdep->pc->num) + saved_size = tdep->ret_addr_bytes; + else if (gdbarch_register_type (arch, value.reg) + == tdep->data_addr_reg_type) + saved_size = tdep->push_addr_bytes; + + if (size == saved_size) + { + /* Find which end of the saved value corresponds to our + register. */ + if (gdbarch_byte_order (arch) == BFD_ENDIAN_BIG) + prologue->reg_offset[value.reg] + = (addr.k + saved_size - register_size (arch, value.reg)); + else + prologue->reg_offset[value.reg] = addr.k; + } + } +} + + +/* Analyze the function prologue for ARCH at START, going no further + than LIMIT, and place a description of what we found in + PROLOGUE. */ +void +m32c_analyze_prologue (struct gdbarch *arch, + CORE_ADDR start, CORE_ADDR limit, + struct m32c_prologue *prologue) +{ + struct gdbarch_tdep *tdep = gdbarch_tdep (arch); + unsigned long mach = gdbarch_bfd_arch_info (arch)->mach; + CORE_ADDR after_last_frame_related_insn; + struct cleanup *back_to; + struct m32c_pv_state st; + + st.arch = arch; + st.r0 = pv_register (tdep->r0->num, 0); + st.r1 = pv_register (tdep->r1->num, 0); + st.r2 = pv_register (tdep->r2->num, 0); + st.r3 = pv_register (tdep->r3->num, 0); + st.a0 = pv_register (tdep->a0->num, 0); + st.a1 = pv_register (tdep->a1->num, 0); + st.sb = pv_register (tdep->sb->num, 0); + st.fb = pv_register (tdep->fb->num, 0); + st.sp = pv_register (tdep->sp->num, 0); + st.pc = pv_register (tdep->pc->num, 0); + st.stack = make_pv_area (tdep->sp->num); + back_to = make_cleanup_free_pv_area (st.stack); + + /* Record that the call instruction has saved the return address on + the stack. */ + m32c_pv_push (&st, st.pc, tdep->ret_addr_bytes); + + memset (prologue, 0, sizeof (*prologue)); + prologue->arch = arch; + { + int i; + for (i = 0; i < M32C_MAX_NUM_REGS; i++) + prologue->reg_offset[i] = 1; + } + + st.scan_pc = after_last_frame_related_insn = start; + + while (st.scan_pc < limit) + { + pv_t pre_insn_fb = st.fb; + pv_t pre_insn_sp = st.sp; + + /* In theory we could get in trouble by trying to read ahead + here, when we only know we're expecting one byte. In + practice I doubt anyone will care, and it makes the rest of + the code easier. */ + if (target_read_memory (st.scan_pc, st.insn, sizeof (st.insn))) + /* If we can't fetch the instruction from memory, stop here + and hope for the best. */ + break; + st.next_addr = st.scan_pc; + + /* The assembly instructions are written as they appear in the + section of the processor manuals that describe the + instruction encodings. + + When a single assembly language instruction has several + different machine-language encodings, the manual + distinguishes them by a number in parens, before the + mnemonic. Those numbers are included, as well. + + The srcdest decoding instructions have the same names as the + analogous functions in the simulator. */ + if (mach == bfd_mach_m16c) + { + /* (1) ENTER #imm8 */ + if (st.insn[0] == 0x7c && st.insn[1] == 0xf2) + { + if (m32c_pv_enter (&st, st.insn[2])) + break; + st.next_addr += 3; + } + /* (1) PUSHM src */ + else if (st.insn[0] == 0xec) + { + int src = st.insn[1]; + if (m32c_pv_pushm (&st, src)) + break; + st.next_addr += 2; + + if (m32c_pushm_is_reg_save (&st, src)) + after_last_frame_related_insn = st.next_addr; + } + + /* (6) MOV.size:G src, dest */ + else if ((st.insn[0] & 0xfe) == 0x72) + { + int size = (st.insn[0] & 0x01) ? 2 : 1; + + st.next_addr += 2; + + struct srcdest src + = m32c_decode_srcdest4 (&st, (st.insn[1] >> 4) & 0xf, size); + struct srcdest dest + = m32c_decode_srcdest4 (&st, st.insn[1] & 0xf, size); + pv_t src_value = m32c_srcdest_fetch (&st, src, size); + + if (m32c_is_arg_spill (&st, dest, src_value)) + after_last_frame_related_insn = st.next_addr; + else if (m32c_is_struct_return (&st, dest, src_value)) + after_last_frame_related_insn = st.next_addr; + + if (m32c_srcdest_store (&st, dest, src_value, size)) + break; + } + + /* (1) LDC #IMM16, sp */ + else if (st.insn[0] == 0xeb + && st.insn[1] == 0x50) + { + st.next_addr += 2; + st.sp = pv_constant (m32c_udisp16 (&st)); + } + + else + /* We've hit some instruction we don't know how to simulate. + Strictly speaking, we should set every value we're + tracking to "unknown". But we'll be optimistic, assume + that we have enough information already, and stop + analysis here. */ + break; + } + else + { + int src_indirect = 0; + int dest_indirect = 0; + int i = 0; + + gdb_assert (mach == bfd_mach_m32c); + + /* Check for prefix bytes indicating indirect addressing. */ + if (st.insn[0] == 0x41) + { + src_indirect = 1; + i++; + } + else if (st.insn[0] == 0x09) + { + dest_indirect = 1; + i++; + } + else if (st.insn[0] == 0x49) + { + src_indirect = dest_indirect = 1; + i++; + } + + /* (1) ENTER #imm8 */ + if (st.insn[i] == 0xec) + { + if (m32c_pv_enter (&st, st.insn[i + 1])) + break; + st.next_addr += 2; + } + + /* (1) PUSHM src */ + else if (st.insn[i] == 0x8f) + { + int src = st.insn[i + 1]; + if (m32c_pv_pushm (&st, src)) + break; + st.next_addr += 2; + + if (m32c_pushm_is_reg_save (&st, src)) + after_last_frame_related_insn = st.next_addr; + } + + /* (7) MOV.size:G src, dest */ + else if ((st.insn[i] & 0x80) == 0x80 + && (st.insn[i + 1] & 0x0f) == 0x0b + && m32c_get_src23 (&st.insn[i]) < 20 + && m32c_get_dest23 (&st.insn[i]) < 20) + { + int bw = st.insn[i] & 0x01; + int size = bw ? 2 : 1; + + st.next_addr += 2; + + struct srcdest src + = m32c_decode_sd23 (&st, m32c_get_src23 (&st.insn[i]), + size, src_indirect); + struct srcdest dest + = m32c_decode_sd23 (&st, m32c_get_dest23 (&st.insn[i]), + size, dest_indirect); + pv_t src_value = m32c_srcdest_fetch (&st, src, size); + + if (m32c_is_arg_spill (&st, dest, src_value)) + after_last_frame_related_insn = st.next_addr; + + if (m32c_srcdest_store (&st, dest, src_value, size)) + break; + } + /* (2) LDC #IMM24, sp */ + else if (st.insn[i] == 0xd5 + && st.insn[i + 1] == 0x29) + { + st.next_addr += 2; + st.sp = pv_constant (m32c_udisp24 (&st)); + } + else + /* We've hit some instruction we don't know how to simulate. + Strictly speaking, we should set every value we're + tracking to "unknown". But we'll be optimistic, assume + that we have enough information already, and stop + analysis here. */ + break; + } + + /* If this instruction changed the FB or decreased the SP (i.e., + allocated more stack space), then this may be a good place to + declare the prologue finished. However, there are some + exceptions: + + - If the instruction just changed the FB back to its original + value, then that's probably a restore instruction. The + prologue should definitely end before that. + + - If the instruction increased the value of the SP (that is, + shrunk the frame), then it's probably part of a frame + teardown sequence, and the prologue should end before + that. */ + + if (! pv_is_identical (st.fb, pre_insn_fb)) + { + if (! pv_is_register_k (st.fb, tdep->fb->num, 0)) + after_last_frame_related_insn = st.next_addr; + } + else if (! pv_is_identical (st.sp, pre_insn_sp)) + { + /* The comparison of the constants looks odd, there, because + .k is unsigned. All it really means is that the SP is + lower than it was before the instruction. */ + if ( pv_is_register (pre_insn_sp, tdep->sp->num) + && pv_is_register (st.sp, tdep->sp->num) + && ((pre_insn_sp.k - st.sp.k) < (st.sp.k - pre_insn_sp.k))) + after_last_frame_related_insn = st.next_addr; + } + + st.scan_pc = st.next_addr; + } + + /* Did we load a constant value into the stack pointer? */ + if (pv_is_constant (st.sp)) + prologue->kind = prologue_first_frame; + + /* Alternatively, did we initialize the frame pointer? Remember + that the CFA is the address after the return address. */ + if (pv_is_register (st.fb, tdep->sp->num)) + { + prologue->kind = prologue_with_frame_ptr; + prologue->frame_ptr_offset = st.fb.k; + } + + /* Is the frame size a known constant? Remember that frame_size is + actually the offset from the CFA to the SP (i.e., a negative + value). */ + else if (pv_is_register (st.sp, tdep->sp->num)) + { + prologue->kind = prologue_sans_frame_ptr; + prologue->frame_size = st.sp.k; + } + + /* We haven't been able to make sense of this function's frame. Treat + it as the first frame. */ + else + prologue->kind = prologue_first_frame; + + /* Record where all the registers were saved. */ + pv_area_scan (st.stack, check_for_saved, (void *) prologue); + + prologue->prologue_end = after_last_frame_related_insn; + + do_cleanups (back_to); +} + + +static CORE_ADDR +m32c_skip_prologue (CORE_ADDR ip) +{ + char *name; + CORE_ADDR func_addr, func_end, sal_end; + struct m32c_prologue p; + + /* Try to find the extent of the function that contains IP. */ + if (! find_pc_partial_function (ip, &name, &func_addr, &func_end)) + return ip; + + /* Find end by prologue analysis. */ + m32c_analyze_prologue (current_gdbarch, ip, func_end, &p); + /* Find end by line info. */ + sal_end = skip_prologue_using_sal (ip); + /* Return whichever is lower. */ + if (sal_end != 0 && sal_end != ip && sal_end < p.prologue_end) + return sal_end; + else + return p.prologue_end; +} + + + +/* Stack unwinding. */ + +static struct m32c_prologue * +m32c_analyze_frame_prologue (struct frame_info *next_frame, + void **this_prologue_cache) +{ + if (! *this_prologue_cache) + { + CORE_ADDR func_start = frame_func_unwind (next_frame); + CORE_ADDR stop_addr = frame_pc_unwind (next_frame); + + /* If we couldn't find any function containing the PC, then + just initialize the prologue cache, but don't do anything. */ + if (! func_start) + stop_addr = func_start; + + *this_prologue_cache = FRAME_OBSTACK_ZALLOC (struct m32c_prologue); + m32c_analyze_prologue (get_frame_arch (next_frame), + func_start, stop_addr, *this_prologue_cache); + } + + return *this_prologue_cache; +} + + +static CORE_ADDR +m32c_frame_base (struct frame_info *next_frame, + void **this_prologue_cache) +{ + struct m32c_prologue *p + = m32c_analyze_frame_prologue (next_frame, this_prologue_cache); + struct gdbarch_tdep *tdep = gdbarch_tdep (get_frame_arch (next_frame)); + + /* In functions that use alloca, the distance between the stack + pointer and the frame base varies dynamically, so we can't use + the SP plus static information like prologue analysis to find the + frame base. However, such functions must have a frame pointer, + to be able to restore the SP on exit. So whenever we do have a + frame pointer, use that to find the base. */ + switch (p->kind) + { + case prologue_with_frame_ptr: + { + CORE_ADDR fb + = frame_unwind_register_unsigned (next_frame, tdep->fb->num); + return fb - p->frame_ptr_offset; + } + + case prologue_sans_frame_ptr: + { + CORE_ADDR sp + = frame_unwind_register_unsigned (next_frame, tdep->sp->num); + return sp - p->frame_size; + } + + case prologue_first_frame: + return 0; + + default: + gdb_assert (0); + } +} + + +static void +m32c_this_id (struct frame_info *next_frame, + void **this_prologue_cache, + struct frame_id *this_id) +{ + CORE_ADDR base = m32c_frame_base (next_frame, this_prologue_cache); + + if (base) + *this_id = frame_id_build (base, frame_func_unwind (next_frame)); + /* Otherwise, leave it unset, and that will terminate the backtrace. */ +} + + +static void +m32c_prev_register (struct frame_info *next_frame, + void **this_prologue_cache, + int regnum, int *optimizedp, + enum lval_type *lvalp, CORE_ADDR *addrp, + int *realnump, gdb_byte *bufferp) +{ + struct gdbarch_tdep *tdep = gdbarch_tdep (get_frame_arch (next_frame)); + struct m32c_prologue *p + = m32c_analyze_frame_prologue (next_frame, this_prologue_cache); + CORE_ADDR frame_base = m32c_frame_base (next_frame, this_prologue_cache); + int reg_size = register_size (get_frame_arch (next_frame), regnum); + + if (regnum == tdep->sp->num) + { + *optimizedp = 0; + *lvalp = not_lval; + *addrp = 0; + *realnump = -1; + if (bufferp) + store_unsigned_integer (bufferp, reg_size, frame_base); + } + + /* If prologue analysis says we saved this register somewhere, + return a description of the stack slot holding it. */ + else if (p->reg_offset[regnum] != 1) + { + *optimizedp = 0; + *lvalp = lval_memory; + *addrp = frame_base + p->reg_offset[regnum]; + *realnump = -1; + if (bufferp) + get_frame_memory (next_frame, *addrp, bufferp, reg_size); + } + + /* Otherwise, presume we haven't changed the value of this + register, and get it from the next frame. */ + else + frame_register_unwind (next_frame, regnum, + optimizedp, lvalp, addrp, realnump, bufferp); +} + + +static const struct frame_unwind m32c_unwind = { + NORMAL_FRAME, + m32c_this_id, + m32c_prev_register +}; + + +static const struct frame_unwind * +m32c_frame_sniffer (struct frame_info *next_frame) +{ + return &m32c_unwind; +} + + +static CORE_ADDR +m32c_unwind_pc (struct gdbarch *arch, struct frame_info *next_frame) +{ + struct gdbarch_tdep *tdep = gdbarch_tdep (arch); + return frame_unwind_register_unsigned (next_frame, tdep->pc->num); +} + + +static CORE_ADDR +m32c_unwind_sp (struct gdbarch *arch, struct frame_info *next_frame) +{ + struct gdbarch_tdep *tdep = gdbarch_tdep (arch); + return frame_unwind_register_unsigned (next_frame, tdep->sp->num); +} + + +/* Inferior calls. */ + +/* The calling conventions, according to GCC: + + r8c, m16c + --------- + First arg may be passed in r1l or r1 if it (1) fits (QImode or + HImode), (2) is named, and (3) is an integer or pointer type (no + structs, floats, etc). Otherwise, it's passed on the stack. + + Second arg may be passed in r2, same restrictions (but not QImode), + even if the first arg is passed on the stack. + + Third and further args are passed on the stack. No padding is + used, stack "alignment" is 8 bits. + + m32cm, m32c + ----------- + + First arg may be passed in r0l or r0, same restrictions as above. + + Second and further args are passed on the stack. Padding is used + after QImode parameters (i.e. lower-addressed byte is the value, + higher-addressed byte is the padding), stack "alignment" is 16 + bits. */ + + +/* Return true if TYPE is a type that can be passed in registers. (We + ignore the size, and pay attention only to the type code; + acceptable sizes depends on which register is being considered to + hold it.) */ +static int +m32c_reg_arg_type (struct type *type) +{ + enum type_code code = TYPE_CODE (type); + + return (code == TYPE_CODE_INT + || code == TYPE_CODE_ENUM + || code == TYPE_CODE_PTR + || code == TYPE_CODE_REF + || code == TYPE_CODE_BOOL + || code == TYPE_CODE_CHAR); +} + + +static CORE_ADDR +m32c_push_dummy_call (struct gdbarch *gdbarch, struct value *function, + struct regcache *regcache, CORE_ADDR bp_addr, int nargs, + struct value **args, CORE_ADDR sp, int struct_return, + CORE_ADDR struct_addr) +{ + struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); + unsigned long mach = gdbarch_bfd_arch_info (gdbarch)->mach; + CORE_ADDR cfa; + int i; + + /* The number of arguments given in this function's prototype, or + zero if it has a non-prototyped function type. The m32c ABI + passes arguments mentioned in the prototype differently from + those in the ellipsis of a varargs function, or from those passed + to a non-prototyped function. */ + int num_prototyped_args = 0; + + { + struct type *func_type = value_type (function); + + gdb_assert (TYPE_CODE (func_type) == TYPE_CODE_FUNC || + TYPE_CODE (func_type) == TYPE_CODE_METHOD); + +#if 0 + /* The ABI description in gcc/config/m32c/m32c.abi says that + we need to handle prototyped and non-prototyped functions + separately, but the code in GCC doesn't actually do so. */ + if (TYPE_PROTOTYPED (func_type)) +#endif + num_prototyped_args = TYPE_NFIELDS (func_type); + } + + /* First, if the function returns an aggregate by value, push a + pointer to a buffer for it. This doesn't affect the way + subsequent arguments are allocated to registers. */ + if (struct_return) + { + int ptr_len = TYPE_LENGTH (tdep->ptr_voyd); + sp -= ptr_len; + write_memory_unsigned_integer (sp, ptr_len, struct_addr); + } + + /* Push the arguments. */ + for (i = nargs - 1; i >= 0; i--) + { + struct value *arg = args[i]; + const gdb_byte *arg_bits = value_contents (arg); + struct type *arg_type = value_type (arg); + ULONGEST arg_size = TYPE_LENGTH (arg_type); + + /* Can it go in r1 or r1l (for m16c) or r0 or r0l (for m32c)? */ + if (i == 0 + && arg_size <= 2 + && i < num_prototyped_args + && m32c_reg_arg_type (arg_type)) + { + /* Extract and re-store as an integer as a terse way to make + sure it ends up in the least significant end of r1. (GDB + should avoid assuming endianness, even on uni-endian + processors.) */ + ULONGEST u = extract_unsigned_integer (arg_bits, arg_size); + struct m32c_reg *reg = (mach == bfd_mach_m16c) ? tdep->r1 : tdep->r0; + regcache_cooked_write_unsigned (regcache, reg->num, u); + } + + /* Can it go in r2? */ + else if (mach == bfd_mach_m16c + && i == 1 + && arg_size == 2 + && i < num_prototyped_args + && m32c_reg_arg_type (arg_type)) + regcache_cooked_write (regcache, tdep->r2->num, arg_bits); + + /* Everything else goes on the stack. */ + else + { + sp -= arg_size; + + /* Align the stack. */ + if (mach == bfd_mach_m32c) + sp &= ~1; + + write_memory (sp, arg_bits, arg_size); + } + } + + /* This is the CFA we use to identify the dummy frame. */ + cfa = sp; + + /* Push the return address. */ + sp -= tdep->ret_addr_bytes; + write_memory_unsigned_integer (sp, tdep->ret_addr_bytes, bp_addr); + + /* Update the stack pointer. */ + regcache_cooked_write_unsigned (regcache, tdep->sp->num, sp); + + /* We need to borrow an odd trick from the i386 target here. + + The value we return from this function gets used as the stack + address (the CFA) for the dummy frame's ID. The obvious thing is + to return the new TOS. However, that points at the return + address, saved on the stack, which is inconsistent with the CFA's + described by GCC's DWARF 2 .debug_frame information: DWARF 2 + .debug_frame info uses the address immediately after the saved + return address. So you end up with a dummy frame whose CFA + points at the return address, but the frame for the function + being called has a CFA pointing after the return address: the + younger CFA is *greater than* the older CFA. The sanity checks + in frame.c don't like that. + + So we try to be consistent with the CFA's used by DWARF 2. + Having a dummy frame and a real frame with the *same* CFA is + tolerable. */ + return cfa; +} + + +static struct frame_id +m32c_unwind_dummy_id (struct gdbarch *gdbarch, struct frame_info *next_frame) +{ + /* This needs to return a frame ID whose PC is the return address + passed to m32c_push_dummy_call, and whose stack_addr is the SP + m32c_push_dummy_call returned. + + m32c_unwind_sp gives us the CFA, which is the value the SP had + before the return address was pushed. */ + return frame_id_build (m32c_unwind_sp (gdbarch, next_frame), + frame_pc_unwind (next_frame)); +} + + + +/* Return values. */ + +/* Return value conventions, according to GCC: + + r8c, m16c + --------- + + QImode in r0l + HImode in r0 + SImode in r2r0 + near pointer in r0 + far pointer in r2r0 + + Aggregate values (regardless of size) are returned by pushing a + pointer to a temporary area on the stack after the args are pushed. + The function fills in this area with the value. Note that this + pointer on the stack does not affect how register arguments, if any, + are configured. + + m32cm, m32c + ----------- + Same. */ + +/* Return non-zero if values of type TYPE are returned by storing them + in a buffer whose address is passed on the stack, ahead of the + other arguments. */ +static int +m32c_return_by_passed_buf (struct type *type) +{ + enum type_code code = TYPE_CODE (type); + + return (code == TYPE_CODE_STRUCT + || code == TYPE_CODE_UNION); +} + +static enum return_value_convention +m32c_return_value (struct gdbarch *gdbarch, + struct type *valtype, + struct regcache *regcache, + gdb_byte *readbuf, + const gdb_byte *writebuf) +{ + struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); + enum return_value_convention conv; + ULONGEST valtype_len = TYPE_LENGTH (valtype); + + if (m32c_return_by_passed_buf (valtype)) + conv = RETURN_VALUE_STRUCT_CONVENTION; + else + conv = RETURN_VALUE_REGISTER_CONVENTION; + + if (readbuf) + { + /* We should never be called to find values being returned by + RETURN_VALUE_STRUCT_CONVENTION. Those can't be located, + unless we made the call ourselves. */ + gdb_assert (conv == RETURN_VALUE_REGISTER_CONVENTION); + + gdb_assert (valtype_len <= 8); + + /* Anything that fits in r0 is returned there. */ + if (valtype_len <= TYPE_LENGTH (tdep->r0->type)) + { + ULONGEST u; + regcache_cooked_read_unsigned (regcache, tdep->r0->num, &u); + store_unsigned_integer (readbuf, valtype_len, u); + } + else + { + /* Everything else is passed in mem0, using as many bytes as + needed. This is not what the Renesas tools do, but it's + what GCC does at the moment. */ + struct minimal_symbol *mem0 + = lookup_minimal_symbol ("mem0", NULL, NULL); + + if (! mem0) + error ("The return value is stored in memory at 'mem0', " + "but GDB cannot find\n" + "its address."); + read_memory (SYMBOL_VALUE_ADDRESS (mem0), readbuf, valtype_len); + } + } + + if (writebuf) + { + /* We should never be called to store values to be returned + using RETURN_VALUE_STRUCT_CONVENTION. We have no way of + finding the buffer, unless we made the call ourselves. */ + gdb_assert (conv == RETURN_VALUE_REGISTER_CONVENTION); + + gdb_assert (valtype_len <= 8); + + /* Anything that fits in r0 is returned there. */ + if (valtype_len <= TYPE_LENGTH (tdep->r0->type)) + { + ULONGEST u = extract_unsigned_integer (writebuf, valtype_len); + regcache_cooked_write_unsigned (regcache, tdep->r0->num, u); + } + else + { + /* Everything else is passed in mem0, using as many bytes as + needed. This is not what the Renesas tools do, but it's + what GCC does at the moment. */ + struct minimal_symbol *mem0 + = lookup_minimal_symbol ("mem0", NULL, NULL); + + if (! mem0) + error ("The return value is stored in memory at 'mem0', " + "but GDB cannot find\n" + " its address."); + write_memory (SYMBOL_VALUE_ADDRESS (mem0), + (char *) writebuf, valtype_len); + } + } + + return conv; +} + + + +/* Trampolines. */ + +/* The m16c and m32c use a trampoline function for indirect function + calls. An indirect call looks like this: + + ... push arguments ... + ... push target function address ... + jsr.a m32c_jsri16 + + The code for m32c_jsri16 looks like this: + + m32c_jsri16: + + # Save return address. + pop.w m32c_jsri_ret + pop.b m32c_jsri_ret+2 + + # Store target function address. + pop.w m32c_jsri_addr + + # Re-push return address. + push.b m32c_jsri_ret+2 + push.w m32c_jsri_ret + + # Call the target function. + jmpi.a m32c_jsri_addr + + Without further information, GDB will treat calls to m32c_jsri16 + like calls to any other function. Since m32c_jsri16 doesn't have + debugging information, that normally means that GDB sets a step- + resume breakpoint and lets the program continue --- which is not + what the user wanted. (Giving the trampoline debugging info + doesn't help: the user expects the program to stop in the function + their program is calling, not in some trampoline code they've never + seen before.) + + The SKIP_TRAMPOLINE_CODE gdbarch method tells GDB how to step + through such trampoline functions transparently to the user. When + given the address of a trampoline function's first instruction, + SKIP_TRAMPOLINE_CODE should return the address of the first + instruction of the function really being called. If GDB decides it + wants to step into that function, it will set a breakpoint there + and silently continue to it. + + We recognize the trampoline by name, and extract the target address + directly from the stack. This isn't great, but recognizing by its + code sequence seems more fragile. */ + +static CORE_ADDR +m32c_skip_trampoline_code (CORE_ADDR stop_pc) +{ + struct gdbarch_tdep *tdep = gdbarch_tdep (current_gdbarch); + + /* It would be nicer to simply look up the addresses of known + trampolines once, and then compare stop_pc with them. However, + we'd need to ensure that that cached address got invalidated when + someone loaded a new executable, and I'm not quite sure of the + best way to do that. find_pc_partial_function does do some + caching, so we'll see how this goes. */ + char *name; + CORE_ADDR start, end; + + if (find_pc_partial_function (stop_pc, &name, &start, &end)) + { + /* Are we stopped at the beginning of the trampoline function? */ + if (strcmp (name, "m32c_jsri16") == 0 + && stop_pc == start) + { + /* Get the stack pointer. The return address is at the top, + and the target function's address is just below that. We + know it's a two-byte address, since the trampoline is + m32c_jsri*16*. */ + CORE_ADDR sp = get_frame_sp (get_current_frame ()); + CORE_ADDR target + = read_memory_unsigned_integer (sp + tdep->ret_addr_bytes, 2); + + /* What we have now is the address of a jump instruction. + What we need is the destination of that jump. + The opcode is 1 byte, and the destination is the next 3 bytes. + */ + target = read_memory_unsigned_integer (target + 1, 3); + return target; + } + } + + return 0; +} + + +/* Address/pointer conversions. */ + +/* On the m16c, there is a 24-bit address space, but only a very few + instructions can generate addresses larger than 0xffff: jumps, + jumps to subroutines, and the lde/std (load/store extended) + instructions. + + Since GCC can only support one size of pointer, we can't have + distinct 'near' and 'far' pointer types; we have to pick one size + for everything. If we wanted to use 24-bit pointers, then GCC + would have to use lde and ste for all memory references, which + would be terrible for performance and code size. So the GNU + toolchain uses 16-bit pointers for everything, and gives up the + ability to have pointers point outside the first 64k of memory. + + However, as a special hack, we let the linker place functions at + addresses above 0xffff, as long as it also places a trampoline in + the low 64k for every function whose address is taken. Each + trampoline consists of a single jmp.a instruction that jumps to the + function's real entry point. Pointers to functions can be 16 bits + long, even though the functions themselves are at higher addresses: + the pointers refer to the trampolines, not the functions. + + This complicates things for GDB, however: given the address of a + function (from debug info or linker symbols, say) which could be + anywhere in the 24-bit address space, how can we find an + appropriate 16-bit value to use as a pointer to it? + + If the linker has not generated a trampoline for the function, + we're out of luck. Well, I guess we could malloc some space and + write a jmp.a instruction to it, but I'm not going to get into that + at the moment. + + If the linker has generated a trampoline for the function, then it + also emitted a symbol for the trampoline: if the function's linker + symbol is named NAME, then the function's trampoline's linker + symbol is named NAME.plt. + + So, given a code address: + - We try to find a linker symbol at that address. + - If we find such a symbol named NAME, we look for a linker symbol + named NAME.plt. + - If we find such a symbol, we assume it is a trampoline, and use + its address as the pointer value. + + And, given a function pointer: + - We try to find a linker symbol at that address named NAME.plt. + - If we find such a symbol, we look for a linker symbol named NAME. + - If we find that, we provide that as the function's address. + - If any of the above steps fail, we return the original address + unchanged; it might really be a function in the low 64k. + + See? You *knew* there was a reason you wanted to be a computer + programmer! :) */ + +static void +m32c_m16c_address_to_pointer (struct type *type, gdb_byte *buf, CORE_ADDR addr) +{ + gdb_assert (TYPE_CODE (type) == TYPE_CODE_PTR || + TYPE_CODE (type) == TYPE_CODE_REF); + + enum type_code target_code = TYPE_CODE (TYPE_TARGET_TYPE (type)); + + if (target_code == TYPE_CODE_FUNC || target_code == TYPE_CODE_METHOD) + { + /* Try to find a linker symbol at this address. */ + struct minimal_symbol *func_msym = lookup_minimal_symbol_by_pc (addr); + + if (! func_msym) + error ("Cannot convert code address %s to function pointer:\n" + "couldn't find a symbol at that address, to find trampoline.", + paddr_nz (addr)); + + char *func_name = SYMBOL_LINKAGE_NAME (func_msym); + char *tramp_name = xmalloc (strlen (func_name) + 5); + strcpy (tramp_name, func_name); + strcat (tramp_name, ".plt"); + + /* Try to find a linker symbol for the trampoline. */ + struct minimal_symbol *tramp_msym + = lookup_minimal_symbol (tramp_name, NULL, NULL); + + /* We've either got another copy of the name now, or don't need + the name any more. */ + xfree (tramp_name); + + if (! tramp_msym) + error ("Cannot convert code address %s to function pointer:\n" + "couldn't find trampoline named '%s.plt'.", + paddr_nz (addr), func_name); + + /* The trampoline's address is our pointer. */ + addr = SYMBOL_VALUE_ADDRESS (tramp_msym); + } + + store_unsigned_integer (buf, TYPE_LENGTH (type), addr); +} + + +static CORE_ADDR +m32c_m16c_pointer_to_address (struct type *type, const gdb_byte *buf) +{ + gdb_assert (TYPE_CODE (type) == TYPE_CODE_PTR || + TYPE_CODE (type) == TYPE_CODE_REF); + + CORE_ADDR ptr = extract_unsigned_integer (buf, TYPE_LENGTH (type)); + + enum type_code target_code = TYPE_CODE (TYPE_TARGET_TYPE (type)); + + if (target_code == TYPE_CODE_FUNC || target_code == TYPE_CODE_METHOD) + { + /* See if there is a minimal symbol at that address whose name is + "NAME.plt". */ + struct minimal_symbol *ptr_msym = lookup_minimal_symbol_by_pc (ptr); + + if (ptr_msym) + { + char *ptr_msym_name = SYMBOL_LINKAGE_NAME (ptr_msym); + int len = strlen (ptr_msym_name); + + if (len > 4 + && strcmp (ptr_msym_name + len - 4, ".plt") == 0) + { + /* We have a .plt symbol; try to find the symbol for the + corresponding function. + + Since the trampoline contains a jump instruction, we + could also just extract the jump's target address. I + don't see much advantage one way or the other. */ + char *func_name = xmalloc (len - 4 + 1); + memcpy (func_name, ptr_msym_name, len - 4); + func_name[len - 4] = '\0'; + struct minimal_symbol *func_msym + = lookup_minimal_symbol (func_name, NULL, NULL); + + /* If we do have such a symbol, return its value as the + function's true address. */ + if (func_msym) + ptr = SYMBOL_VALUE_ADDRESS (func_msym); + } + } + } + + return ptr; +} + + + +/* Initialization. */ + +static struct gdbarch * +m32c_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) +{ + struct gdbarch *arch; + struct gdbarch_tdep *tdep; + unsigned long mach = info.bfd_arch_info->mach; + + /* Find a candidate among the list of architectures we've created + already. */ + for (arches = gdbarch_list_lookup_by_info (arches, &info); + arches != NULL; + arches = gdbarch_list_lookup_by_info (arches->next, &info)) + return arches->gdbarch; + + tdep = xcalloc (1, sizeof (*tdep)); + arch = gdbarch_alloc (&info, tdep); + + /* Essential types. */ + make_types (arch); + + /* Address/pointer conversions. */ + if (mach == bfd_mach_m16c) + { + set_gdbarch_address_to_pointer (arch, m32c_m16c_address_to_pointer); + set_gdbarch_pointer_to_address (arch, m32c_m16c_pointer_to_address); + } + + /* Register set. */ + make_regs (arch); + + /* Disassembly. */ + set_gdbarch_print_insn (arch, print_insn_m32c); + + /* Breakpoints. */ + set_gdbarch_breakpoint_from_pc (arch, m32c_breakpoint_from_pc); + + /* Prologue analysis and unwinding. */ + set_gdbarch_inner_than (arch, core_addr_lessthan); + set_gdbarch_skip_prologue (arch, m32c_skip_prologue); + set_gdbarch_unwind_pc (arch, m32c_unwind_pc); + set_gdbarch_unwind_sp (arch, m32c_unwind_sp); +#if 0 + /* I'm dropping the dwarf2 sniffer because it has a few problems. + They may be in the dwarf2 cfi code in GDB, or they may be in + the debug info emitted by the upstream toolchain. I don't + know which, but I do know that the prologue analyzer works better. + MVS 04/13/06 + */ + frame_unwind_append_sniffer (arch, dwarf2_frame_sniffer); +#endif + frame_unwind_append_sniffer (arch, m32c_frame_sniffer); + + /* Inferior calls. */ + set_gdbarch_push_dummy_call (arch, m32c_push_dummy_call); + set_gdbarch_return_value (arch, m32c_return_value); + set_gdbarch_unwind_dummy_id (arch, m32c_unwind_dummy_id); + + /* Trampolines. */ + set_gdbarch_skip_trampoline_code (arch, m32c_skip_trampoline_code); + + return arch; +} + + +void +_initialize_m32c_tdep (void) +{ + register_gdbarch_init (bfd_arch_m32c, m32c_gdbarch_init); + + m32c_dma_reggroup = reggroup_new ("dma", USER_REGGROUP); +} diff --git a/gdb/mingw-hdep.c b/gdb/mingw-hdep.c index 79b23dc..bb0f50a 100644 --- a/gdb/mingw-hdep.c +++ b/gdb/mingw-hdep.c @@ -167,6 +167,10 @@ gdb_select (int n, fd_set *readfds, fd_set *writefds, fd_set *exceptfds, for (fd = 0, indx = 0; fd < n; ++fd) { HANDLE fd_h; + struct serial *scb; + + if (!FD_ISSET (fd, readfds) && !FD_ISSET (fd, writefds)) + continue; if (FD_ISSET (fd, readfds)) { @@ -189,6 +193,12 @@ gdb_select (int n, fd_set *readfds, fd_set *writefds, fd_set *exceptfds, else num_ready++; } + + /* We created at least one event handle for this fd. Let the + device know we are finished with it. */ + scb = serial_for_fd (fd); + if (scb) + serial_done_wait_handle (scb); } return num_ready; diff --git a/gdb/mips-mdebug-tdep.c b/gdb/mips-mdebug-tdep.c index db79713..06cfba5 100644 --- a/gdb/mips-mdebug-tdep.c +++ b/gdb/mips-mdebug-tdep.c @@ -394,7 +394,7 @@ mips_mdebug_frame_prev_register (struct frame_info *next_frame, void **this_cache, int regnum, int *optimizedp, enum lval_type *lvalp, CORE_ADDR *addrp, - int *realnump, void *valuep) + int *realnump, gdb_byte *valuep) { struct mips_frame_cache *info = mips_mdebug_frame_cache (next_frame, this_cache); diff --git a/gdb/ppcnbsd-tdep.c b/gdb/ppcnbsd-tdep.c index 9547fcd..57ba742 100644 --- a/gdb/ppcnbsd-tdep.c +++ b/gdb/ppcnbsd-tdep.c @@ -246,8 +246,8 @@ static struct core_fns ppcnbsd_elfcore_fns = static enum return_value_convention ppcnbsd_return_value (struct gdbarch *gdbarch, struct type *valtype, - struct regcache *regcache, void *readbuf, - const void *writebuf) + struct regcache *regcache, gdb_byte *readbuf, + const gdb_byte *writebuf) { if ((TYPE_CODE (valtype) == TYPE_CODE_STRUCT || TYPE_CODE (valtype) == TYPE_CODE_UNION) diff --git a/gdb/remote.c b/gdb/remote.c index 22581a5..d1ffdb5 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -973,7 +973,7 @@ typedef unsigned char threadref[OPAQUETHREADBYTES]; typedef int gdb_threadref; /* Internal GDB thread reference. */ /* gdb_ext_thread_info is an internal GDB data structure which is - equivalint to the reply of the remote threadinfo packet. */ + equivalent to the reply of the remote threadinfo packet. */ struct gdb_ext_thread_info { diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c index f932b4c..f22236c 100644 --- a/gdb/rs6000-tdep.c +++ b/gdb/rs6000-tdep.c @@ -59,7 +59,6 @@ #include "frame-unwind.h" #include "frame-base.h" -#include "reggroups.h" #include "rs6000-tdep.h" /* If the kernel has to deliver a signal, it pushes a sigcontext diff --git a/gdb/ser-mingw.c b/gdb/ser-mingw.c index 7a6f232..79e186b 100644 --- a/gdb/ser-mingw.c +++ b/gdb/ser-mingw.c @@ -26,6 +26,7 @@ #include "ser-tcp.h" #include <windows.h> +#include <conio.h> #include <fcntl.h> #include <unistd.h> @@ -350,23 +351,22 @@ struct ser_console_state HANDLE start_select; HANDLE stop_select; + HANDLE exit_select; + HANDLE have_stopped; + + HANDLE thread; }; static DWORD WINAPI console_select_thread (void *arg) { struct serial *scb = arg; - struct ser_console_state *state, state_copy; - int event_index, fd; + struct ser_console_state *state; + int event_index; HANDLE h; - /* Copy useful information out of the control block, to make sure - that we do not race with freeing it. */ - state_copy = *(struct ser_console_state *) scb->state; - state = &state_copy; - fd = scb->fd; - - h = (HANDLE) _get_osfhandle (fd); + state = scb->state; + h = (HANDLE) _get_osfhandle (scb->fd); while (1) { @@ -374,14 +374,15 @@ console_select_thread (void *arg) INPUT_RECORD record; DWORD n_records; + SetEvent (state->have_stopped); + wait_events[0] = state->start_select; - wait_events[1] = state->stop_select; + wait_events[1] = state->exit_select; if (WaitForMultipleObjects (2, wait_events, FALSE, INFINITE) != WAIT_OBJECT_0) - { - CloseHandle (state->stop_select); - return 0; - } + return 0; + + ResetEvent (state->have_stopped); retry: wait_events[0] = state->stop_select; @@ -391,10 +392,7 @@ console_select_thread (void *arg) if (event_index == WAIT_OBJECT_0 || WaitForSingleObject (state->stop_select, 0) == WAIT_OBJECT_0) - { - CloseHandle (state->stop_select); - return 0; - } + continue; if (event_index != WAIT_OBJECT_0 + 1) { @@ -415,9 +413,30 @@ console_select_thread (void *arg) if (record.EventType == KEY_EVENT && record.Event.KeyEvent.bKeyDown) { - /* This is really a keypress. */ - SetEvent (state->read_event); - continue; + WORD keycode = record.Event.KeyEvent.wVirtualKeyCode; + + /* Ignore events containing only control keys. We must + recognize "enhanced" keys which we are interested in + reading via getch, if they do not map to ASCII. But we + do not want to report input available for e.g. the + control key alone. */ + + if (record.Event.KeyEvent.uChar.AsciiChar != 0 + || keycode == VK_PRIOR + || keycode == VK_NEXT + || keycode == VK_END + || keycode == VK_HOME + || keycode == VK_LEFT + || keycode == VK_UP + || keycode == VK_RIGHT + || keycode == VK_DOWN + || keycode == VK_INSERT + || keycode == VK_DELETE) + { + /* This is really a keypress. */ + SetEvent (state->read_event); + continue; + } } /* Otherwise discard it and wait again. */ @@ -439,31 +458,27 @@ static DWORD WINAPI pipe_select_thread (void *arg) { struct serial *scb = arg; - struct ser_console_state *state, state_copy; - int event_index, fd; + struct ser_console_state *state; + int event_index; HANDLE h; - /* Copy useful information out of the control block, to make sure - that we do not race with freeing it. */ - state_copy = *(struct ser_console_state *) scb->state; - state = &state_copy; - fd = scb->fd; - - h = (HANDLE) _get_osfhandle (fd); + state = scb->state; + h = (HANDLE) _get_osfhandle (scb->fd); while (1) { HANDLE wait_events[2]; DWORD n_avail; + SetEvent (state->have_stopped); + wait_events[0] = state->start_select; - wait_events[1] = state->stop_select; + wait_events[1] = state->exit_select; if (WaitForMultipleObjects (2, wait_events, FALSE, INFINITE) != WAIT_OBJECT_0) - { - CloseHandle (state->stop_select); - return 0; - } + return 0; + + ResetEvent (state->have_stopped); retry: if (!PeekNamedPipe (h, NULL, 0, NULL, &n_avail, NULL)) @@ -478,13 +493,11 @@ pipe_select_thread (void *arg) continue; } - if (WaitForSingleObject (state->stop_select, 0) == WAIT_OBJECT_0) - { - CloseHandle (state->stop_select); - return 0; - } + /* Delay 10ms before checking again, but allow the stop event + to wake us. */ + if (WaitForSingleObject (state->stop_select, 10) == WAIT_OBJECT_0) + continue; - Sleep (10); goto retry; } } @@ -511,29 +524,62 @@ ser_console_wait_handle (struct serial *scb, HANDLE *read, HANDLE *except) memset (state, 0, sizeof (struct ser_console_state)); scb->state = state; - /* Create auto reset events to wake and terminate the select thread. */ + /* Create auto reset events to wake, stop, and exit the select + thread. */ state->start_select = CreateEvent (0, FALSE, FALSE, 0); state->stop_select = CreateEvent (0, FALSE, FALSE, 0); + state->exit_select = CreateEvent (0, FALSE, FALSE, 0); - /* Create our own events to report read and exceptions separately. - The exception event is currently never used. */ + /* Create a manual reset event to signal whether the thread is + stopped. This must be manual reset, because we may wait on + it multiple times without ever starting the thread. */ + state->have_stopped = CreateEvent (0, TRUE, FALSE, 0); + + /* Create our own events to report read and exceptions separately. */ state->read_event = CreateEvent (0, FALSE, FALSE, 0); state->except_event = CreateEvent (0, FALSE, FALSE, 0); - /* And finally start the select thread. */ if (is_tty) - CreateThread (NULL, 0, console_select_thread, scb, 0, &threadId); + state->thread = CreateThread (NULL, 0, console_select_thread, scb, 0, + &threadId); else - CreateThread (NULL, 0, pipe_select_thread, scb, 0, &threadId); + state->thread = CreateThread (NULL, 0, pipe_select_thread, scb, 0, + &threadId); } + *read = state->read_event; + *except = state->except_event; + + /* Start from a blank state. */ ResetEvent (state->read_event); ResetEvent (state->except_event); + ResetEvent (state->stop_select); + + /* First check for a key already in the buffer. If there is one, + we don't need a thread. This also catches the second key of + multi-character returns from getch, for instance for arrow + keys. The second half is in a C library internal buffer, + and PeekConsoleInput will not find it. */ + if (_kbhit ()) + { + SetEvent (state->read_event); + return; + } + /* Otherwise, start the select thread. */ SetEvent (state->start_select); +} - *read = state->read_event; - *except = state->except_event; +static void +ser_console_done_wait_handle (struct serial *scb) +{ + struct ser_console_state *state = scb->state; + + if (state == NULL) + return; + + SetEvent (state->stop_select); + WaitForSingleObject (state->have_stopped, INFINITE); } static void @@ -543,7 +589,14 @@ ser_console_close (struct serial *scb) if (scb->state) { - SetEvent (state->stop_select); + SetEvent (state->exit_select); + + WaitForSingleObject (state->thread, INFINITE); + + CloseHandle (state->start_select); + CloseHandle (state->stop_select); + CloseHandle (state->exit_select); + CloseHandle (state->have_stopped); CloseHandle (state->read_event); CloseHandle (state->except_event); @@ -571,6 +624,217 @@ ser_console_get_tty_state (struct serial *scb) return NULL; } +struct pipe_state +{ + /* Since we use the pipe_select_thread for our select emulation, + we need to place the state structure it requires at the front + of our state. */ + struct ser_console_state wait; + + /* The pex obj for our (one-stage) pipeline. */ + struct pex_obj *pex; + + /* Streams for the pipeline's input and output. */ + FILE *input, *output; +}; + +static struct pipe_state * +make_pipe_state (void) +{ + struct pipe_state *ps = XMALLOC (struct pipe_state); + + memset (ps, 0, sizeof (*ps)); + ps->wait.read_event = INVALID_HANDLE_VALUE; + ps->wait.except_event = INVALID_HANDLE_VALUE; + ps->wait.start_select = INVALID_HANDLE_VALUE; + ps->wait.stop_select = INVALID_HANDLE_VALUE; + + return ps; +} + +static void +free_pipe_state (struct pipe_state *ps) +{ + int saved_errno = errno; + + if (ps->wait.read_event != INVALID_HANDLE_VALUE) + CloseHandle (ps->wait.read_event); + if (ps->wait.except_event != INVALID_HANDLE_VALUE) + CloseHandle (ps->wait.except_event); + if (ps->wait.start_select != INVALID_HANDLE_VALUE) + CloseHandle (ps->wait.start_select); + + /* If we have a select thread running, let the select thread free + the stop event. */ + if (ps->wait.stop_select != INVALID_HANDLE_VALUE) + SetEvent (ps->wait.stop_select); + + /* Close the pipe to the child. We must close the pipe before + calling pex_free because pex_free will wait for the child to exit + and the child will not exit until the pipe is closed. */ + if (ps->input) + fclose (ps->input); + if (ps->pex) + pex_free (ps->pex); + /* pex_free closes ps->output. */ + + xfree (ps); + + errno = saved_errno; +} + +static void +cleanup_pipe_state (void *untyped) +{ + struct pipe_state *ps = untyped; + + free_pipe_state (ps); +} + +static int +pipe_windows_open (struct serial *scb, const char *name) +{ + char **argv = buildargv (name); + struct cleanup *back_to = make_cleanup_freeargv (argv); + if (! argv[0] || argv[0][0] == '\0') + error ("missing child command"); + + struct pipe_state *ps = make_pipe_state (); + make_cleanup (cleanup_pipe_state, ps); + + ps->pex = pex_init (PEX_USE_PIPES, "target remote pipe", NULL); + if (! ps->pex) + goto fail; + ps->input = pex_input_pipe (ps->pex, 1); + if (! ps->input) + goto fail; + + { + int err; + const char *err_msg + = pex_run (ps->pex, PEX_SEARCH | PEX_BINARY_INPUT | PEX_BINARY_OUTPUT, + argv[0], argv, NULL, NULL, + &err); + + if (err_msg) + { + /* Our caller expects us to return -1, but all they'll do with + it generally is print the message based on errno. We have + all the same information here, plus err_msg provided by + pex_run, so we just raise the error here. */ + if (err) + error ("error starting child process '%s': %s: %s", + name, err_msg, safe_strerror (err)); + else + error ("error starting child process '%s': %s", + name, err_msg); + } + } + + ps->output = pex_read_output (ps->pex, 1); + if (! ps->output) + goto fail; + + scb->fd = fileno (ps->output); + scb->state = (void *) ps; + + discard_cleanups (back_to); + return 0; + + fail: + do_cleanups (back_to); + return -1; +} + + +static void +pipe_windows_close (struct serial *scb) +{ + struct pipe_state *ps = scb->state; + + /* In theory, we should try to kill the subprocess here, but the pex + interface doesn't give us enough information to do that. Usually + closing the input pipe will get the message across. */ + + free_pipe_state (ps); +} + + +static int +pipe_windows_read (struct serial *scb, size_t count) +{ + HANDLE pipeline_out = (HANDLE) _get_osfhandle (scb->fd); + if (pipeline_out == INVALID_HANDLE_VALUE) + return -1; + + DWORD available; + if (! PeekNamedPipe (pipeline_out, NULL, 0, NULL, &available, NULL)) + return -1; + + if (count > available) + count = available; + + DWORD bytes_read; + if (! ReadFile (pipeline_out, scb->buf, count, &bytes_read, NULL)) + return -1; + + return bytes_read; +} + + +static int +pipe_windows_write (struct serial *scb, const void *buf, size_t count) +{ + struct pipe_state *ps = scb->state; + int pipeline_in_fd = fileno (ps->input); + if (pipeline_in_fd < 0) + return -1; + + HANDLE pipeline_in = (HANDLE) _get_osfhandle (pipeline_in_fd); + if (pipeline_in == INVALID_HANDLE_VALUE) + return -1; + + DWORD written; + if (! WriteFile (pipeline_in, buf, count, &written, NULL)) + return -1; + + return written; +} + + +static void +pipe_wait_handle (struct serial *scb, HANDLE *read, HANDLE *except) +{ + struct pipe_state *ps = scb->state; + + /* Have we allocated our events yet? */ + if (ps->wait.read_event == INVALID_HANDLE_VALUE) + { + DWORD threadId; + + /* Create auto reset events to wake and terminate the select thread. */ + ps->wait.start_select = CreateEvent (0, FALSE, FALSE, 0); + ps->wait.stop_select = CreateEvent (0, FALSE, FALSE, 0); + + /* Create our own events to report read and exceptions separately. + The exception event is currently never used. */ + ps->wait.read_event = CreateEvent (0, FALSE, FALSE, 0); + ps->wait.except_event = CreateEvent (0, FALSE, FALSE, 0); + + /* Start the select thread. */ + CreateThread (NULL, 0, pipe_select_thread, scb, 0, &threadId); + } + + ResetEvent (ps->wait.read_event); + ResetEvent (ps->wait.except_event); + + SetEvent (ps->wait.start_select); + + *read = ps->wait.read_event; + *except = ps->wait.except_event; +} + + struct net_windows_state { HANDLE read_event; @@ -578,7 +842,12 @@ struct net_windows_state HANDLE start_select; HANDLE stop_select; + HANDLE exit_select; + HANDLE have_stopped; + HANDLE sock_event; + + HANDLE thread; }; static DWORD WINAPI @@ -586,27 +855,24 @@ net_windows_select_thread (void *arg) { struct serial *scb = arg; struct net_windows_state *state, state_copy; - int event_index, fd; + int event_index; - /* Copy useful information out of the control block, to make sure - that we do not race with freeing it. */ - state_copy = *(struct net_windows_state *) scb->state; - state = &state_copy; - fd = scb->fd; + state = scb->state; while (1) { HANDLE wait_events[2]; WSANETWORKEVENTS events; + SetEvent (state->have_stopped); + wait_events[0] = state->start_select; - wait_events[1] = state->stop_select; + wait_events[1] = state->exit_select; if (WaitForMultipleObjects (2, wait_events, FALSE, INFINITE) != WAIT_OBJECT_0) - { - CloseHandle (state->stop_select); - return 0; - } + return 0; + + ResetEvent (state->have_stopped); wait_events[0] = state->stop_select; wait_events[1] = state->sock_event; @@ -615,10 +881,7 @@ net_windows_select_thread (void *arg) if (event_index == WAIT_OBJECT_0 || WaitForSingleObject (state->stop_select, 0) == WAIT_OBJECT_0) - { - CloseHandle (state->stop_select); - return 0; - } + continue; if (event_index != WAIT_OBJECT_0 + 1) { @@ -630,7 +893,9 @@ net_windows_select_thread (void *arg) /* Enumerate the internal network events, and reset the object that signalled us to catch the next event. */ - WSAEnumNetworkEvents (fd, state->sock_event, &events); + WSAEnumNetworkEvents (scb->fd, state->sock_event, &events); + + gdb_assert (events.lNetworkEvents & (FD_READ | FD_CLOSE)); if (events.lNetworkEvents & FD_READ) SetEvent (state->read_event); @@ -645,13 +910,78 @@ net_windows_wait_handle (struct serial *scb, HANDLE *read, HANDLE *except) { struct net_windows_state *state = scb->state; + /* Start from a clean slate. */ ResetEvent (state->read_event); ResetEvent (state->except_event); - - SetEvent (state->start_select); + ResetEvent (state->stop_select); *read = state->read_event; *except = state->except_event; + + /* Check any pending events. This both avoids starting the thread + unnecessarily, and handles stray FD_READ events (see below). */ + if (WaitForSingleObject (state->sock_event, 0) == WAIT_OBJECT_0) + { + WSANETWORKEVENTS events; + int any = 0; + + /* Enumerate the internal network events, and reset the object that + signalled us to catch the next event. */ + WSAEnumNetworkEvents (scb->fd, state->sock_event, &events); + + /* You'd think that FD_READ or FD_CLOSE would be set here. But, + sometimes, neither is. I suspect that the FD_READ is set and + the corresponding event signalled while recv is running, and + the FD_READ is then lowered when recv consumes all the data, + but there's no way to un-signal the event. This isn't a + problem for the call in net_select_thread, since any new + events after this point will not have been drained by recv. + It just means that we can't have the obvious assert here. */ + + /* If there is a read event, it might be still valid, or it might + not be - it may have been signalled before we last called + recv. Double-check that there is data. */ + if (events.lNetworkEvents & FD_READ) + { + unsigned long available; + + if (ioctlsocket (scb->fd, FIONREAD, &available) == 0 + && available > 0) + { + SetEvent (state->read_event); + any = 1; + } + else + /* Oops, no data. This call to recv will cause future + data to retrigger the event, e.g. while we are + in net_select_thread. */ + recv (scb->fd, NULL, 0, 0); + } + + /* If there's a close event, then record it - it is obviously + still valid, and it will not be resignalled. */ + if (events.lNetworkEvents & FD_CLOSE) + { + SetEvent (state->except_event); + any = 1; + } + + /* If we set either handle, there's no need to wake the thread. */ + if (any) + return; + } + + /* Start the select thread. */ + SetEvent (state->start_select); +} + +static void +net_windows_done_wait_handle (struct serial *scb) +{ + struct net_windows_state *state = scb->state; + + SetEvent (state->stop_select); + WaitForSingleObject (state->have_stopped, INFINITE); } static int @@ -669,9 +999,16 @@ net_windows_open (struct serial *scb, const char *name) memset (state, 0, sizeof (struct net_windows_state)); scb->state = state; - /* Create auto reset events to wake and terminate the select thread. */ + /* Create auto reset events to wake, stop, and exit the select + thread. */ state->start_select = CreateEvent (0, FALSE, FALSE, 0); state->stop_select = CreateEvent (0, FALSE, FALSE, 0); + state->exit_select = CreateEvent (0, FALSE, FALSE, 0); + + /* Create a manual reset event to signal whether the thread is + stopped. This must be manual reset, because we may wait on + it multiple times without ever starting the thread. */ + state->have_stopped = CreateEvent (0, TRUE, FALSE, 0); /* Associate an event with the socket. */ state->sock_event = CreateEvent (0, TRUE, FALSE, 0); @@ -682,7 +1019,8 @@ net_windows_open (struct serial *scb, const char *name) state->except_event = CreateEvent (0, FALSE, FALSE, 0); /* And finally start the select thread. */ - CreateThread (NULL, 0, net_windows_select_thread, scb, 0, &threadId); + state->thread = CreateThread (NULL, 0, net_windows_select_thread, scb, 0, + &threadId); return 0; } @@ -693,11 +1031,17 @@ net_windows_close (struct serial *scb) { struct net_windows_state *state = scb->state; - SetEvent (state->stop_select); + SetEvent (state->exit_select); + WaitForSingleObject (state->thread, INFINITE); CloseHandle (state->read_event); CloseHandle (state->except_event); + CloseHandle (state->start_select); + CloseHandle (state->stop_select); + CloseHandle (state->exit_select); + CloseHandle (state->have_stopped); + CloseHandle (state->sock_event); xfree (scb->state); @@ -760,6 +1104,35 @@ _initialize_ser_windows (void) ops->noflush_set_tty_state = ser_base_noflush_set_tty_state; ops->drain_output = ser_base_drain_output; ops->wait_handle = ser_console_wait_handle; + ops->done_wait_handle = ser_console_done_wait_handle; + + serial_add_interface (ops); + + /* The pipe interface. */ + + ops = XMALLOC (struct serial_ops); + memset (ops, 0, sizeof (struct serial_ops)); + ops->name = "pipe"; + ops->next = 0; + ops->open = pipe_windows_open; + ops->close = pipe_windows_close; + ops->readchar = ser_base_readchar; + ops->write = ser_base_write; + ops->flush_output = ser_base_flush_output; + ops->flush_input = ser_base_flush_input; + ops->send_break = ser_base_send_break; + ops->go_raw = ser_base_raw; + ops->get_tty_state = ser_base_get_tty_state; + ops->set_tty_state = ser_base_set_tty_state; + ops->print_tty_state = ser_base_print_tty_state; + ops->noflush_set_tty_state = ser_base_noflush_set_tty_state; + ops->setbaudrate = ser_base_setbaudrate; + ops->setstopbits = ser_base_setstopbits; + ops->drain_output = ser_base_drain_output; + ops->async = ser_base_async; + ops->read_prim = pipe_windows_read; + ops->write_prim = pipe_windows_write; + ops->wait_handle = pipe_wait_handle; serial_add_interface (ops); @@ -792,5 +1165,6 @@ _initialize_ser_windows (void) ops->read_prim = net_read_prim; ops->write_prim = net_write_prim; ops->wait_handle = net_windows_wait_handle; + ops->done_wait_handle = net_windows_done_wait_handle; serial_add_interface (ops); } diff --git a/gdb/serial.c b/gdb/serial.c index fb74e1c..6a2c634 100644 --- a/gdb/serial.c +++ b/gdb/serial.c @@ -557,6 +557,13 @@ serial_wait_handle (struct serial *scb, HANDLE *read, HANDLE *except) *except = NULL; } } + +void +serial_done_wait_handle (struct serial *scb) +{ + if (scb->ops->done_wait_handle) + scb->ops->done_wait_handle (scb); +} #endif #if 0 diff --git a/gdb/serial.h b/gdb/serial.h index d9a395b..8d7ae65 100644 --- a/gdb/serial.h +++ b/gdb/serial.h @@ -253,6 +253,7 @@ struct serial_ops when signaled, in *READ. Return a handle indicating errors in *EXCEPT. */ void (*wait_handle) (struct serial *scb, HANDLE *read, HANDLE *except); + void (*done_wait_handle) (struct serial *scb); #endif /* USE_WIN32API */ }; @@ -270,6 +271,9 @@ extern void serial_log_command (const char *); serial device. */ extern void serial_wait_handle (struct serial *, HANDLE *, HANDLE *); +/* Windows-only: signal that we are done with the wait handles. */ +extern void serial_done_wait_handle (struct serial *); + #endif /* USE_WIN32API */ #endif /* SERIAL_H */ diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 738ee69..a5a673c 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,25 @@ +2006-04-30 Mark Kettenis <kettenis@gnu.org> + + * gdb.base/sigbpt.exp (stepi_out): FAIL when inserting a + single-step breakpoint fails; make this a KFAIL on + sparc*-*-openbsd*. + * gdb.base/siginfo.exp: Likewise. + * gdb.base/sigstep.exp (advance, advancei): Likewise. + +2006-04-26 Michael Snyder <msnyder@redhat.com> + + * gdb.base/multi-forks.exp: Modify patterns for "run to exit", + which may have to consume output from other forks. + Add tests to make sure that "delete fork" succeeded. + +2006-04-20 Michael Snyder <msnyder@redhat.com> + + * 2006-03-22 Jim Blandy <jimb@redhat.com> + Add support for the Renesas M32C and M16C. + + * gdb.asm/asm-source.exp: Add m32c target. + * gdb.asm/m32c.inc: Support for m32c target. + 2006-04-07 Andrew Stubbs <andrew.stubbs@st.com> * gdb.base/commands.exp (recursive_source_test): New test. diff --git a/gdb/testsuite/gdb.asm/asm-source.exp b/gdb/testsuite/gdb.asm/asm-source.exp index cbd38a4..03cc355 100644 --- a/gdb/testsuite/gdb.asm/asm-source.exp +++ b/gdb/testsuite/gdb.asm/asm-source.exp @@ -73,6 +73,9 @@ switch -glob -- [istarget] { "m32r*-linux*" { set asm-arch m32r-linux } + "m32c-*-*" { + set asm-arch m32c + } "m32r*-*" { set asm-arch m32r append link-flags "--whole-archive -lgloss --no-whole-archive" diff --git a/gdb/testsuite/gdb.asm/m32c.inc b/gdb/testsuite/gdb.asm/m32c.inc new file mode 100644 index 0000000..7925e77 --- /dev/null +++ b/gdb/testsuite/gdb.asm/m32c.inc @@ -0,0 +1,33 @@ + comment "subroutine prologue" + .macro gdbasm_enter + enter #0 + .endm + + comment "subroutine epilogue" + .macro gdbasm_leave + exitd + .endm + + .macro gdbasm_call subr + jsr.a \subr + .endm + + .macro gdbasm_several_nops + nop + nop + nop + nop + .endm + + comment "exit (0)" + .macro gdbasm_exit0 + mov.w #0, r1 + mov.b #1, r0l + ste.b r0l,0xe0000 + .endm + + comment "crt0 startup" + .macro gdbasm_startup + ldc #0xfc00, sp + .endm + diff --git a/gdb/testsuite/gdb.base/multi-forks.exp b/gdb/testsuite/gdb.base/multi-forks.exp index 82fdc50..5a706d7 100644 --- a/gdb/testsuite/gdb.base/multi-forks.exp +++ b/gdb/testsuite/gdb.base/multi-forks.exp @@ -67,7 +67,7 @@ gdb_test "set follow child" "" "" send_gdb "continue\n" gdb_expect { - -re ".*Break.* main .*$gdb_prompt $" {} + -re ".*Break.* main .*$gdb_prompt.*$" {} -re ".*$gdb_prompt $" {fail "run to exit 1"} default {fail "run to exit 1 (timeout)"} } @@ -84,7 +84,7 @@ gdb_test "set follow parent" "" "" send_gdb "continue\n" gdb_expect { - -re ".*Break.* main .*$gdb_prompt $" {} + -re ".*Break.* main .*$gdb_prompt.*$" {} -re ".*$gdb_prompt $" {fail "run to exit 2"} default {fail "run to exit 2 (timeout)"} } @@ -136,22 +136,31 @@ gdb_test "detach-fork 3" "Detached .*" "Detach 3" gdb_test "detach-fork 4" "Detached .*" "Detach 4" # -# Test delete-fork +# Test delete fork # -gdb_test "delete-fork 5" "" "Delete 5" -gdb_test "delete-fork 6" "" "Delete 6" -gdb_test "delete-fork 7" "" "Delete 7" -gdb_test "delete-fork 8" "" "Delete 8" -gdb_test "delete-fork 9" "" "Delete 9" -gdb_test "delete-fork 10" "" "Delete 10" -gdb_test "delete-fork 11" "" "Delete 11" -gdb_test "delete-fork 12" "" "Delete 12" -gdb_test "delete-fork 13" "" "Delete 13" -gdb_test "delete-fork 14" "" "Delete 14" -gdb_test "delete-fork 15" "" "Delete 15" - - +gdb_test "delete fork 5" "" "Delete 5" +gdb_test "info fork 5" "No fork number 5." "Did delete 5" +gdb_test "delete fork 6" "" "Delete 6" +gdb_test "info fork 6" "No fork number 6." "Did delete 6" +gdb_test "delete fork 7" "" "Delete 7" +gdb_test "info fork 7" "No fork number 7." "Did delete 7" +gdb_test "delete fork 8" "" "Delete 8" +gdb_test "info fork 8" "No fork number 8." "Did delete 8" +gdb_test "delete fork 9" "" "Delete 9" +gdb_test "info fork 9" "No fork number 9." "Did delete 9" +gdb_test "delete fork 10" "" "Delete 10" +gdb_test "info fork 10" "No fork number 10." "Did delete 10" +gdb_test "delete fork 11" "" "Delete 11" +gdb_test "info fork 11" "No fork number 11." "Did delete 11" +gdb_test "delete fork 12" "" "Delete 12" +gdb_test "info fork 12" "No fork number 12." "Did delete 12" +gdb_test "delete fork 13" "" "Delete 13" +gdb_test "info fork 13" "No fork number 13." "Did delete 13" +gdb_test "delete fork 14" "" "Delete 14" +gdb_test "info fork 14" "No fork number 14." "Did delete 14" +gdb_test "delete fork 15" "" "Delete 15" +gdb_test "info fork 15" "No fork number 15." "Did delete 15" return 0 diff --git a/gdb/testsuite/gdb.base/sigbpt.exp b/gdb/testsuite/gdb.base/sigbpt.exp index 9e010e2..0e69e39 100644 --- a/gdb/testsuite/gdb.base/sigbpt.exp +++ b/gdb/testsuite/gdb.base/sigbpt.exp @@ -166,6 +166,10 @@ proc stepi_out { name args } { # trampoline, and back to the instruction that faulted. set test "${name}; stepi out of handler" gdb_test_multiple "stepi" "$test" { + -re "Could not insert single-step breakpoint.*$gdb_prompt $" { + setup_kfail "sparc*-*-openbsd*" gdb/1736 + fail "$test (could not insert single-step breakpoint)" + } -re "keeper.*$gdb_prompt $" { send_gdb "stepi\n" exp_continue diff --git a/gdb/testsuite/gdb.base/siginfo.exp b/gdb/testsuite/gdb.base/siginfo.exp index a081ab8..d600801 100644 --- a/gdb/testsuite/gdb.base/siginfo.exp +++ b/gdb/testsuite/gdb.base/siginfo.exp @@ -75,6 +75,10 @@ gdb_expect_list "backtrace for nexti" ".*$gdb_prompt $" { # Check that GDB can step the inferior back to main set test "step out of handler" gdb_test_multiple "step" "${test}" { + -re "Could not insert single-step breakpoint.*$gdb_prompt $" { + setup_kfail sparc*-*-openbsd* gdb/1736 + fail "$test (could not insert single-step breakpoint)" + } -re "done = 1;.*${gdb_prompt} $" { send_gdb "$i\n" exp_continue diff --git a/gdb/testsuite/gdb.base/sigstep.exp b/gdb/testsuite/gdb.base/sigstep.exp index 6addca7..9069885 100644 --- a/gdb/testsuite/gdb.base/sigstep.exp +++ b/gdb/testsuite/gdb.base/sigstep.exp @@ -79,6 +79,10 @@ proc advance { i } { set test "$prefix; leave handler" gdb_test_multiple "$i" "${test}" { + -re "Could not insert single-step breakpoint.*$gdb_prompt $" { + setup_kfail "sparc*-*-openbsd*" gdb/1736 + fail "$test (could not insert single-step breakpoint)" + } -re "done = 1;.*${gdb_prompt} $" { send_gdb "$i\n" exp_continue -continue_timer @@ -122,6 +126,10 @@ proc advancei { i } { fail "$test (could not set breakpoint)" return } + -re "Could not insert single-step breakpoint.*$gdb_prompt $" { + setup_kfail "sparc*-*-openbsd*" gdb/1736 + fail "$test (could not insert single-step breakpoint)" + } -re "done = 1;.*${gdb_prompt} $" { send_gdb "$i\n" exp_continue -continue_timer diff --git a/gdb/version.in b/gdb/version.in index 70f27cd..44c55b9 100644 --- a/gdb/version.in +++ b/gdb/version.in @@ -1 +1 @@ -6.4.50.20060420-cvs +6.4.50.20060501-cvs |