diff options
| author | Jim Kingdon <jkingdon@engr.sgi.com> | 1993-11-19 21:16:16 +0000 |
|---|---|---|
| committer | Jim Kingdon <jkingdon@engr.sgi.com> | 1993-11-19 21:16:16 +0000 |
| commit | dbdf5a2a04a2649613e7fdf15b53f960f4dfa1e4 (patch) | |
| tree | 3e4abd15eb83c1907844e48792e1e7dfd8e7a4d9 /gdb | |
| parent | 4961ce5b9c0cbf2d72596183783229af662be56e (diff) | |
| download | gdb-dbdf5a2a04a2649613e7fdf15b53f960f4dfa1e4.zip gdb-dbdf5a2a04a2649613e7fdf15b53f960f4dfa1e4.tar.gz gdb-dbdf5a2a04a2649613e7fdf15b53f960f4dfa1e4.tar.bz2 | |
* symtab.c (decode_line_1): Add comment about use of
return_to_top_level directly instead of error. Add comment saying
that the '' should not be needed--that the completer should be fixed.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/ChangeLog | 6 | ||||
| -rw-r--r-- | gdb/symtab.c | 7 |
2 files changed, 13 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index af3ace2..03fd965 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +Fri Nov 19 15:08:47 1993 Jim Kingdon (kingdon@lioth.cygnus.com) + + * symtab.c (decode_line_1): Add comment about use of + return_to_top_level directly instead of error. Add comment saying + that the '' should not be needed--that the completer should be fixed. + Fri Nov 19 11:00:33 1993 Kung Hsu (kung@cirdan.cygnus.com) * symtab.c(decode_line_1): fix the inconsistency of setting diff --git a/gdb/symtab.c b/gdb/symtab.c index 3279149..9981154 100644 --- a/gdb/symtab.c +++ b/gdb/symtab.c @@ -1644,6 +1644,11 @@ build_canonical_line_spec (sal, symname, canonical) if no file is validly specified. Callers must check that. Also, the line number returned may be invalid. */ +/* We allow single quotes in various places. This is a hideous + kludge, which exists because the completer can't yet deal with the + lack of single quotes. FIXME: write a linespec_completer which we + can use as appropriate instead of make_symbol_completion_list. */ + struct symtabs_and_lines decode_line_1 (argptr, funfirstline, default_symtab, default_line, canonical) char **argptr; @@ -1742,6 +1747,8 @@ decode_line_1 (argptr, funfirstline, default_symtab, default_line, canonical) while(!++p && *p != '>'); if (!p) { + /* FIXME: Why warning() and then return_to_top_level? + What's wrong with error()? */ warning("non-matching '<' and '>' in command"); return_to_top_level (RETURN_ERROR); } |