diff options
| author | Tom Tromey <tom@tromey.com> | 2018-04-29 21:07:03 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2018-04-30 11:33:11 -0600 |
| commit | bbfa6f00867946985b954bbec233c0f25f14ac5c (patch) | |
| tree | cd2c5427f88f6276caa1f0eb6f895185a2aa3753 /gdb/varobj.c | |
| parent | 1831a9f9d3346dbf61202d2aba6935f0093487dd (diff) | |
| download | gdb-bbfa6f00867946985b954bbec233c0f25f14ac5c.zip gdb-bbfa6f00867946985b954bbec233c0f25f14ac5c.tar.gz gdb-bbfa6f00867946985b954bbec233c0f25f14ac5c.tar.bz2 | |
Use new_reference for struct value
value_incref returned its argument just as a convenience, which in the
end turned out to only be used in precisely the cases where
new_reference helps. So, this patch changes value_incref to return
void and changes some value-using code to use new_reference.
I also noticed that the comments for value_incref and value_decref
were swapped, so this patch fixes those.
ChangeLog
2018-04-30 Tom Tromey <tom@tromey.com>
* varobj.c (install_new_value): Use new_reference.
* value.h (value_incref): Return void. Swap intro comment with
value_decref.
* value.c (set_value_parent): Use new_reference.
(value_incref): Return void. Update intro comment.
(release_value): Use new_reference.
* dwarf2loc.c (dwarf2_evaluate_loc_desc_full): Use new_reference.
Diffstat (limited to 'gdb/varobj.c')
| -rw-r--r-- | gdb/varobj.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/varobj.c b/gdb/varobj.c index 2d00964..4656bfa 100644 --- a/gdb/varobj.c +++ b/gdb/varobj.c @@ -1329,7 +1329,7 @@ install_new_value (struct varobj *var, struct value *value, bool initial) code that might release it. */ value_ref_ptr value_holder; if (value != NULL) - value_holder.reset (value_incref (value)); + value_holder = value_ref_ptr::new_reference (value); /* Below, we'll be comparing string rendering of old and new values. Don't get string rendering if the value is |