aboutsummaryrefslogtreecommitdiff
path: root/gdb/value.c
diff options
context:
space:
mode:
authorSimon Marchi <simon.marchi@ericsson.com>2015-07-06 13:04:11 -0400
committerSimon Marchi <simon.marchi@ericsson.com>2015-07-06 13:04:11 -0400
commita844296a982bdff7c14dab355de0fca75486add6 (patch)
treea195704067eff26020a86fbeb30bcc7cffb6762e /gdb/value.c
parentf41cbf58f4af65e8612585c45208f3690a39ea28 (diff)
downloadgdb-a844296a982bdff7c14dab355de0fca75486add6.zip
gdb-a844296a982bdff7c14dab355de0fca75486add6.tar.gz
gdb-a844296a982bdff7c14dab355de0fca75486add6.tar.bz2
Cleanup value_fetch_lazy's comment and return value
The comment for value_fetch_lazy seems outdated. It says that it's only called from the value_contents and value_contents_all (macros!), which is not true. Also, the return value seems useless now, despite what the comment says. gdb/ChangeLog: * value.c (value_fetch_lazy): Update comment, change return value to void. * value.h (value_fetch_lazy): Change return value to void.
Diffstat (limited to 'gdb/value.c')
-rw-r--r--gdb/value.c17
1 files changed, 5 insertions, 12 deletions
diff --git a/gdb/value.c b/gdb/value.c
index 86d7d00..a01f390 100644
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -3781,21 +3781,15 @@ value_initialized (struct value *val)
return val->initialized;
}
-/* Called only from the value_contents and value_contents_all()
- macros, if the current data for a variable needs to be loaded into
- value_contents(VAL). Fetches the data from the user's process, and
- clears the lazy flag to indicate that the data in the buffer is
- valid.
+/* Load the actual content of a lazy value. Fetch the data from the
+ user's process and clear the lazy flag to indicate that the data in
+ the buffer is valid.
If the value is zero-length, we avoid calling read_memory, which
would abort. We mark the value as fetched anyway -- all 0 bytes of
- it.
+ it. */
- This function returns a value because it is used in the
- value_contents macro as part of an expression, where a void would
- not work. The value is ignored. */
-
-int
+void
value_fetch_lazy (struct value *val)
{
gdb_assert (value_lazy (val));
@@ -3947,7 +3941,6 @@ value_fetch_lazy (struct value *val)
internal_error (__FILE__, __LINE__, _("Unexpected lazy value type."));
set_value_lazy (val, 0);
- return 0;
}
/* Implementation of the convenience function $_isvoid. */