diff options
author | Pedro Alves <palves@redhat.com> | 2013-03-07 19:10:46 +0000 |
---|---|---|
committer | Pedro Alves <palves@redhat.com> | 2013-03-07 19:10:46 +0000 |
commit | 2898e56054c7a35f85908729b01c6eb763317269 (patch) | |
tree | 0fdd7210d07f603d9e91c1531feb2f27fca8f620 /gdb/valprint.c | |
parent | a09b444817a6a61ec6323e7e6dcc4ccbf465826f (diff) | |
download | gdb-2898e56054c7a35f85908729b01c6eb763317269.zip gdb-2898e56054c7a35f85908729b01c6eb763317269.tar.gz gdb-2898e56054c7a35f85908729b01c6eb763317269.tar.bz2 |
charset.c: fix -Wpointer-sign
$ make WERROR_CFLAGS="-Wpointer-sign -Werror" charset.o 2>&1 1>/dev/null
../../src/gdb/charset.c: In function ‘wchar_iterate’:
../../src/gdb/charset.c:665:13: error: pointer targets in assignment differ in signedness [-Werror=pointer-sign]
../../src/gdb/charset.c:691:13: error: pointer targets in assignment differ in signedness [-Werror=pointer-sign]
../../src/gdb/charset.c:706:12: error: pointer targets in assignment differ in signedness [-Werror=pointer-sign]
The encoding conversion code works with gdb_byte arrays as the generic
buffers that hold strings of any encoding/width. Changing the type of
this field to gdb_byte* removes the need for one cast, and makes
everything work with the same types. That's good -- WRT to strings,
"char *" is (almost) consistently throughout GDB only used for
ascii-ish strings.
gdb/
2013-03-07 Pedro Alves <palves@redhat.com>
* charset.c (struct wchar_iterator) <input>: Change type to 'const
gdb_byte *'.
(make_wchar_iterator): Remove cast to char*.
(wchar_iterate): Change type of local.
Diffstat (limited to 'gdb/valprint.c')
0 files changed, 0 insertions, 0 deletions