diff options
| author | Andreas Arnez <arnez@linux.vnet.ibm.com> | 2017-06-13 15:20:31 +0200 |
|---|---|---|
| committer | Andreas Arnez <arnez@linux.vnet.ibm.com> | 2017-06-13 15:20:31 +0200 |
| commit | 23f945bf8cebf348154aff43782de2e1977e9230 (patch) | |
| tree | f4117bc4ecbce340ec673335ca084de240bdb969 /gdb/valops.c | |
| parent | f236533e3c6a2693bea879b2a4d24d1229864ac9 (diff) | |
| download | gdb-23f945bf8cebf348154aff43782de2e1977e9230.zip gdb-23f945bf8cebf348154aff43782de2e1977e9230.tar.gz gdb-23f945bf8cebf348154aff43782de2e1977e9230.tar.bz2 | |
Fix bit-/byte-offset mismatch in parameter to read_value_memory
The function read_value_memory accepts a parameter embedded_offset and
expects it to represent the byte offset into the given value. However,
the only invocation with a possibly non-zero embedded_offset happens in
read_pieced_value, where a bit offset is passed instead.
Adjust the implementation of read_value_memory to meet the caller's
expectation. This implicitly fixes the invocation in read_pieced_value.
gdb/ChangeLog:
* valops.c (read_value_memory): Change embedded_offset to
represent a bit offset instead of a byte offset.
* value.h (read_value_memory): Adjust comment.
Diffstat (limited to 'gdb/valops.c')
| -rw-r--r-- | gdb/valops.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/gdb/valops.c b/gdb/valops.c index 93ae6cf..8675e6c 100644 --- a/gdb/valops.c +++ b/gdb/valops.c @@ -958,7 +958,7 @@ value_at_lazy (struct type *type, CORE_ADDR addr) } void -read_value_memory (struct value *val, LONGEST embedded_offset, +read_value_memory (struct value *val, LONGEST bit_offset, int stack, CORE_ADDR memaddr, gdb_byte *buffer, size_t length) { @@ -984,8 +984,9 @@ read_value_memory (struct value *val, LONGEST embedded_offset, if (status == TARGET_XFER_OK) /* nothing */; else if (status == TARGET_XFER_UNAVAILABLE) - mark_value_bytes_unavailable (val, embedded_offset + xfered_total, - xfered_partial); + mark_value_bits_unavailable (val, (xfered_total * HOST_CHAR_BIT + + bit_offset), + xfered_partial * HOST_CHAR_BIT); else if (status == TARGET_XFER_EOF) memory_error (TARGET_XFER_E_IO, memaddr + xfered_total); else |