diff options
| author | Joel Brobecker <brobecker@adacore.com> | 2020-11-23 21:46:38 -0500 |
|---|---|---|
| committer | Joel Brobecker <brobecker@adacore.com> | 2020-11-23 21:46:38 -0500 |
| commit | c9f0b43fe46f473e4de3494f95b11ffb3d5a42a8 (patch) | |
| tree | 3413d683bf1843314a98ca795a8ee8ec849de3ee /gdb/valops.c | |
| parent | 987b670356322ba4d493f441855bf5dc8d946e9f (diff) | |
| download | gdb-c9f0b43fe46f473e4de3494f95b11ffb3d5a42a8.zip gdb-c9f0b43fe46f473e4de3494f95b11ffb3d5a42a8.tar.gz gdb-c9f0b43fe46f473e4de3494f95b11ffb3d5a42a8.tar.bz2 | |
gmp-utils: Convert the read/write methods to using gdb::array_view
This commit changes the interfaces of some of the methods declared
in gmp-utils to take a gdb::array_view of gdb_byte instead of a
(gdb_byte *, size) couple.
This makes these methods' API probably more C++-idiomatic.
* gmp-utils.h (gdb_mpz::read): Change buf and len parameters
into one single gdb::array_view parameter.
(gdb_mpz::write): Likewise.
(gdb_mpq::read_fixed_point, gdb_mpq::write_fixed_point): Likewise.
* gmp-utils.c (gdb_mpz::read): Change buf and len parameters
into one single gdb::array_view parameter.
Adjust implementation accordingly.
(gdb_mpz::write): Likewise.
(gdb_mpq::read_fixed_point, gdb_mpq::write_fixed_point): Likewise.
* unittests/gmp-utils-selftests.c: Adapt following changes above.
* valarith.c, valops.c, valprint.c, value.c: Likewise.
Diffstat (limited to 'gdb/valops.c')
| -rw-r--r-- | gdb/valops.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/gdb/valops.c b/gdb/valops.c index 0f84a70..3e2d5d3 100644 --- a/gdb/valops.c +++ b/gdb/valops.c @@ -357,7 +357,8 @@ value_cast_to_fixed_point (struct type *to_type, struct value *from_val) { gdb_mpz vz; - vz.read (value_contents (from_val), TYPE_LENGTH (from_type), + vz.read (gdb::make_array_view (value_contents (from_val), + TYPE_LENGTH (from_type)), type_byte_order (from_type), from_type->is_unsigned ()); mpq_set_z (vq.val, vz.val); @@ -378,8 +379,9 @@ value_cast_to_fixed_point (struct type *to_type, struct value *from_val) /* Finally, create the result value, and pack the unscaled value in it. */ struct value *result = allocate_value (to_type); - unscaled.write (value_contents_raw (result), - TYPE_LENGTH (to_type), type_byte_order (to_type), + unscaled.write (gdb::make_array_view (value_contents_raw (result), + TYPE_LENGTH (to_type)), + type_byte_order (to_type), to_type->is_unsigned ()); return result; @@ -523,7 +525,7 @@ value_cast (struct type *type, struct value *arg2) gdb_mpq fp_val; fp_val.read_fixed_point - (value_contents (arg2), TYPE_LENGTH (type2), + (gdb::make_array_view (value_contents (arg2), TYPE_LENGTH (type2)), type_byte_order (type2), type2->is_unsigned (), fixed_point_scaling_factor (type2)); |