aboutsummaryrefslogtreecommitdiff
path: root/gdb/valops.c
diff options
context:
space:
mode:
authorSimon Marchi <simon.marchi@polymtl.ca>2021-10-25 23:29:34 -0400
committerSimon Marchi <simon.marchi@polymtl.ca>2021-12-03 16:41:38 -0500
commit2a50938ab740296a1d6df67feea9401e57e4d90e (patch)
treec0a570783faab4b4e5225e14a434739fa0264536 /gdb/valops.c
parent4bce7cdaf481901edbc5ee47d953ea7e8efb56ca (diff)
downloadgdb-2a50938ab740296a1d6df67feea9401e57e4d90e.zip
gdb-2a50938ab740296a1d6df67feea9401e57e4d90e.tar.gz
gdb-2a50938ab740296a1d6df67feea9401e57e4d90e.tar.bz2
gdb: make extract_integer take an array_view
I think it would make sense for extract_integer, extract_signed_integer and extract_unsigned_integer to take an array_view. This way, when we extract an integer, we can validate that we don't overflow the buffer passed by the caller (e.g. ask to extract a 4-byte integer but pass a 2-byte buffer). - Change extract_integer to take an array_view - Add overloads of extract_signed_integer and extract_unsigned_integer that take array_views. Keep the existing versions so we don't need to change all callers, but make them call the array_view versions. This shortens some places like: result = extract_unsigned_integer (value_contents (result_val).data (), TYPE_LENGTH (value_type (result_val)), byte_order); into result = extract_unsigned_integer (value_contents (result_val), byte_order); value_contents returns an array view that is of length `TYPE_LENGTH (value_type (result_val))` already, so the length is implicitly communicated through the array view. Change-Id: Ic1c1f98c88d5c17a8486393af316f982604d6c95
Diffstat (limited to 'gdb/valops.c')
-rw-r--r--gdb/valops.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/gdb/valops.c b/gdb/valops.c
index ca71c12..779ca93 100644
--- a/gdb/valops.c
+++ b/gdb/valops.c
@@ -587,8 +587,7 @@ value_cast (struct type *type, struct value *arg2)
bits. */
if (code2 == TYPE_CODE_PTR)
longest = extract_unsigned_integer
- (value_contents (arg2).data (), TYPE_LENGTH (type2),
- type_byte_order (type2));
+ (value_contents (arg2), type_byte_order (type2));
else
longest = value_as_long (arg2);
return value_from_longest (to_type, convert_to_boolean ?