aboutsummaryrefslogtreecommitdiff
path: root/gdb/valops.c
diff options
context:
space:
mode:
authorDavid Taylor <taylor@redhat.com>2001-02-06 18:07:48 +0000
committerDavid Taylor <taylor@redhat.com>2001-02-06 18:07:48 +0000
commit4603e466c25f063a9d4a821966f7368fefd4524f (patch)
tree3958905ec0f48325639cd6a21e3540b6f889e48c /gdb/valops.c
parent0e2534bd0420626b6bb4949938551c0cc02d3aa8 (diff)
downloadgdb-4603e466c25f063a9d4a821966f7368fefd4524f.zip
gdb-4603e466c25f063a9d4a821966f7368fefd4524f.tar.gz
gdb-4603e466c25f063a9d4a821966f7368fefd4524f.tar.bz2
* valops.c (value_cast): If casting a scalar to a pointer, do not
issue a message about truncation unless it exceeds the length of an address, not the length of a pointer. This is because what the user gives us is an address, not a pointer, and we will ultimately convert it (via ADDRESS_TO_POINTER) to a pointer, not truncate it to a pointer. This allows things like "print *(int *)0x01000234" to work without generating a misleading message on a target having two byte pointers and four byte addresses.
Diffstat (limited to 'gdb/valops.c')
-rw-r--r--gdb/valops.c19
1 files changed, 15 insertions, 4 deletions
diff --git a/gdb/valops.c b/gdb/valops.c
index b546808..9a90e3d 100644
--- a/gdb/valops.c
+++ b/gdb/valops.c
@@ -287,12 +287,23 @@ value_cast (struct type *type, register value_ptr arg2)
code2 == TYPE_CODE_ENUM ||
code2 == TYPE_CODE_RANGE))
{
- int ptr_bit = HOST_CHAR_BIT * TYPE_LENGTH (type);
+ /* TYPE_LENGTH (type) is the length of a pointer, but we really
+ want the length of an address! -- we are really dealing with
+ addresses (i.e., gdb representations) not pointers (i.e.,
+ target representations) here.
+
+ This allows things like "print *(int *)0x01000234" to work
+ without printing a misleading message -- which would
+ otherwise occur when dealing with a target having two byte
+ pointers and four byte addresses. */
+
+ int addr_bit = TARGET_ADDR_BIT;
+
LONGEST longest = value_as_long (arg2);
- if (ptr_bit < sizeof (LONGEST) * HOST_CHAR_BIT)
+ if (addr_bit < sizeof (LONGEST) * HOST_CHAR_BIT)
{
- if (longest >= ((LONGEST) 1 << ptr_bit)
- || longest <= -((LONGEST) 1 << ptr_bit))
+ if (longest >= ((LONGEST) 1 << addr_bit)
+ || longest <= -((LONGEST) 1 << addr_bit))
warning ("value truncated");
}
return value_from_longest (type, longest);