aboutsummaryrefslogtreecommitdiff
path: root/gdb/unittests/scoped_mmap-selftests.c
diff options
context:
space:
mode:
authorTom Tromey <tom@tromey.com>2018-09-20 16:04:04 -0600
committerTom Tromey <tom@tromey.com>2018-10-27 11:58:41 -0600
commitb3279b601e67ce47263082ef86cfc86e25607c5e (patch)
tree3541a773fd698068cad1ae16a2842257c845eb61 /gdb/unittests/scoped_mmap-selftests.c
parente418a61a67a3476826259163383e5deb661042cc (diff)
downloadgdb-b3279b601e67ce47263082ef86cfc86e25607c5e.zip
gdb-b3279b601e67ce47263082ef86cfc86e25607c5e.tar.gz
gdb-b3279b601e67ce47263082ef86cfc86e25607c5e.tar.bz2
Use mkostemp, not mkstemp
I noticed that gdb could leak file descriptors coming from mkstemp. This patch fixes the problem by importing the gnulib mkostemp instead, and then changing gdb to pass O_CLOEXEC. A small gnulib patch was needed. This has already been accepted upstream. gdb/ChangeLog 2018-10-27 Tom Tromey <tom@tromey.com> * unittests/scoped_mmap-selftests.c (test_normal): Use gdb_mkostemp_cloexec. * unittests/scoped_fd-selftests.c (test_destroy, test_release): Use gdb_mkostemp_cloexec. * gnulib/aclocal-m4-deps.mk, gnulib/aclocal.m4, gnulib/config.in, gnulib/configure, gnulib/import/Makefile.am, gnulib/import/Makefile.in, gnulib/import/m4/gnulib-cache.m4, gnulib/import/m4/gnulib-comp.m4: Update. * gnulib/import/m4/mkostemp.m4: New file. * gnulib/import/m4/mkstemp.m4: Remove. * gnulib/import/mkostemp.c: New file. * gnulib/import/mkstemp.m4: Remove. * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Remove mkstemp, add mkostemp. Apply new patch. * gnulib/import/stdlib.in.h: Apply patch. * gnulib/patches/0002-mkostemp-mkostemps-Fix-compilation-error-in-C-mode-o.patch: New file. * dwarf-index-write.c (write_psymtabs_to_index): Use gdb_mkostemp_cloexec. * common/filestuff.h (gdb_mkostemp_cloexec): New function.
Diffstat (limited to 'gdb/unittests/scoped_mmap-selftests.c')
-rw-r--r--gdb/unittests/scoped_mmap-selftests.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/gdb/unittests/scoped_mmap-selftests.c b/gdb/unittests/scoped_mmap-selftests.c
index b181e02..75d1aed 100644
--- a/gdb/unittests/scoped_mmap-selftests.c
+++ b/gdb/unittests/scoped_mmap-selftests.c
@@ -19,6 +19,7 @@
#include "defs.h"
+#include "common/filestuff.h"
#include "common/scoped_mmap.h"
#include "config.h"
@@ -88,7 +89,7 @@ static void
test_normal ()
{
char filename[] = "scoped_mmapped_file-selftest-XXXXXX";
- int fd = mkstemp (filename);
+ int fd = gdb_mkostemp_cloexec (filename);
SELF_CHECK (fd >= 0);
SELF_CHECK (write (fd, "Hello!", 7) == 7);