diff options
| author | Tom Tromey <tromey@adacore.com> | 2019-04-30 11:17:15 -0600 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2019-06-14 14:13:29 -0600 |
| commit | 0735b091aba72d4b35aebb671a02c5cb4a837fe9 (patch) | |
| tree | c261406309225cb02197ba53b895a8030f0fc442 /gdb/ui-style.h | |
| parent | 52ce35e2894e55cea94011dda6443be51e154f37 (diff) | |
| download | gdb-0735b091aba72d4b35aebb671a02c5cb4a837fe9.zip gdb-0735b091aba72d4b35aebb671a02c5cb4a837fe9.tar.gz gdb-0735b091aba72d4b35aebb671a02c5cb4a837fe9.tar.bz2 | |
Do not emit style escape sequences to log file
PR gdb/24502 requests that the "set logging" log file not contain
style escape sequences emitted by gdb.
This seemed like a reasonable request to me, so this patch implements
filtering for the log file.
This also updates a comment in ui-style.h that I noticed while writing
the patch.
Tested on x86-64 Fedora 29.
gdb/ChangeLog
2019-06-14 Tom Tromey <tromey@adacore.com>
PR gdb/24502:
* ui-style.h (skip_ansi_escape): Update comment.
* ui-file.h (class no_terminal_escape_file): New class.
* ui-file.c (no_terminal_escape_file::write)
(no_terminal_escape_file::puts): New methods.
* cli/cli-logging.c (handle_redirections): Use
no_terminal_escape_file.
gdb/testsuite/ChangeLog
2019-06-14 Tom Tromey <tromey@adacore.com>
PR gdb/24502:
* gdb.base/style-logging.exp: New file.
Diffstat (limited to 'gdb/ui-style.h')
| -rw-r--r-- | gdb/ui-style.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gdb/ui-style.h b/gdb/ui-style.h index 2a87fbe..24b4b59 100644 --- a/gdb/ui-style.h +++ b/gdb/ui-style.h @@ -233,8 +233,8 @@ private: /* Skip an ANSI escape sequence in BUF. BUF must begin with an ESC character. Return true if an escape sequence was successfully - skipped; false otherwise. In either case, N_READ is updated to - reflect the number of chars read from BUF. */ + skipped; false otherwise. If an escape sequence was skipped, + N_READ is updated to reflect the number of chars read from BUF. */ extern bool skip_ansi_escape (const char *buf, int *n_read); |