diff options
author | Yao Qi <yao@codesourcery.com> | 2013-08-28 12:25:05 +0000 |
---|---|---|
committer | Yao Qi <yao@codesourcery.com> | 2013-08-28 12:25:05 +0000 |
commit | ffa4ac956c9389aee7e46708492f61fdd69cd845 (patch) | |
tree | 8e86ad404795f41d9d7a88dcec2bf69b668f9a33 /gdb/ui-file.c | |
parent | 7e1050317266448c0496db46eadd546410b07c0a (diff) | |
download | gdb-ffa4ac956c9389aee7e46708492f61fdd69cd845.zip gdb-ffa4ac956c9389aee7e46708492f61fdd69cd845.tar.gz gdb-ffa4ac956c9389aee7e46708492f61fdd69cd845.tar.bz2 |
gdb/
* event-top.c (gdb_setup_readline): Call stderr_fileopen
instead of stdio_fileopen.
* main.c (captured_main) [__MINGW32__]: Set stderr unbuffered.
.Call stderr_fileopen instead of stdio_fileopen.
* ui-file.c [__MINGW32__] (stderr_file_write): New function.
[__MINGW32__] (stderr_file_fputs): New function.
(stderr_fileopen): New function.
* ui-file.h (stderr_fileopen): Declare.
Diffstat (limited to 'gdb/ui-file.c')
-rw-r--r-- | gdb/ui-file.c | 54 |
1 files changed, 54 insertions, 0 deletions
diff --git a/gdb/ui-file.c b/gdb/ui-file.c index cf5a86d..b9d3e53 100644 --- a/gdb/ui-file.c +++ b/gdb/ui-file.c @@ -654,6 +654,60 @@ stdio_file_fseek (struct ui_file *file, long offset, int whence) return fseek (stdio->file, offset, whence); } +#ifdef __MINGW32__ +/* This is the implementation of ui_file method to_write for stderr. + gdb_stdout is flushed before writing to gdb_stderr. */ + +static void +stderr_file_write (struct ui_file *file, const char *buf, long length_buf) +{ + gdb_flush (gdb_stdout); + stdio_file_write (file, buf, length_buf); +} + +/* This is the implementation of ui_file method to_fputs for stderr. + gdb_stdout is flushed before writing to gdb_stderr. */ + +static void +stderr_file_fputs (const char *linebuffer, struct ui_file *file) +{ + gdb_flush (gdb_stdout); + stdio_file_fputs (linebuffer, file); +} +#endif + +struct ui_file * +stderr_fileopen (void) +{ + struct ui_file *ui_file = stdio_fileopen (stderr); + +#ifdef __MINGW32__ + /* There is no real line-buffering on Windows, see + http://msdn.microsoft.com/en-us/library/86cebhfs%28v=vs.71%29.aspx + so the stdout is either fully-buffered or non-buffered. We can't + make stdout non-buffered, because of two concerns, + 1. non-buffering hurts performance, + 2. non-buffering may change GDB's behavior when it is interacting + with front-end, such as Emacs. + + We decided to leave stdout as fully buffered, but flush it first + when something is written to stderr. */ + + /* Method 'to_write_async_safe' is not overwritten, because there's + no way to flush a stream in an async-safe manner. Fortunately, + it doesn't really matter, because: + - that method is only used for printing internal debug output + from signal handlers. + - Windows hosts don't have a concept of async-safeness. Signal + handlers run in a separate thread, so they can call + the regular non-async-safe output routines freely. */ + set_ui_file_write (ui_file, stderr_file_write); + set_ui_file_fputs (ui_file, stderr_file_fputs); +#endif + + return ui_file; +} + /* Like fdopen(). Create a ui_file from a previously opened FILE. */ struct ui_file * |