diff options
| author | Tom Tromey <tom@tromey.com> | 2019-07-11 18:03:45 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2019-08-16 11:28:33 -0600 |
| commit | 2d83e710a14c62cb6a9501c84fc46062f817428d (patch) | |
| tree | 41d8a7abaf3e973def1e830242591b5eb24d432e /gdb/tui/tui-wingeneral.c | |
| parent | d4ab829a2477d454bd38544f1b88a043ec58581c (diff) | |
| download | gdb-2d83e710a14c62cb6a9501c84fc46062f817428d.zip gdb-2d83e710a14c62cb6a9501c84fc46062f817428d.tar.gz gdb-2d83e710a14c62cb6a9501c84fc46062f817428d.tar.bz2 | |
Remove separate visibility flag
TUI windows keep track of their visibility in a boolean field.
However, this is not needed, because a window is visible if and only
if it has an underlying curses handle. So, we can remove this
separate field.
gdb/ChangeLog
2019-08-16 Tom Tromey <tom@tromey.com>
* tui/tui.c (tui_is_window_visible): Update.
* tui/tui-wingeneral.c (tui_make_window)
(tui_gen_win_info::make_visible, tui_refresh_all): Update.
* tui/tui-win.c (window_name_completer, tui_refresh_all_win)
(tui_set_focus_command, tui_all_windows_info, update_tab_width)
(tui_set_win_height_command, parse_scrolling_args): Update.
* tui/tui-source.c (tui_source_window::style_changed): Update.
* tui/tui-regs.c (tui_show_registers)
(tui_data_window::first_data_item_displayed)
(tui_data_window::delete_data_content_windows)
(tui_check_register_values, tui_reg_command): Update.
* tui/tui-disasm.c (tui_show_disassem): Update.
* tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
method.
<is_visible>: Remove field.
* tui/tui-data.c (tui_next_win, tui_prev_win)
(tui_delete_invisible_windows): Update.
Diffstat (limited to 'gdb/tui/tui-wingeneral.c')
| -rw-r--r-- | gdb/tui/tui-wingeneral.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/gdb/tui/tui-wingeneral.c b/gdb/tui/tui-wingeneral.c index 52583cf..4e565bd 100644 --- a/gdb/tui/tui-wingeneral.c +++ b/gdb/tui/tui-wingeneral.c @@ -139,7 +139,6 @@ tui_make_window (struct tui_gen_win_info *win_info) { if (win_info->can_box ()) box_win (win_info, NO_HILITE); - win_info->is_visible = true; scrollok (handle, TRUE); } } @@ -151,9 +150,8 @@ tui_make_window (struct tui_gen_win_info *win_info) void tui_gen_win_info::make_visible (bool visible) { - if (is_visible == visible) + if (is_visible () == visible) return; - is_visible = visible; if (visible) tui_make_window (this); @@ -182,10 +180,10 @@ tui_refresh_all () for (tui_win_info *win_info : all_tui_windows ()) { - if (win_info->is_visible) + if (win_info->is_visible ()) win_info->refresh_window (); } - if (locator->is_visible) + if (locator->is_visible ()) locator->refresh_window (); } |