diff options
| author | Andrew Burgess <andrew.burgess@embecosm.com> | 2020-01-07 11:39:17 +0000 |
|---|---|---|
| committer | Andrew Burgess <andrew.burgess@embecosm.com> | 2020-01-09 23:11:47 +0000 |
| commit | f5a7c406b1975cde626efed526960f2cf1bdaceb (patch) | |
| tree | 79e1814d89c4158fcab301d2c1891c891962e791 /gdb/tui/tui-source.c | |
| parent | 9ae6bf640dc7c950e6f36097a3d2d760a132a542 (diff) | |
| download | gdb-f5a7c406b1975cde626efed526960f2cf1bdaceb.zip gdb-f5a7c406b1975cde626efed526960f2cf1bdaceb.tar.gz gdb-f5a7c406b1975cde626efed526960f2cf1bdaceb.tar.bz2 | |
gdb/tui: Link source and assembler scrolling .... again
Until recently when the source window was scrolled the assembler
window would scroll in sync - keeping the disassembly for the current
line in view.
This was broken in commit:
commit b4b49dcbff6b437fa8b4e2fc0c3f27b457f11310
Date: Wed Nov 13 16:47:58 2019 -0700
Don't call tui_show_source from tui_ui_out
This commit restores the synchronised scrolling and also maintains the
horizontal scroll within the source view when it is vertically
scrolled, something that was broken before.
This commit does not mean that scrolling the assembler view scrolls
the source view. The connection this way never existed, though maybe
it should, but I'll leave adding this feature for a separate commit.
gdb/ChangeLog:
* tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
all source windows, and maintain horizontal scroll status while
doing so.
gdb/testsuite/ChangeLog:
* gdb.tui/basic.exp: Add more scrolling tests.
Change-Id: I250114a3bc670040a6a759d41905776771b2f818
Diffstat (limited to 'gdb/tui/tui-source.c')
| -rw-r--r-- | gdb/tui/tui-source.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/gdb/tui/tui-source.c b/gdb/tui/tui-source.c index 13f2dc7..912eaa4 100644 --- a/gdb/tui/tui-source.c +++ b/gdb/tui/tui-source.c @@ -158,7 +158,9 @@ tui_source_window::do_scroll_vertical (int num_to_scroll) line_no = 1; cursal.line = line_no; - update_source_window (arch, cursal); + find_line_pc (cursal.symtab, cursal.line, &cursal.pc); + for (struct tui_source_window_base *win_info : tui_source_windows ()) + win_info->update_source_window_as_is (arch, cursal); } } |